Clean logic

2023-12-29 19:48:48 -05:00
parent 9adccf96d9
commit 5a385d5edb
1 changed files with 5 additions and 4 deletions
@@ -8,13 +8,14 @@ from . import xmo
@click.pass_obj
 async def disable_wifi_radios(client: SagemcomClient, radios: tuple[str] | list[str]) -> None:
    try:
-        value = await client.get_value_by_xpath('Device/WiFi/Radios')
-        active_radios = {radio['alias'] for radio in value if radio.keys() >= {'alias', 'enable'} and \
+        _radios = await client.get_value_by_xpath('Device/WiFi/Radios')
+        active_radios = {radio['alias'] for radio in _radios \
+            if radio.keys() >= {'alias', 'enable'} and \
            radio['enable']}
-        if not len(active_radios):
+        if active_radios:
            click.echo('No active radios')
            return
-        if not len(radios):
+        if radios:
            radios = click.prompt('Choose radio', type=click.Choice(active_radios), show_choices=True),
        invalid_radios = set(radios) - active_radios
        if len(invalid_radios):