Alexander Udalov
1cb1420e43
This is basically a workaround for a slightly different IR generated by
fir2ir vs psi2ir. Simplified, psi2ir generates something like this for
the sample from KT-59218:
TRY type=Unit
try: BLOCK type=Unit
VAR methodHandle [...]
TYPE_OP type=Unit origin=IMPLICIT_COERCION_TO_UNIT
CALL invokeExact [...]
While fir2ir generates the following:
TYPE_OP type=Unit origin=IMPLICIT_COERCION_TO_UNIT
TRY type=Any?
try: BLOCK type=Any?
VAR methodHandle [...]
CALL invokeExact [...]
The lowering relies on the fact that a polymorphic call (`invokeExact`
in this case) is a direct argument to the TYPE_OP, to determine the
correct return type (Unit in this case) to be generated in the bytecode.
The solution here is to push the type coercion "through" all the
block-like structures (`try`, `when`, container expression) so that if
the last statement in the block is a polymorphic call, it gets properly
converted even if the whole block is under a type coercion operation, as
it happens in fir2ir. We achieve that by using the "data" parameter of
the IR transformer: appropriate immediate children of
IrTypeOperatorCall/IrTry/IrWhen/IrContainerExpression get the type that
the expression needs to be coerced to, and all the other expressions
ignore that type and set it to null when transforming their children.
A proper solution would be to ensure fir2ir generates exactly the same
IR as psi2ir (KT-59781), but since PolymorphicSignatureLowering is the
only lowering affected so far, and polymorphic calls occur very rarely,
it seems safe to workaround it in the lowering for now.
#KT-59218 Fixed
Kotlin Programming Language
Welcome to Kotlin!
It is an open-source, statically typed programming language supported and developed by JetBrains and open-source contributors.
Some handy links:
- Kotlin Site
- Getting Started Guide
- Try Kotlin
- Kotlin Standard Library
- Issue Tracker
- Kotlin YouTube Channel
- Forum
- Kotlin Blog
- Subscribe to Kotlin YouTube channel
- Follow Kotlin on Twitter
- Public Slack channel
- TeamCity CI build
Kotlin Multiplatform capabilities
Support for multiplatform programming is one of Kotlin’s key benefits. It reduces time spent writing and maintaining the same code for different platforms while retaining the flexibility and benefits of native programming.
- Kotlin Multiplatform Mobile for sharing code between Android and iOS
- Getting Started with Kotlin Multiplatform Mobile Guide
- Kotlin Multiplatform Benefits
- Share code on all platforms
- Share code on similar platforms
Editing Kotlin
Build environment requirements
This repository is using Gradle toolchains feature to select and auto-provision required JDKs from AdoptOpenJdk project.
Unfortunately AdoptOpenJdk project does not provide required JDK 1.6 and 1.7 images,
so you could either download them manually and provide path to installation via JDK_1_6 and JDK_1_7 environment variables or
use following SDK managers:
Alternatively, it is still possible to only provide required JDKs via environment variables
(see gradle.properties for supported variable names). To ensure Gradle uses only JDKs
from environmental variables - disable Gradle toolchain auto-detection by passing -Porg.gradle.java.installations.auto-detect=false option
(or put it into $GRADLE_USER_HOME/gradle.properties).
For local development, if you're not working on the standard library, it's OK to avoid installing JDK 1.6 and JDK 1.7.
Add kotlin.build.isObsoleteJdkOverrideEnabled=true to the local.properties file, so build will only use JDK 1.8+. Note, that in this
case, build will have Gradle remote build cache misses for some tasks.
Note: The JDK 6 for MacOS is not available on Oracle's site. You can install it by
$ brew tap homebrew/cask-versions
$ brew install --cask java6
On Windows you might need to add long paths setting to the repo:
git config core.longpaths true
Building
The project is built with Gradle. Run Gradle to build the project and to run the tests using the following command on Unix/macOS:
./gradlew <tasks-and-options>
or the following command on Windows:
gradlew <tasks-and-options>
On the first project configuration gradle will download and setup the dependencies on
intellij-coreis a part of command line compiler and contains only necessary APIs.idea-fullis a full blown IntelliJ IDEA Community Edition to be used in the plugin module.
These dependencies are quite large, so depending on the quality of your internet connection you might face timeouts getting them. In this case, you can increase timeout by specifying the following command line parameters on the first run:
./gradlew -Dhttp.socketTimeout=60000 -Dhttp.connectionTimeout=60000
Important gradle tasks
clean- clean build resultsdist- assembles the compiler distribution intodist/kotlinc/folderinstall- build and install all public artifacts into local maven repositorycoreLibsTest- build and run stdlib, reflect and kotlin-test testsgradlePluginTest- build and run gradle plugin testscompilerTest- build and run all compiler tests
To reproduce TeamCity build use -Pteamcity=true flag. Local builds don't run proguard and have jar compression disabled by default.
OPTIONAL: Some artifacts, mainly Maven plugin ones, are built separately with Maven. Refer to libraries/ReadMe.md for details.
To build Kotlin/Native, see kotlin-native/README.md.
Working with the project in IntelliJ IDEA
It is recommended to use the latest released version of Intellij IDEA (Community or Ultimate Edition). You can download IntelliJ IDEA here.
After cloning the project, import the project in IntelliJ by choosing the project directory in the Open project dialog.
For handy work with compiler tests it's recommended to use Kotlin Compiler Test Helper
Dependency verification
We have a dependencies verification feature enabled in the
repository for all Gradle builds. Gradle will check hashes (md5 and sha256) of used dependencies and will fail builds with
Dependency verification failed errors when local artifacts are absent or have different hashes listed in the
verification-metadata.xml file.
It's expected that verification-metadata.xml should only be updated with the commits that modify the build. There are some tips how
to perform such updates:
- Use auto-generation for getting an initial list of new hashes (verify updates relate to you changes).
./gradlew -i --write-verification-metadata sha256,md5 -Pkotlin.native.enabled=true resolveDependencies
(resolveDependencies task resolves dependencies for all platforms including dependencies downloaded by plugins)
- Consider removing old versions from the file if you are updating dependencies.
- Leave meaningful
originattribute (instead ofGenerated by Gradle) if you did some manual verification of the artifact. - Always do manual verification if several hashes are needed, and a new
also-trusttag has to be added. - If you’re adding a dependency with OS mentioning in an artifact name (
darwin,mac,osx,linux,windows), remember to add them toimplicitDependenciesconfiguration or updateresolveDependenciestask if needed.resolveDependenciesshould resolve all dependencies including dependencies for different platforms.
Using -dev and -SNAPSHOT versions
We publish -dev and -SNAPSHOT versions frequently.
For -dev versions you can use the list of available versions and include this maven repository:
maven("https://maven.pkg.jetbrains.space/kotlin/p/kotlin/bootstrap")
For -SNAPSHOT versions that are updated daily, you can use the list of available versions and include this maven repository:
maven("https://oss.sonatype.org/content/repositories/snapshots/")
License
Kotlin is distributed under the terms of the Apache License (Version 2.0). See license folder for details.
Contributing
Please be sure to review Kotlin's contributing guidelines to learn how to help the project.