azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,752 Commits 1 Branch 0 Tags
bef33e971ff69ff17442529f597ae104f643cb6b
Commit Graph

57752 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dmitry Savvinov bef33e971f Make ResolverForProject own BuiltInsCache 
Previously, BuiltInsCache was a separate abstraction with its own
lifecycle. In particular, it had a CachedValue inside, which uses
SoftReference to hold the computed data. This is bad, because this might
lead to disalignment of lifetimes with respective ResolverForProject,
leading to potential exceptions in analysis, see KT-33504 for details.

This commit fixes it by making root ResolverForProject own BuiltInsCache
and removing any logic about invalidation from BuiltInsCache. So, now,
BuiltInsCache is disposed iff corresponding ResolverForProject is
disposed

^KT-33504 Fixed
 2019-09-24 17:05:05 +03:00
Dmitry Savvinov bfacc1a3c5 Introduce AbstractResolverForProject 
Previously, ResolverForProjectImpl had multiple callbacks in
constructor. Some of those callbacks were used only to overcome module
visibility and provide an ability to inject IDE-specific logic into
compiler (ResolverForProject is in the 'compiler'-module)

This commit introduces abstract class which implements
environment-independent logic (previously, this logic had been stored in
ResolverForProjectImpl) with several abstract met hods (previously,
callbacks). Then, we provide few concrete implementations of
AbstractResolverForProject with clear semantics:

- IdeaResolverForProject: resolver used in IDE, where we have indices,
  oracles, multiple modules, etc.
- ResolverForSingleModuleProject: resolver for project with only one
  module, commonly used for CLI compiler/tests
- one anonymous implementation for MultimoduleTests

This refactoring achieves several things:
- now it is easier to see what kinds of ResolverForProject you might see
  in some particular environment (previously, one had to inspect all
  call-sites of constructor)
- we can easily add IDE-specific logic in IdeaResolverForProject without
  adding noisy callbacks (which most probably wouldn't have any other
  non-trivial implementations)
 2019-09-24 17:05:05 +03:00
Dmitry Savvinov 48719c4050 Minor: extract ResolverForProjectImpl into separate file 2019-09-24 17:05:05 +03:00
Dmitry Savvinov 1e288c03c3 Minor: fix typos in KDoc 2019-09-24 17:05:04 +03:00
Dmitry Savvinov 4f700f5df3 Minor: drop unused parameter from createFacadeForScriptDependencies 2019-09-24 17:05:04 +03:00
Andrey Uskov 8ff4a92562 Fix serialization of data nodes tree 
#KT-33987 Fixed
 2019-09-24 16:27:13 +03:00
Ilya Kirillov 41f7519244 Fix old j2k test data to actual one 2019-09-24 16:22:24 +03:00
Vladimir Dolzhenko 8b0aeb9a55 Do not resolve services in non-default ctors 2019-09-24 15:15:37 +02:00
Toshiaki Kameyama 0e1e1e350f "Convert lambda to reference": do not remove required backticks 
#KT-15700 Fixed
 2019-09-24 19:45:53 +07:00
Toshiaki Kameyama 44edd94fea "Create member function" quick fix: do not add redundant semicolons after enum entry 
#KT-14899 Fixed
 2019-09-24 19:40:31 +07:00
Toshiaki Kameyama 0497f0cba4 "Create enum constant" quick fix: add before semicolon 
#KT-33718 Fixed
 2019-09-24 19:31:52 +07:00
Toshiaki Kameyama 30c41e6720 "Create type parameter from usage": don't suggest for not extension property 
#KT-33300 Fixed
 2019-09-24 19:28:40 +07:00
Toshiaki Kameyama 68609401c4 Reformat CreateTypeParameterByUnresolvedRefActionFactory 2019-09-24 19:28:40 +07:00
Toshiaki Kameyama 5b666ff33f "Create type parameter from usage": don't remove backticks if necessary 
#KT-33299 Fixed
 2019-09-24 19:24:02 +07:00
Ilya Goncharov bfc698a521 Add comment for log-reporter and its necessity 2019-09-24 14:36:11 +03:00
Ilya Goncharov 09e2ebe60a Both js targets use one TC service message classes 2019-09-24 14:36:11 +03:00
Ilya Goncharov 7d4b43f819 Remove annoying spaces in karma-teamcity-reporter 2019-09-24 14:36:10 +03:00
Ilya Goncharov b4e3cf1d7a Move teamcity reporting only to nodejs 2019-09-24 14:36:10 +03:00
Ilya Goncharov 46e82468e4 Provide logging through kotlin-test=js-runner 2019-09-24 14:36:10 +03:00
Ilya Goncharov f0e72c4d71 Remove mangling for kotlin-test-js-runner 2019-09-24 14:36:10 +03:00
Ilya Goncharov e59d1a0ef1 Use terser instead of uglify 2019-09-24 14:36:10 +03:00
Toshiaki Kameyama 784ba69b7a "Cleanup code": remove 'final' keyword for overridden function with non-canonical modifiers order 
#KT-33060 Fixed
 2019-09-24 18:28:00 +07:00
Steven Schäfer f49d5da929 JVM IR: Fix enum constructor visibility 2019-09-24 13:28:08 +03:00
Kristoffer Andersen 52dc469657 JVM IR: Generate synthetic methods for type aliases with annotations 2019-09-24 12:21:42 +02:00
romanart acd1cc5a57 [KLIB] Normalize path string to keep file order on Windows OS 2019-09-24 12:41:48 +03:00
Dmitry Gridin 1ee827bfc8 Import quick fix: support provideDelegate 
#KT-28049 Fixed
 2019-09-24 16:27:10 +07:00
Toshiaki Kameyama 79199260b9 Import quick fix: suggest for operator extension function called from name reference 
#KT-28049 Fixed
 2019-09-24 16:27:09 +07:00
Toshiaki Kameyama 998adfb098 Move variable declaration into when: don't report when property has 'break' or 'continue' 
#KT-31999
 2019-09-24 12:11:41 +03:00
Toshiaki Kameyama 877e583a96 Move variable declaration into when: don't report when property has 'return' or 'throw' 
#KT-31999 Fixed
 2019-09-24 12:11:41 +03:00
Toshiaki Kameyama d9d04fc556 "Create enum constant" quick fix: do not add redundant empty line 
#KT-32981 Fixed
 2019-09-24 13:23:06 +07:00
Dmitry Gridin 5dddc464a5 Completion: add tests for case with overloaded function with lambda with receiver parameter 
Relates to #KT-31073
 2019-09-23 23:20:26 +07:00
Dmitry Gridin e3ce799993 Refactoring: change signature should affected expect/actual 
#KT-33972 Fixed
 2019-09-23 23:01:47 +07:00
Dmitry Gridin 484dda478e AbstractIntentionTest: should check startInWriteAction flag 2019-09-23 23:01:46 +07:00
Dmitry Gridin 667e9a33e8 AbstractIntentionTest: cleanup code 2019-09-23 23:01:46 +07:00
Dmitry Gridin cbdda6f9a8 KotlinChangeSignatureData: cleanup code 2019-09-23 23:01:46 +07:00
Nikolay Krasko 7271e65851 Don't store hard references to psi elements in transferable data (KT-33802) 
This leads to project leaked errors in tests.
 2019-09-23 18:58:11 +03:00
Igor Yakovlev f8bd3518dc UL method and parameter Move&Rename refactoring 2019-09-23 17:30:15 +03:00
Igor Yakovlev fc70fd05fc Enable kotlin.collections support for UL classes 
Removed restriction for classes derived from Kotlin collections
Added type erasure for java collection overrided methods
 2019-09-23 17:30:15 +03:00
Igor Yakovlev 286702a99c Format code for NoArgPlugin 2019-09-23 17:07:33 +03:00
Igor Yakovlev 1deba19e1c Refactoring NoArg compiler plugin 
Remove NoArgClassKey relation betwen AbstractNoArgDeclarationChecker and NoArgExpressionCodegenExtension
Separate NoArgExpressionCodegenExtension to Ide and Cli versions
 2019-09-23 17:07:33 +03:00
Vladimir Dolzhenko 027c60080b Added KotlinCodeInsightWorkspaceSettings in place of sharing kotlin settings with java CodeInsightSettings 2019-09-23 16:05:11 +02:00
Nikolay Krasko 6b5a73ffa9 Enable resolve in dispatch thread check for copy-paste tests 2019-09-23 16:54:35 +03:00
Nikolay Krasko ee4ab967a4 Force resolve check for dispatch thread instead of isWriteAccessAllowed 
isWriteAccessAllowed = dispatch thread + write lock
 2019-09-23 16:54:35 +03:00
Nikolay Krasko 9f81de293f Minor: add intention name to test failure 2019-09-23 16:54:35 +03:00
Ilya Matveev fabd336856 Update K/N: 1.3.60-dev-12485 2019-09-23 18:45:17 +07:00
Vladimir Dolzhenko 17e2359a41 Added copy-paste performance tests 2019-09-23 12:48:59 +02:00
Natalia Selezneva 63e5d4fe95 Tests: rewrite some AbstractScriptConfigurationTest to the new script infrastructure 2019-09-23 12:06:25 +03:00
Natalia Selezneva eca7bbdb8c Scripts: Check if file is in all script dependencies class files scope instead of searching for module info 
^KT-32799 Fixed
^KT-16760 Add test
 2019-09-23 12:06:25 +03:00
Toshiaki Kameyama 245b2aecb3 "Replace guard clause with kotlin's function call" inspection : decrease severity to INFORMATION 
#KT-33235 Fixed
 2019-09-23 11:36:14 +03:00
Ivan Gavrilovic 573e7f2eee Run JDK11 tests for KAPT only if JDK11 is available 
Otherwise, just skip running them.
 2019-09-23 17:32:37 +09:00