Fix null Java type argument problem & add relevant test

compiler/fir/java/src/org/jetbrains/kotlin/fir/java/JavaUtils.kt

@@ -68,7 +68,7 @@ internal fun FirTypeRef.toNotNullConeKotlinType(): ConeKotlinType =
         else -> ConeKotlinErrorType("Unexpected type reference in JavaClassUseSiteScope: ${this::class.java}")
     }
 
-internal fun JavaType.toNotNullConeKotlinType(session: FirSession): ConeLookupTagBasedType {
+internal fun JavaType?.toNotNullConeKotlinType(session: FirSession): ConeLookupTagBasedType {
     return toConeKotlinTypeWithNullability(session, isNullable = false)
 }
 
@@ -85,7 +85,7 @@ internal fun JavaClassifierType.toFirResolvedTypeRef(session: FirSession): FirRe
     )
 }
 
-internal fun JavaType.toConeKotlinTypeWithNullability(session: FirSession, isNullable: Boolean): ConeLookupTagBasedType {
+internal fun JavaType?.toConeKotlinTypeWithNullability(session: FirSession, isNullable: Boolean): ConeLookupTagBasedType {
     return when (this) {
         is JavaClassifierType -> {
             toConeKotlinTypeWithNullability(session, isNullable)
@@ -118,6 +118,10 @@ internal fun JavaType.toConeKotlinTypeWithNullability(session: FirSession, isNul
             val classId = ClassId(FqName("kotlin"), FqName("Any"), false)
             classId.toConeKotlinType(emptyArray(), isNullable)
         }
+        null -> {
+            val classId = ClassId(FqName("kotlin"), FqName("Any"), false)
+            classId.toConeKotlinType(emptyArray(), isNullable)
+        }
         else -> error("Strange JavaType: ${this::class.java}")
     }
 }
@@ -172,8 +176,9 @@ internal fun FirAbstractAnnotatedElement.addAnnotationsFrom(javaAnnotationOwner:
     }
 }
 
-internal fun JavaType.toConeProjection(session: FirSession, boundTypeParameter: FirTypeParameter?): ConeKotlinTypeProjection {
+internal fun JavaType?.toConeProjection(session: FirSession, boundTypeParameter: FirTypeParameter?): ConeKotlinTypeProjection {
     return when (this) {
+        null -> ConeStarProjection
         is JavaWildcardType -> {
             val bound = this.bound
             val argumentVariance = if (isExtends) OUT_VARIANCE else IN_VARIANCE

compiler/fir/java/src/org/jetbrains/kotlin/fir/java/enhancement/EnhancementSignatureParts.kt

@@ -95,8 +95,8 @@ internal class EnhancementSignatureParts(
 
             if (type is FirJavaTypeRef) {
                 for (arg in type.type.typeArguments()) {
-                    if (arg is JavaWildcardType) {
-                        // TODO: wildcards
+                    if (arg is JavaWildcardType || arg == null) {
+                        // TODO: wildcards / raw types
                     } else {
                         add(arg.toFirJavaTypeRef(context.session))
                     }

compiler/fir/java/src/org/jetbrains/kotlin/fir/java/enhancement/javaTypeUtils.kt

@@ -46,14 +46,14 @@ internal fun FirJavaTypeRef.enhance(
 // Example: for `A<B, C<D, E>>`, indices go as follows: `0 - A<...>, 1 - B, 2 - C<D, E>, 3 - D, 4 - E`,
 // which corresponds to the left-to-right breadth-first walk of the tree representation of the type.
 // For flexible types, both bounds are indexed in the same way: `(A<B>..C<D>)` gives `0 - (A<B>..C<D>), 1 - B and D`.
-private fun JavaType.enhancePossiblyFlexible(
+private fun JavaType?.enhancePossiblyFlexible(
     session: FirSession,
     annotations: List<FirAnnotationCall>,
     qualifiers: (Int) -> JavaTypeQualifiers,
     index: Int
 ): FirResolvedTypeRef {
     val type = this
-    val arguments = typeArguments()
+    val arguments = this?.typeArguments().orEmpty()
     return when (type) {
         is JavaClassifierType -> {
             val lowerResult = type.enhanceInflexibleType(
@@ -76,9 +76,9 @@ private fun JavaType.enhancePossiblyFlexible(
     }
 }
 
-private fun JavaType.subtreeSize(): Int {
+private fun JavaType?.subtreeSize(): Int {
     if (this !is JavaClassifierType) return 1
-    return 1 + typeArguments.sumBy { it.subtreeSize() }
+    return 1 + typeArguments.sumBy { it?.subtreeSize() ?: 0 }
 }
 
 private val KOTLIN_COLLECTIONS = FqName("kotlin.collections")
@@ -102,7 +102,7 @@ private fun ClassId.mutableToReadOnly(): ClassId? {
 private fun JavaClassifierType.enhanceInflexibleType(
     session: FirSession,
     annotations: List<FirAnnotationCall>,
-    arguments: List<JavaType>,
+    arguments: List<JavaType?>,
     position: TypeComponentPosition,
     qualifiers: (Int) -> JavaTypeQualifiers,
     index: Int
@@ -199,7 +199,7 @@ internal data class TypeAndDefaultQualifiers(
 internal fun FirTypeRef.typeArguments(): List<FirTypeProjection> =
     (this as? FirUserTypeRef)?.qualifier?.lastOrNull()?.typeArguments.orEmpty()
 
-internal fun JavaType.typeArguments(): List<JavaType> = (this as? JavaClassifierType)?.typeArguments.orEmpty()
+internal fun JavaType.typeArguments(): List<JavaType?> = (this as? JavaClassifierType)?.typeArguments.orEmpty()
 
 fun FirValueParameter.getDefaultValueFromAnnotation(): AnnotationDefaultValue? {
     annotations.find { it.resolvedFqName == JvmAnnotationNames.DEFAULT_VALUE_FQ_NAME }

compiler/fir/java/src/org/jetbrains/kotlin/fir/java/scopes/JavaClassEnhancementScope.kt

@@ -102,7 +102,7 @@ class JavaClassEnhancementScope(
         original: ConeFunctionSymbol,
         name: Name
     ): FirFunctionSymbol {
-        val firMethod = (original as FirBasedSymbol<*>).fir as? FirJavaMethod ?: error("Can't make enhancement for $original")
+        val firMethod = (original as FirFunctionSymbol).fir as? FirJavaMethod ?: return original
 
         val memberContext = context.copyWithNewDefaultTypeQualifiers(typeQualifierResolver, jsr305State, firMethod.annotations)
 

compiler/javac-wrapper/src/org/jetbrains/kotlin/javac/wrappers/trees/treeBasedTypes.kt

@@ -136,7 +136,7 @@ sealed class TreeBasedClassifierType<out T : JCTree>(
     override val presentableText: String
         get() = classifierQualifiedName
 
-    override val typeArguments: List<JavaType>
+    override val typeArguments: List<JavaType?>
         get() {
             var tree: JCTree = tree
             if (tree is JCTree.JCTypeApply) {
@@ -230,9 +230,9 @@ class TreeBasedGenericClassifierType(
                    ?: super.annotations
         }
 
-    override val typeArguments: List<JavaType>
+    override val typeArguments: List<JavaType?>
         get() = tree.arguments.map { create(it, compilationUnit, javac, emptyList(), containingElement) }
-                .toMutableList()
+                .toMutableList<JavaType?>()
                 .apply { addAll(super.typeArguments) }
 
     override val isRaw: Boolean

core/descriptors.jvm/src/org/jetbrains/kotlin/load/java/lazy/types/JavaTypeResolver.kt

@@ -42,7 +42,7 @@ class JavaTypeResolver(
         private val typeParameterResolver: TypeParameterResolver
 ) {
 
-    fun transformJavaType(javaType: JavaType, attr: JavaTypeAttributes): KotlinType {
+    fun transformJavaType(javaType: JavaType?, attr: JavaTypeAttributes): KotlinType {
         return when (javaType) {
             is JavaPrimitiveType -> {
                 val primitiveType = javaType.type
@@ -53,6 +53,7 @@ class JavaTypeResolver(
             is JavaArrayType -> transformArrayType(javaType, attr)
             // Top level type can be a wildcard only in case of broken Java code, but we should not fail with exceptions in such cases
             is JavaWildcardType -> javaType.bound?.let { transformJavaType(it, attr) } ?: c.module.builtIns.defaultBound
+            null -> c.module.builtIns.defaultBound
             else -> throw UnsupportedOperationException("Unsupported type: " + javaType)
         }
     }
@@ -247,7 +248,7 @@ class JavaTypeResolver(
     }
 
     private fun transformToTypeProjection(
-            javaType: JavaType,
+            javaType: JavaType?,
             attr: JavaTypeAttributes,
             typeParameter: TypeParameterDescriptor
     ): TypeProjection {

core/descriptors.jvm/src/org/jetbrains/kotlin/load/java/structure/javaTypes.kt

@@ -26,7 +26,7 @@ interface JavaArrayType : JavaType {
 
 interface JavaClassifierType : JavaType, JavaAnnotationOwner {
     val classifier: JavaClassifier?
-    val typeArguments: List<JavaType>
+    val typeArguments: List<JavaType?>
 
     val isRaw: Boolean
 

idea/testData/fir/multiModule/javaInheritsRawKotlin/extraDump.java.txt

@@ -0,0 +1,4 @@
+public open class Some : R|java/lang/Object|, R|Strange<*>| {
+    public open operator function foo(): R|ft<kotlin/Any, kotlin/Any>|
+
+}

idea/testData/fir/multiModule/javaInheritsRawKotlin/jvm/Derived.kt

@@ -0,0 +1 @@
+class Derived : Some()

idea/testData/fir/multiModule/javaInheritsRawKotlin/jvm/Derived.txt

@@ -0,0 +1,5 @@
+FILE: Derived.kt
+    public final class Derived : R|Some| {
+        public constructor(): super<R|Some|>()
+
+    }

idea/testData/fir/multiModule/javaInheritsRawKotlin/jvm/Some.java

@@ -0,0 +1,5 @@
+public class Some implements Strange {
+    public Object foo() {
+        return "";
+    }
+}

idea/testData/fir/multiModule/javaInheritsRawKotlin/jvm/Strange.kt

@@ -0,0 +1,3 @@
+interface Strange<out T> {
+    fun foo(): T
+}

idea/testData/fir/multiModule/javaInheritsRawKotlin/jvm/Strange.txt

@@ -0,0 +1,5 @@
+FILE: Strange.kt
+    <out T> public abstract interface Strange {
+        public abstract function foo(): R|T|
+
+    }

idea/tests/org/jetbrains/kotlin/idea/fir/FirMultiModuleResolveTestGenerated.java

@@ -59,6 +59,11 @@ public class FirMultiModuleResolveTestGenerated extends AbstractFirMultiModuleRe
         runTest("idea/testData/fir/multiModule/basicWithPrimitiveJava/");
     }
 
+    @TestMetadata("javaInheritsRawKotlin")
+    public void testJavaInheritsRawKotlin() throws Exception {
+        runTest("idea/testData/fir/multiModule/javaInheritsRawKotlin/");
+    }
+
     @TestMetadata("mppFakeOverrides")
     public void testMppFakeOverrides() throws Exception {
         runTest("idea/testData/fir/multiModule/mppFakeOverrides/");