[Gradle] Remove KotlinCompilation.moduleName

^KT-58220 Verification Pending
This commit is contained in:
Sebastian Sellmair
2023-04-25 09:55:35 +02:00
committed by Space Team
parent 75b4469757
commit f98765f254
7 changed files with 6 additions and 24 deletions
@@ -739,7 +739,6 @@ public abstract interface class org/jetbrains/kotlin/gradle/plugin/KotlinCompila
public abstract fun getDisambiguatedName ()Ljava/lang/String;
public abstract fun getKotlinOptions ()Lorg/jetbrains/kotlin/gradle/dsl/KotlinCommonOptions;
public abstract fun getKotlinSourceSets ()Ljava/util/Set;
public abstract fun getModuleName ()Ljava/lang/String;
public abstract fun getName ()Ljava/lang/String;
public abstract fun getOutput ()Lorg/jetbrains/kotlin/gradle/plugin/KotlinCompilationOutput;
public abstract fun getPlatformType ()Lorg/jetbrains/kotlin/gradle/plugin/KotlinPlatformType;
@@ -104,9 +104,6 @@ interface KotlinCompilation<out T : KotlinCommonOptionsDeprecated> : Named,
override val relatedConfigurationNames: List<String>
get() = super.relatedConfigurationNames + compileDependencyConfigurationName
@Deprecated("Scheduled for removal with Kotlin 1.9. Use compilerOptions instead")
val moduleName: String
val disambiguatedName
get() = target.disambiguationClassifier + name
}
@@ -11,7 +11,7 @@ import org.gradle.api.Project
import org.gradle.api.file.ConfigurableFileCollection
import org.gradle.api.file.FileCollection
import org.gradle.api.file.SourceDirectorySet
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinMetadataTarget
import org.jetbrains.kotlin.gradle.plugin.mpp.*
import org.jetbrains.kotlin.gradle.plugin.mpp.internal
import org.jetbrains.kotlin.gradle.plugin.mpp.isMain
import org.jetbrains.kotlin.gradle.plugin.mpp.pm20.GradleKpmAbstractFragmentMetadataCompilationData
@@ -57,9 +57,8 @@ internal sealed class KotlinCompilationInfo {
override val compilationName: String
get() = origin.compilationName
@Suppress("DEPRECATION")
override val moduleName: String
get() = origin.moduleName
get() = origin.moduleNameForCompilation().get()
override val compilerOptions: HasCompilerOptions<*>
get() = origin.compilerOptions
@@ -145,16 +145,6 @@ internal class KotlinCompilationImpl constructor(
//endregion
//region Compiler Module Management
@Suppress("OVERRIDE_DEPRECATION")
override val moduleName: String
get() = moduleNameForCompilation(target.project.baseModuleName()).get()
//endregion
//region Compile Tasks
override val compileKotlinTaskName: String
@@ -87,7 +87,7 @@ private val invalidModuleNameCharactersRegex = """[\\/\r\n\t]""".toRegex()
internal fun Project.baseModuleName(): Provider<String> = archivesName.orElse(project.name)
internal fun KotlinCompilation<*>.moduleNameForCompilation(
baseName: Provider<String>
baseName: Provider<String> = project.baseModuleName()
): Provider<String> = baseName.map {
val suffix = if (compilationName == KotlinCompilation.MAIN_COMPILATION_NAME) {
""
@@ -9,6 +9,7 @@ import org.gradle.api.Task
import org.gradle.api.plugins.JavaBasePlugin
import org.jetbrains.kotlin.gradle.plugin.*
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinJvmCompilation
import org.jetbrains.kotlin.gradle.plugin.mpp.moduleNameForCompilation
import org.jetbrains.kotlin.gradle.targets.jvm.tasks.KotlinJvmTest
import org.jetbrains.kotlin.gradle.tasks.KotlinTasksProvider
import org.jetbrains.kotlin.gradle.tasks.dependsOn
@@ -46,10 +47,7 @@ open class KotlinJvmTargetConfigurator :
target.compilations.configureEach {
it.compilerOptions.options.moduleName.convention(
target.project.providers.provider {
@Suppress("DEPRECATION")
it.moduleName
}
it.moduleNameForCompilation()
)
}
}
@@ -58,8 +58,7 @@ class KotlinJvmWithJavaTargetPreset(
target.compilations.configureEach {
it.compilerOptions.options.moduleName.convention(
@Suppress("DEPRECATION")
project.providers.provider { it.moduleName }
it.moduleNameForCompilation()
)
}