Remove unused fields in PsiJetParameterStub

This commit is contained in:
Pavel V. Talanov
2014-03-27 20:58:27 +04:00
parent b33e43c416
commit f8d9a69aa9
3 changed files with 4 additions and 50 deletions
@@ -16,15 +16,10 @@
package org.jetbrains.jet.lang.psi.stubs;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.jet.lang.psi.JetParameter;
public interface PsiJetParameterStub extends PsiJetStubWithFqName<JetParameter> {
boolean isMutable();
boolean isVarArg();
@Nullable
String getTypeText();
@Nullable
String getDefaultValueText();
boolean hasValOrValNode();
}
@@ -40,14 +40,8 @@ public class JetParameterElementType extends JetStubElementType<PsiJetParameterS
@Override
public PsiJetParameterStub createStub(@NotNull JetParameter psi, StubElement parentStub) {
JetTypeReference typeReference = psi.getTypeReference();
JetExpression defaultValue = psi.getDefaultValue();
return new PsiJetParameterStubImpl(parentStub, psi.getFqName(),
psi.getName(), psi.isMutable(), psi.isVarArg(),
typeReference != null ? typeReference.getText() : null,
defaultValue != null ? defaultValue.getText() : null,
psi.getValOrVarNode() != null);
return new PsiJetParameterStubImpl(parentStub, psi.getFqName(), StringRef.fromString(psi.getName()),
psi.isMutable(), psi.isVarArg(), psi.getValOrVarNode() != null);
}
@Override
@@ -65,8 +59,6 @@ public class JetParameterElementType extends JetStubElementType<PsiJetParameterS
dataStream.writeBoolean(stub.isMutable());
dataStream.writeBoolean(stub.isVarArg());
dataStream.writeBoolean(stub.hasValOrValNode());
dataStream.writeName(stub.getTypeText());
dataStream.writeName(stub.getDefaultValueText());
FqName name = stub.getFqName();
dataStream.writeName(name != null ? name.asString() : null);
}
@@ -78,12 +70,9 @@ public class JetParameterElementType extends JetStubElementType<PsiJetParameterS
boolean isMutable = dataStream.readBoolean();
boolean isVarArg = dataStream.readBoolean();
boolean hasValOrValNode = dataStream.readBoolean();
StringRef typeText = dataStream.readName();
StringRef defaultValueText = dataStream.readName();
StringRef fqNameAsString = dataStream.readName();
FqName fqName = fqNameAsString != null ? new FqName(fqNameAsString.toString()) : null;
return new PsiJetParameterStubImpl(parentStub, fqName, name, isMutable, isVarArg,
typeText, defaultValueText, hasValOrValNode);
return new PsiJetParameterStubImpl(parentStub, fqName, name, isMutable, isVarArg, hasValOrValNode);
}
}
@@ -29,8 +29,7 @@ public class PsiJetParameterStubImpl extends StubBase<JetParameter> implements P
private final StringRef name;
private final boolean isMutable;
private final boolean isVarArg;
private final StringRef typeText;
private final StringRef defaultValueText;
//TODO: store as StringRef
private final FqName fqName;
private final boolean hasValOrValNode;
@@ -39,32 +38,16 @@ public class PsiJetParameterStubImpl extends StubBase<JetParameter> implements P
FqName fqName, StringRef name,
boolean isMutable,
boolean isVarArg,
StringRef typeText, StringRef defaultValueText,
boolean hasValOrValNode
) {
super(parent, JetStubElementTypes.VALUE_PARAMETER);
this.name = name;
this.isMutable = isMutable;
this.isVarArg = isVarArg;
this.typeText = typeText;
this.defaultValueText = defaultValueText;
this.fqName = fqName;
this.hasValOrValNode = hasValOrValNode;
}
public PsiJetParameterStubImpl(
StubElement parent,
FqName fqName, String name,
boolean isMutable,
boolean isVarArg,
String typeText,
String defaultValueText,
boolean hasValOrValNode
) {
this(parent, fqName, StringRef.fromString(name), isMutable, isVarArg,
StringRef.fromString(typeText), StringRef.fromString(defaultValueText), hasValOrValNode);
}
@Override
public String getName() {
return StringRef.toString(name);
@@ -80,17 +63,6 @@ public class PsiJetParameterStubImpl extends StubBase<JetParameter> implements P
return isVarArg;
}
@Nullable
@Override
public String getTypeText() {
return StringRef.toString(typeText);
}
@Override
public String getDefaultValueText() {
return StringRef.toString(defaultValueText);
}
@Override
public boolean hasValOrValNode() {
return hasValOrValNode;
@@ -111,8 +83,6 @@ public class PsiJetParameterStubImpl extends StubBase<JetParameter> implements P
if (fqName != null) {
builder.append(" fqName=").append(fqName.toString()).append(" ");
}
builder.append(" typeText=").append(getTypeText());
builder.append(" defaultValue=").append(getDefaultValueText());
builder.append("]");