Analysis API: add test for KtDeclaration.getReturnKtType

FE1.0 always return kotlin.Unit as return type for constructors while FIR returns the constructed class type. I am not sure which is more desirable. Also, I am not sure how to make FE1.0 behave the same way.
2021-11-18 14:05:29 -08:00
parent 0e93931e24
commit f1d0791f15
28 changed files with 402 additions and 2 deletions
@@ -44,5 +44,6 @@
  </component>
  <component name="VcsDirectoryMappings">
    <mapping directory="" vcs="Git" />
+    <mapping directory="$PROJECT_DIR$/intellij" vcs="Git" />
  </component>
 </project>
@@ -7,8 +7,8 @@ package org.jetbrains.kotlin.analysis.api.descriptors.components

 import com.intellij.psi.PsiElement
 import org.jetbrains.kotlin.analysis.api.components.KtExpressionTypeProvider
-import org.jetbrains.kotlin.analysis.api.descriptors.KtFe10AnalysisSession
 import org.jetbrains.kotlin.analysis.api.descriptors.Fe10AnalysisFacade.AnalysisMode
+import org.jetbrains.kotlin.analysis.api.descriptors.KtFe10AnalysisSession
 import org.jetbrains.kotlin.analysis.api.descriptors.components.base.Fe10KtAnalysisSessionComponent
 import org.jetbrains.kotlin.analysis.api.descriptors.symbols.descriptorBased.base.toKtType
 import org.jetbrains.kotlin.analysis.api.tokens.ValidityToken
@@ -0,0 +1,11 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.analysis.api.descriptors.test.components.expressionTypeProvider
+
+import org.jetbrains.kotlin.analysis.api.descriptors.test.KtFe10FrontendApiTestConfiguratorService
+import org.jetbrains.kotlin.analysis.api.impl.base.test.components.expressionTypeProvider.AbstractDeclarationReturnTypeTest
+
+abstract class AbstractKtFe10DeclarationReturnTypeTest : AbstractDeclarationReturnTypeTest(KtFe10FrontendApiTestConfiguratorService)
@@ -0,0 +1,74 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.analysis.api.descriptors.test.components.expressionTypeProvider;
+
+import com.intellij.testFramework.TestDataPath;
+import org.jetbrains.kotlin.test.util.KtTestUtil;
+import org.jetbrains.kotlin.test.TestMetadata;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.util.regex.Pattern;
+
+/** This class is generated by {@link GenerateNewCompilerTests.kt}. DO NOT MODIFY MANUALLY */
+@SuppressWarnings("all")
+@TestMetadata("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType")
+@TestDataPath("$PROJECT_ROOT")
+public class KtFe10DeclarationReturnTypeTestGenerated extends AbstractKtFe10DeclarationReturnTypeTest {
+    @Test
+    public void testAllFilesPresentInDeclarationReturnType() throws Exception {
+        KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType"), Pattern.compile("^(.+)\\.kt$"), null, true);
+    }
+
+    @Test
+    @TestMetadata("declarationInPrimaryConstructor.kt")
+    public void testDeclarationInPrimaryConstructor() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/declarationInPrimaryConstructor.kt");
+    }
+
+    @Test
+    @TestMetadata("delegateProperties.kt")
+    public void testDelegateProperties() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/delegateProperties.kt");
+    }
+
+    @Test
+    @TestMetadata("funtionType.kt")
+    public void testFuntionType() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/funtionType.kt");
+    }
+
+    @Test
+    @TestMetadata("localDeclarations.kt")
+    public void testLocalDeclarations() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/localDeclarations.kt");
+    }
+
+    @Test
+    @TestMetadata("overriddenMember.kt")
+    public void testOverriddenMember() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/overriddenMember.kt");
+    }
+
+    @Test
+    @TestMetadata("propertyAccessor.kt")
+    public void testPropertyAccessor() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/propertyAccessor.kt");
+    }
+
+    @Test
+    @TestMetadata("simpleDeclaration.kt")
+    public void testSimpleDeclaration() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/simpleDeclaration.kt");
+    }
+
+    @Test
+    @TestMetadata("typeParameters.kt")
+    public void testTypeParameters() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/typeParameters.kt");
+    }
+}
@@ -0,0 +1,11 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.analysis.api.fir.components.expressionTypeProvider
+
+import org.jetbrains.kotlin.analysis.api.fir.FirFrontendApiTestConfiguratorService
+import org.jetbrains.kotlin.analysis.api.impl.base.test.components.expressionTypeProvider.AbstractDeclarationReturnTypeTest
+
+abstract class AbstractFirDeclarationReturnTypeTest : AbstractDeclarationReturnTypeTest(FirFrontendApiTestConfiguratorService)
@@ -0,0 +1,74 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.analysis.api.fir.components.expressionTypeProvider;
+
+import com.intellij.testFramework.TestDataPath;
+import org.jetbrains.kotlin.test.util.KtTestUtil;
+import org.jetbrains.kotlin.test.TestMetadata;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.util.regex.Pattern;
+
+/** This class is generated by {@link GenerateNewCompilerTests.kt}. DO NOT MODIFY MANUALLY */
+@SuppressWarnings("all")
+@TestMetadata("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType")
+@TestDataPath("$PROJECT_ROOT")
+public class FirDeclarationReturnTypeTestGenerated extends AbstractFirDeclarationReturnTypeTest {
+    @Test
+    public void testAllFilesPresentInDeclarationReturnType() throws Exception {
+        KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType"), Pattern.compile("^(.+)\\.kt$"), null, true);
+    }
+
+    @Test
+    @TestMetadata("declarationInPrimaryConstructor.kt")
+    public void testDeclarationInPrimaryConstructor() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/declarationInPrimaryConstructor.kt");
+    }
+
+    @Test
+    @TestMetadata("delegateProperties.kt")
+    public void testDelegateProperties() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/delegateProperties.kt");
+    }
+
+    @Test
+    @TestMetadata("funtionType.kt")
+    public void testFuntionType() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/funtionType.kt");
+    }
+
+    @Test
+    @TestMetadata("localDeclarations.kt")
+    public void testLocalDeclarations() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/localDeclarations.kt");
+    }
+
+    @Test
+    @TestMetadata("overriddenMember.kt")
+    public void testOverriddenMember() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/overriddenMember.kt");
+    }
+
+    @Test
+    @TestMetadata("propertyAccessor.kt")
+    public void testPropertyAccessor() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/propertyAccessor.kt");
+    }
+
+    @Test
+    @TestMetadata("simpleDeclaration.kt")
+    public void testSimpleDeclaration() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/simpleDeclaration.kt");
+    }
+
+    @Test
+    @TestMetadata("typeParameters.kt")
+    public void testTypeParameters() throws Exception {
+        runTest("analysis/analysis-api/testData/components/expressionTypeProvider/declarationReturnType/typeParameters.kt");
+    }
+}
@@ -12,6 +12,7 @@ import org.jetbrains.kotlin.analysis.api.KtAnalysisSession
 import org.jetbrains.kotlin.analysis.api.analyse
 import org.jetbrains.kotlin.analysis.api.symbols.KtSymbol
 import org.jetbrains.kotlin.diagnostics.PsiDiagnosticUtils.offsetToLineAndColumn
+import org.jetbrains.kotlin.psi.KtDeclaration
 import org.jetbrains.kotlin.psi.KtDeclarationWithBody
 import org.jetbrains.kotlin.psi.KtElement
 import org.jetbrains.kotlin.psi.KtNamedDeclaration
@@ -45,4 +46,8 @@ fun KtSymbol.getNameWithPositionString(): String {
 fun String.indented(indent: Int): String {
    val indentString = " ".repeat(indent)
    return indentString + replace("\n", "\n$indentString")
-}
+}
+
+fun KtDeclaration.getNameWithPositionString(): String {
+    return (presentation?.presentableText ?: name ?: this::class.simpleName) + "@" + position()
+}
@@ -0,0 +1,41 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.analysis.api.impl.base.test.components.expressionTypeProvider
+
+import org.jetbrains.kotlin.analysis.api.impl.barebone.test.FrontendApiTestConfiguratorService
+import org.jetbrains.kotlin.analysis.api.impl.base.test.getNameWithPositionString
+import org.jetbrains.kotlin.analysis.api.impl.base.test.test.framework.AbstractHLApiSingleFileTest
+import org.jetbrains.kotlin.psi.*
+import org.jetbrains.kotlin.test.model.TestModule
+import org.jetbrains.kotlin.test.services.TestServices
+import org.jetbrains.kotlin.test.services.assertions
+
+abstract class AbstractDeclarationReturnTypeTest(
+    configurator: FrontendApiTestConfiguratorService
+) : AbstractHLApiSingleFileTest(configurator) {
+    override fun doTestByFileStructure(ktFile: KtFile, module: TestModule, testServices: TestServices) {
+        val actual = buildString {
+            ktFile.accept(object : KtTreeVisitor<Int>() {
+                override fun visitDeclaration(dcl: KtDeclaration, data: Int): Void? {
+                    if (dcl is KtTypeParameter) return null
+                    append(" ".repeat(data))
+                    if (dcl is KtClassLikeDeclaration) {
+                        appendLine(dcl.getNameWithPositionString())
+                    } else {
+                        analyseForTest(dcl) {
+                            val returnType = dcl.getReturnKtType()
+                            append(dcl.getNameWithPositionString())
+                            append(" : ")
+                            appendLine(returnType.render())
+                        }
+                    }
+                    return super.visitDeclaration(dcl, data + 2)
+                }
+            }, 0)
+        }
+        testServices.assertions.assertEqualsToTestDataFileSibling(actual)
+    }
+}
@@ -0,0 +1,4 @@
+Foo@(1,1)
+  Foo@(1,13) : kotlin.Unit
+    t@(1,14) : T
+    i@(1,24) : kotlin.Int
@@ -0,0 +1 @@
+class Foo<T>(val t: T, val i: Int)
@@ -0,0 +1,4 @@
+Foo@(1,1)
+  Foo@(1,13) : Foo<T>
+    t@(1,14) : T
+    i@(1,24) : kotlin.Int
@@ -0,0 +1,10 @@
+lazy@(3,1) : Lazy<T>
+  initializer@(3,14) : () -> T
+Lazy@(5,1)
+  Lazy@(5,14) : kotlin.Unit
+    value@(5,15) : T
+getValue@(7,1) : T
+  thisRef@(7,42) : kotlin.Any?
+  property@(7,57) : kotlin.reflect.KProperty<*>
+A@(9,1)
+  i@(10,5) : kotlin.Int
@@ -0,0 +1,13 @@
+import kotlin.reflect.KProperty
+
+fun <T> lazy(initializer: () -> T): Lazy<T> = Lazy(initializer())
+
+class Lazy<T>(val value: T)
+
+inline operator fun <T> Lazy<T>.getValue(thisRef: Any?, property: KProperty<*>): T = value
+
+class A {
+    val i by lazy {
+        1
+    }
+}
@@ -0,0 +1,10 @@
+lazy@(3,1) : Lazy<T>
+  initializer@(3,14) : () -> T
+Lazy@(5,1)
+  Lazy@(5,14) : Lazy<T>
+    value@(5,15) : T
+getValue@(7,1) : T
+  thisRef@(7,42) : kotlin.Any?
+  property@(7,57) : kotlin.reflect.KProperty<*>
+A@(9,1)
+  i@(10,5) : kotlin.Int
@@ -0,0 +1,4 @@
+val f1: () -> Unit = {}
+val f2 = {}
+val f3: String.() -> String = { this }
+fun <T> f4(): Int.(T) -> String = { "" }
@@ -0,0 +1,5 @@
+f1@(1,1) : () -> kotlin.Unit
+f2@(2,1) : () -> kotlin.Unit
+f3@(3,1) : kotlin.String.() -> kotlin.String
+f4@(4,1) : kotlin.Int.(T) -> kotlin.String
+  KtParameter@(4,20) : T
@@ -0,0 +1,20 @@
+fun test1() {
+    val i = 1
+    fun foo() = ""
+    val f1 = {}
+    val f2: String.(Int) -> String = { this + it }
+}
+
+fun <T> test2(t1: T) {
+    val t2 = t1
+    fun foo() = t1
+    val f = { t1 }
+}
+
+fun test3(
+    val i: Int = run {
+        val j = 1
+        j
+    }
+) {
+}
@@ -0,0 +1,14 @@
+test1@(1,1) : kotlin.Unit
+  i@(2,5) : kotlin.Int
+  foo@(3,5) : kotlin.String
+  f1@(4,5) : () -> kotlin.Unit
+  f2@(5,5) : kotlin.String.(kotlin.Int) -> kotlin.String
+    KtParameter@(5,21) : kotlin.Int
+test2@(8,1) : kotlin.Unit
+  t1@(8,15) : T
+  t2@(9,5) : T
+  foo@(10,5) : T
+  f@(11,5) : () -> T
+test3@(14,1) : kotlin.Unit
+  i@(15,5) : kotlin.Int
+    j@(16,9) : kotlin.Int
@@ -0,0 +1,17 @@
+interface A
+
+class B: A
+
+abstract class Super {
+    abstract val a: A
+    abstract val b: B
+    abstract fun getA(): A
+    abstract fun getB(): B
+}
+
+class Sub: {
+    override val a = B()
+    override val b = B()
+    override fun getA() = B()
+    override fun getB() = B()
+}
@@ -0,0 +1,12 @@
+A@(1,1)
+B@(3,1)
+Super@(5,1)
+  a@(6,5) : A
+  b@(7,5) : B
+  getA@(8,5) : A
+  getB@(9,5) : B
+Sub@(12,1)
+  a@(13,5) : B
+  b@(14,5) : B
+  getA@(15,5) : B
+  getB@(16,5) : B
@@ -0,0 +1,9 @@
+i@(1,1) : kotlin.Int
+  KtPropertyAccessor@(2,5) : kotlin.Int
+  KtPropertyAccessor@(3,5) : kotlin.Unit
+    value@(3,9) : kotlin.Unit
+A@(5,1)
+  j@(6,5) : kotlin.Int
+    KtPropertyAccessor@(7,9) : kotlin.Int
+    KtPropertyAccessor@(8,9) : kotlin.Unit
+      value@(8,13) : kotlin.Unit
@@ -0,0 +1,9 @@
+var i: Int
+    get() = 1
+    set(value) {}
+
+class A {
+    val j: Int
+        get() = 2
+        set(value) {}
+}
@@ -0,0 +1,9 @@
+i@(1,1) : kotlin.Int
+  KtPropertyAccessor@(2,5) : kotlin.Int
+  KtPropertyAccessor@(3,5) : kotlin.Unit
+    value@(3,9) : kotlin.Int
+A@(5,1)
+  j@(6,5) : kotlin.Int
+    KtPropertyAccessor@(7,9) : kotlin.Int
+    KtPropertyAccessor@(8,9) : kotlin.Unit
+      value@(8,13) : kotlin.Int
@@ -0,0 +1,8 @@
+val i: Int
+val j = 1
+val s = ""
+fun procedure() {}
+fun procedure(i: Int) {}
+fun returnIntOne() = 1
+fun id(i: Int) = i
+fun throwException() = throw Exception()
@@ -0,0 +1,10 @@
+i@(1,1) : kotlin.Int
+j@(2,1) : kotlin.Int
+s@(3,1) : kotlin.String
+procedure@(4,1) : kotlin.Unit
+procedure@(5,1) : kotlin.Unit
+  i@(5,15) : kotlin.Int
+returnIntOne@(6,1) : kotlin.Int
+id@(7,1) : kotlin.Int
+  i@(7,8) : kotlin.Int
+throwException@(8,1) : kotlin.Nothing
@@ -0,0 +1,8 @@
+fun <T> id(t: T) = t
+fun <C : Collection<*>> C.mySize = size
+fun <T> foo(): Foo<T> = Foo()
+class Foo<T> {
+    val t: T
+    fun getT(): T
+    fun <R> getR(): R
+}
@@ -0,0 +1,8 @@
+id@(1,1) : T
+  t@(1,12) : T
+mySize@(2,1) : kotlin.Int
+foo@(3,1) : Foo<T>
+Foo@(4,1)
+  t@(5,5) : T
+  getT@(6,5) : T
+  getR@(7,5) : R
@@ -19,6 +19,7 @@ import org.jetbrains.kotlin.analysis.api.descriptors.test.components.symbolDecla
 import org.jetbrains.kotlin.analysis.api.descriptors.test.components.symbolDeclarationRenderer.AbstractKtFe10RendererTest
 import org.jetbrains.kotlin.analysis.api.descriptors.test.components.typeCreator.AbstractKtFe10TypeParameterTypeTest
 import org.jetbrains.kotlin.analysis.api.descriptors.test.components.typeProvider.AbstractKtFe10HasCommonSubtypeTest
+import org.jetbrains.kotlin.analysis.api.descriptors.test.components.expressionTypeProvider.AbstractKtFe10DeclarationReturnTypeTest
 import org.jetbrains.kotlin.analysis.api.descriptors.test.symbols.AbstractKtFe10SymbolByFqNameTest
 import org.jetbrains.kotlin.analysis.api.descriptors.test.symbols.AbstractKtFe10SymbolByPsiTest
 import org.jetbrains.kotlin.analysis.api.descriptors.test.symbols.AbstractKtFe10SymbolByReferenceTest
@@ -30,6 +31,7 @@ import org.jetbrains.kotlin.analysis.api.fir.components.callResolver.AbstractFir
 import org.jetbrains.kotlin.analysis.api.fir.components.compileTimeConstantProvider.AbstractFirCompileTimeConstantEvaluatorTest
 import org.jetbrains.kotlin.analysis.api.fir.components.expressionInfoProvider.AbstractFirReturnTargetSymbolTest
 import org.jetbrains.kotlin.analysis.api.fir.components.expressionInfoProvider.AbstractFirWhenMissingCasesTest
+import org.jetbrains.kotlin.analysis.api.fir.components.expressionTypeProvider.AbstractFirDeclarationReturnTypeTest
 import org.jetbrains.kotlin.analysis.api.fir.components.expressionTypeProvider.AbstractFirExpectedExpressionTypeTest
 import org.jetbrains.kotlin.analysis.api.fir.components.expressionTypeProvider.AbstractFirHLExpressionTypeTest
 import org.jetbrains.kotlin.analysis.api.fir.components.importOptimizer.AbstractHLImportOptimizerTest
@@ -186,6 +188,12 @@ private fun TestGroupSuite.generateAnalysisApiComponentsTests() {
        ) {
            model("expressionType")
        }
+
+        test(
+            fir = AbstractFirDeclarationReturnTypeTest::class, fe10 = AbstractKtFe10DeclarationReturnTypeTest::class
+        ) {
+            model("declarationReturnType")
+        }
    }

    component("importOptimizer") {