[FIR] Ignore smartcast for non-final members from Java, ^KT-50219 Fixed

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosisCompilerTestFE10TestdataTestGenerated.java

@@ -27987,6 +27987,12 @@ public class DiagnosisCompilerTestFE10TestdataTestGenerated extends AbstractDiag
                 runTest("compiler/testData/diagnostics/tests/smartCasts/noErrorCheckForPackageLevelVal.kt");
             }
 
+            @Test
+            @TestMetadata("noSmartcastForNonFinalMembersFromJava.kt")
+            public void testNoSmartcastForNonFinalMembersFromJava() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.kt");
+            }
+
             @Test
             @TestMetadata("noUnnecessarySmartCastForReceiver.kt")
             public void testNoUnnecessarySmartCastForReceiver() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsTestGenerated.java

@@ -27987,6 +27987,12 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirDiagnosti
                 runTest("compiler/testData/diagnostics/tests/smartCasts/noErrorCheckForPackageLevelVal.kt");
             }
 
+            @Test
+            @TestMetadata("noSmartcastForNonFinalMembersFromJava.kt")
+            public void testNoSmartcastForNonFinalMembersFromJava() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.kt");
+            }
+
             @Test
             @TestMetadata("noUnnecessarySmartCastForReceiver.kt")
             public void testNoUnnecessarySmartCastForReceiver() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsWithLightTreeTestGenerated.java

@@ -27987,6 +27987,12 @@ public class FirOldFrontendDiagnosticsWithLightTreeTestGenerated extends Abstrac
                 runTest("compiler/testData/diagnostics/tests/smartCasts/noErrorCheckForPackageLevelVal.kt");
             }
 
+            @Test
+            @TestMetadata("noSmartcastForNonFinalMembersFromJava.kt")
+            public void testNoSmartcastForNonFinalMembersFromJava() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.kt");
+            }
+
             @Test
             @TestMetadata("noUnnecessarySmartCastForReceiver.kt")
             public void testNoUnnecessarySmartCastForReceiver() throws Exception {

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/FirDataFlowAnalyzer.kt

@@ -15,6 +15,7 @@ import org.jetbrains.kotlin.fir.contracts.description.ConeConstantReference
 import org.jetbrains.kotlin.fir.contracts.description.ConeReturnsEffectDeclaration
 import org.jetbrains.kotlin.fir.declarations.*
 import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertyAccessor
+import org.jetbrains.kotlin.fir.declarations.utils.isFinal
 import org.jetbrains.kotlin.fir.declarations.utils.isLocal
 import org.jetbrains.kotlin.fir.expressions.*
 import org.jetbrains.kotlin.fir.references.FirControlFlowGraphReference

compiler/fir/semantics/src/org/jetbrains/kotlin/fir/resolve/dfa/VariableStorageImpl.kt

@@ -12,6 +12,7 @@ import org.jetbrains.kotlin.fir.declarations.FirAnonymousObject
 import org.jetbrains.kotlin.fir.declarations.FirProperty
 import org.jetbrains.kotlin.fir.declarations.FirRegularClass
 import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertyAccessor
+import org.jetbrains.kotlin.fir.declarations.utils.isFinal
 import org.jetbrains.kotlin.fir.declarations.utils.modality
 import org.jetbrains.kotlin.fir.expressions.*
 import org.jetbrains.kotlin.fir.expressions.impl.FirNoReceiverExpression
@@ -179,6 +180,7 @@ class VariableStorageImpl(private val session: FirSession) : VariableStorage() {
         }
         if (originalFir is FirThisReceiverExpression) return PropertyStability.STABLE_VALUE
         if (this !is FirVariableSymbol<*>) return null
+        if (this is FirFieldSymbol && !this.isFinal) return PropertyStability.MUTABLE_PROPERTY
 
         val property = this.fir as? FirProperty ?: return PropertyStability.STABLE_VALUE
 

compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.kt

@@ -0,0 +1,21 @@
+// FIR_IDENTICAL
+// KT-50219
+
+// FILE: Base.java
+public class Base {
+    protected String field;
+    protected final String finalField = "finalFieldValue";
+}
+
+// FILE: test.kt
+class Derived : Base() {
+    fun foo() {
+        if (field == null) {
+            field.length
+        }
+
+        if (finalField == null) {
+            finalField<!UNSAFE_CALL!>.<!>length
+        }
+    }
+}

compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.txt

@@ -0,0 +1,20 @@
+package
+
+public open class Base {
+    public constructor Base()
+    protected/*protected and package*/ final var field: kotlin.String!
+    protected/*protected and package*/ final val finalField: kotlin.String! = "finalFieldValue"
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class Derived : Base {
+    public constructor Derived()
+    protected/*protected and package*/ final override /*1*/ /*fake_override*/ var field: kotlin.String!
+    protected/*protected and package*/ final override /*1*/ /*fake_override*/ val finalField: kotlin.String!
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public final fun foo(): kotlin.Unit
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/DiagnosticTestGenerated.java

@@ -28077,6 +28077,12 @@ public class DiagnosticTestGenerated extends AbstractDiagnosticTest {
                 runTest("compiler/testData/diagnostics/tests/smartCasts/noErrorCheckForPackageLevelVal.kt");
             }
 
+            @Test
+            @TestMetadata("noSmartcastForNonFinalMembersFromJava.kt")
+            public void testNoSmartcastForNonFinalMembersFromJava() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/smartCasts/noSmartcastForNonFinalMembersFromJava.kt");
+            }
+
             @Test
             @TestMetadata("noUnnecessarySmartCastForReceiver.kt")
             public void testNoUnnecessarySmartCastForReceiver() throws Exception {