[FIR] Use AST nodes only for lambda parameter names

Eighth step for ^KT-52615

Merge-request: KT-MR-8700
Merged-by: Egor Kulikov <Egor.Kulikov@jetbrains.com>

compiler/fir/raw-fir/light-tree2fir/src/org/jetbrains/kotlin/fir/lightTree/converter/DeclarationsConverter.kt

@@ -2316,7 +2316,7 @@ class DeclarationsConverter(
             }
         }
 
-        val name = convertValueParameterName(identifier.nameAsSafeName(), identifier, valueParameterDeclaration)
+        val name = convertValueParameterName(identifier.nameAsSafeName(), valueParameterDeclaration) { identifier }
 
         val valueParameterSource = valueParameter.toFirSourceElement()
         return ValueParameter(

compiler/fir/raw-fir/psi2fir/src/org/jetbrains/kotlin/fir/builder/RawFirBuilder.kt

@@ -578,7 +578,7 @@ open class RawFirBuilder(
             valueParameterDeclaration: ValueParameterDeclaration,
             additionalAnnotations: List<FirAnnotation>,
         ): FirValueParameter {
-            val name = convertValueParameterName(nameAsSafeName, nameIdentifier?.node?.text, valueParameterDeclaration)
+            val name = convertValueParameterName(nameAsSafeName, valueParameterDeclaration) { nameIdentifier?.node?.text }
             return buildValueParameter {
                 source = toFirSourceElement()
                 moduleData = baseModuleData
@@ -2104,9 +2104,8 @@ open class RawFirBuilder(
                     val parameter = clause.catchParameter?.let { ktParameter ->
                         val name = convertValueParameterName(
                             ktParameter.nameAsSafeName,
-                            ktParameter.nameIdentifier?.node?.text,
                             ValueParameterDeclaration.CATCH
-                        )
+                        ) { ktParameter.nameIdentifier?.node?.text }
 
                         buildProperty {
                             source = ktParameter.toFirSourceElement()

compiler/fir/raw-fir/raw-fir.common/src/org/jetbrains/kotlin/fir/builder/BaseFirBuilder.kt

@@ -1225,10 +1225,10 @@ abstract class BaseFirBuilder<T>(val baseSession: FirSession, val context: Conte
 
     protected fun convertValueParameterName(
         safeName: Name,
-        rawName: String?,
-        valueParameterDeclaration: ValueParameterDeclaration
+        valueParameterDeclaration: ValueParameterDeclaration,
+        rawName: () -> String?,
     ): Name {
-        return if (valueParameterDeclaration == ValueParameterDeclaration.LAMBDA && rawName == "_"
+        return if (valueParameterDeclaration == ValueParameterDeclaration.LAMBDA && rawName() == "_"
             ||
             valueParameterDeclaration == ValueParameterDeclaration.CATCH &&
             safeName.asString() == "_"