LeakingThisInspection: add comment about analyzeFully

2018-02-13 17:10:50 +03:00
parent 2038a5567d
commit e78bd73ba3
1 changed files with 4 additions and 0 deletions
@@ -28,6 +28,10 @@ import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
 class LeakingThisInspection : AbstractKotlinInspection() {
    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
        return expressionVisitor { expression ->
+            // We still use analyzeFully() here.
+            // It's possible to use analyze(), but then we should repeat class constructor consistency check
+            // for different class internal elements, like KtProperty and KtClassInitializer.
+            // It can affect performance, so yet we want to avoid this.
            val context = expression.analyzeFully()
            val leakingThisDescriptor = context.get(LEAKING_THIS, expression) ?: return@expressionVisitor
            val description = when (leakingThisDescriptor) {