Create function quick fix: fix visibility from inline method #KT-25228 Fixed

idea/src/org/jetbrains/kotlin/idea/quickfix/createFromUsage/createCallable/CreateCallableFromCallActionFactory.kt

@@ -275,7 +275,17 @@ sealed class CreateCallableFromCallActionFactory<E : KtExpression>(
             } else {
                 TypeInfo(fullCallExpression, Variance.OUT_VARIANCE)
             }
-            return FunctionInfo(name, receiverType, returnType, possibleContainers, parameters, typeParameters)
+            val parentFunction = expression.getStrictParentOfType<KtNamedFunction>()
+            val modifierList = if (parentFunction?.hasModifier(KtTokens.INLINE_KEYWORD) == true) {
+                when {
+                    parentFunction.isPublic -> KtPsiFactory(expression).createModifierList(KtTokens.PUBLIC_KEYWORD)
+                    parentFunction.isProtected() -> KtPsiFactory(expression).createModifierList(KtTokens.PROTECTED_KEYWORD)
+                    else -> null
+                }
+            } else {
+                null
+            }
+            return FunctionInfo(name, receiverType, returnType, possibleContainers, parameters, typeParameters, modifierList = modifierList)
         }
 
         object Default : Function()

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineInternalFun.kt

@@ -0,0 +1,6 @@
+// "Create function 'g'" "true"
+class C {
+    internal inline fun f() {
+        <caret>g()
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineInternalFun.kt.after

@@ -0,0 +1,10 @@
+// "Create function 'g'" "true"
+class C {
+    internal inline fun f() {
+        g()
+    }
+
+    private fun g() {
+        TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePrivateFun.kt

@@ -0,0 +1,6 @@
+// "Create function 'g'" "true"
+class C {
+    private inline fun f() {
+        <caret>g()
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePrivateFun.kt.after

@@ -0,0 +1,10 @@
+// "Create function 'g'" "true"
+class C {
+    private inline fun f() {
+        g()
+    }
+
+    private fun g() {
+        TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineProtectedFun.kt

@@ -0,0 +1,6 @@
+// "Create function 'g'" "true"
+class C {
+    protected inline fun f() {
+        <caret>g()
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineProtectedFun.kt.after

@@ -0,0 +1,10 @@
+// "Create function 'g'" "true"
+class C {
+    protected inline fun f() {
+        g()
+    }
+
+    protected fun g() {
+        TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePublicFun.kt

@@ -0,0 +1,6 @@
+// "Create function 'g'" "true"
+class C {
+    inline fun f() {
+        <caret>g()
+    }
+}

idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePublicFun.kt.after

@@ -0,0 +1,10 @@
+// "Create function 'g'" "true"
+class C {
+    inline fun f() {
+        g()
+    }
+
+    fun g() {
+        TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
+    }
+}

idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixTestGenerated.java

@@ -3101,6 +3101,26 @@ public class QuickFixTestGenerated extends AbstractQuickFixTest {
                     runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funExtraArgs.kt");
                 }
 
+                @TestMetadata("funInInlineInternalFun.kt")
+                public void testFunInInlineInternalFun() throws Exception {
+                    runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineInternalFun.kt");
+                }
+
+                @TestMetadata("funInInlinePrivateFun.kt")
+                public void testFunInInlinePrivateFun() throws Exception {
+                    runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePrivateFun.kt");
+                }
+
+                @TestMetadata("funInInlineProtectedFun.kt")
+                public void testFunInInlineProtectedFun() throws Exception {
+                    runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funInInlineProtectedFun.kt");
+                }
+
+                @TestMetadata("funInInlinePublicFun.kt")
+                public void testFunInInlinePublicFun() throws Exception {
+                    runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funInInlinePublicFun.kt");
+                }
+
                 @TestMetadata("funMissingArgs.kt")
                 public void testFunMissingArgs() throws Exception {
                     runTest("idea/testData/quickfix/createFromUsage/createFunction/call/funMissingArgs.kt");