azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reformat SuspiciousEqualsCombination

Browse Source
This commit is contained in:
Toshiaki Kameyama
2018-04-26 12:22:47 +03:00
committed by Mikhail Glukhikh
parent dc3b230b55
commit d15e43f38a
1 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/SuspiciousEqualsCombination.kt
+16 -12
View File
@@ -13,16 +13,18 @@ import org.jetbrains.kotlin.psi.*
class SuspiciousEqualsCombination : AbstractKotlinInspection() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
binaryExpressionVisitor(fun(expression) {
if (expression.parent is KtBinaryExpression) return
val operands = expression.parseBinary()
val eqeq = operands.eqEqOperands.map { it.text }
val eqeqeq = operands.eqEqEqOperands.map { it.text }
if (eqeq.intersect(eqeqeq).isNotEmpty()) {
holder.registerProblem(expression, "Suspicious combination of == and ===",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
}
})
binaryExpressionVisitor(fun(expression) {
if (expression.parent is KtBinaryExpression) return
val operands = expression.parseBinary()
val eqeq = operands.eqEqOperands.map { it.text }
val eqeqeq = operands.eqEqEqOperands.map { it.text }
if (eqeq.intersect(eqeqeq).isNotEmpty()) {
holder.registerProblem(
expression, "Suspicious combination of == and ===",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING
)
}
})
private fun KtBinaryExpression.parseBinary(pair: ComparisonOperands = ComparisonOperands()): ComparisonOperands {
when (operationToken) {
@@ -51,5 +53,7 @@ class SuspiciousEqualsCombination : AbstractKotlinInspection() {
}
}
private data class ComparisonOperands(val eqEqOperands: MutableList<KtExpression> = mutableListOf(),
val eqEqEqOperands: MutableList<KtExpression> = mutableListOf())
private data class ComparisonOperands(
val eqEqOperands: MutableList<KtExpression> = mutableListOf(),
val eqEqEqOperands: MutableList<KtExpression> = mutableListOf()
)