[Test] Add a new handler to check that const declarations have constants
#KT-62683 Fixed
This commit is contained in:
+86
@@ -0,0 +1,86 @@
|
||||
/*
|
||||
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
|
||||
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
|
||||
*/
|
||||
|
||||
package org.jetbrains.kotlin.test.backend.ir
|
||||
|
||||
import org.jetbrains.kotlin.ir.IrElement
|
||||
import org.jetbrains.kotlin.ir.IrStatement
|
||||
import org.jetbrains.kotlin.ir.declarations.IrAnnotationContainer
|
||||
import org.jetbrains.kotlin.ir.declarations.IrDeclarationBase
|
||||
import org.jetbrains.kotlin.ir.declarations.IrField
|
||||
import org.jetbrains.kotlin.ir.declarations.IrFile
|
||||
import org.jetbrains.kotlin.ir.expressions.*
|
||||
import org.jetbrains.kotlin.ir.types.IrSimpleType
|
||||
import org.jetbrains.kotlin.ir.types.IrType
|
||||
import org.jetbrains.kotlin.ir.types.typeOrNull
|
||||
import org.jetbrains.kotlin.ir.util.dump
|
||||
import org.jetbrains.kotlin.ir.util.getAllArgumentsWithIr
|
||||
import org.jetbrains.kotlin.ir.util.isAnnotation
|
||||
import org.jetbrains.kotlin.ir.visitors.IrTypeTransformer
|
||||
import org.jetbrains.kotlin.test.backend.handlers.AbstractIrHandler
|
||||
import org.jetbrains.kotlin.test.model.TestModule
|
||||
import org.jetbrains.kotlin.test.services.TestServices
|
||||
|
||||
class IrConstCheckerHandler(testServices: TestServices) : AbstractIrHandler(testServices) {
|
||||
override fun processModule(module: TestModule, info: IrBackendInput) {
|
||||
info.irModuleFragment.accept(IrConstChecker(), null)
|
||||
}
|
||||
|
||||
override fun processAfterAllModules(someAssertionWasFailed: Boolean) {}
|
||||
}
|
||||
|
||||
private class IrConstChecker : IrTypeTransformer<Nothing?> {
|
||||
override fun visitFile(declaration: IrFile, data: Nothing?): IrFile {
|
||||
checkAnnotations(declaration)
|
||||
declaration.transformChildren(this, data)
|
||||
return declaration
|
||||
}
|
||||
|
||||
override fun visitDeclaration(declaration: IrDeclarationBase, data: Nothing?): IrStatement {
|
||||
checkAnnotations(declaration)
|
||||
declaration.transformChildren(this, data)
|
||||
return declaration
|
||||
}
|
||||
|
||||
override fun <Type : IrType?> transformType(container: IrElement, type: Type, data: Nothing?): Type {
|
||||
if (type == null) return type
|
||||
|
||||
checkAnnotations(type)
|
||||
if (type is IrSimpleType) {
|
||||
type.arguments.mapNotNull { it.typeOrNull }.forEach { transformType(container, it, data) }
|
||||
}
|
||||
return type
|
||||
}
|
||||
|
||||
override fun visitField(declaration: IrField, data: Nothing?): IrStatement {
|
||||
if (declaration.correspondingPropertySymbol?.owner?.isConst == true && declaration.initializer?.expression !is IrConst<*>) {
|
||||
error("Const field is not containing const expression. Got ${declaration.initializer?.dump()}")
|
||||
}
|
||||
return super.visitField(declaration, data)
|
||||
}
|
||||
|
||||
private fun checkAnnotations(container: IrAnnotationContainer) {
|
||||
fun IrElement.isConst(): Boolean {
|
||||
return this is IrConst<*> || this is IrGetEnumValue || this is IrClassReference || (this is IrConstructorCall && type.isAnnotation())
|
||||
}
|
||||
|
||||
container.annotations.forEach { annotation ->
|
||||
fun IrElement.checkIsConst() {
|
||||
if (isConst()) return
|
||||
if (this is IrErrorExpression && this.description.startsWith("Stub expression")) return
|
||||
error("IR annotation has non constant argument.\n Annotation: ${annotation.dump()}.\n Argument: ${this.dump()}")
|
||||
}
|
||||
|
||||
annotation.getAllArgumentsWithIr().forEach { (param, arg) ->
|
||||
val actualArg = arg ?: param.defaultValue?.expression
|
||||
when (actualArg) {
|
||||
null -> error("IR annotation has null argument.\n Annotation: ${annotation.dump()}.")
|
||||
is IrVararg -> actualArg.elements.forEach { element -> element.checkIsConst() }
|
||||
else -> actualArg.checkIsConst()
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+5
-5
@@ -8,10 +8,7 @@ package org.jetbrains.kotlin.test.runners.codegen
|
||||
import org.jetbrains.kotlin.test.Constructor
|
||||
import org.jetbrains.kotlin.test.FirParser
|
||||
import org.jetbrains.kotlin.test.TargetBackend
|
||||
import org.jetbrains.kotlin.test.backend.ir.CodegenWithIrFakeOverrideGeneratorSuppressor
|
||||
import org.jetbrains.kotlin.test.backend.ir.IrBackendInput
|
||||
import org.jetbrains.kotlin.test.backend.ir.IrDiagnosticsHandler
|
||||
import org.jetbrains.kotlin.test.backend.ir.JvmIrBackendFacade
|
||||
import org.jetbrains.kotlin.test.backend.ir.*
|
||||
import org.jetbrains.kotlin.test.builders.TestConfigurationBuilder
|
||||
import org.jetbrains.kotlin.test.builders.configureFirHandlersStep
|
||||
import org.jetbrains.kotlin.test.builders.configureIrHandlersStep
|
||||
@@ -64,7 +61,10 @@ abstract class AbstractFirBlackBoxCodegenTestBase(
|
||||
}
|
||||
|
||||
configureIrHandlersStep {
|
||||
useHandlers(::IrDiagnosticsHandler)
|
||||
useHandlers(
|
||||
::IrDiagnosticsHandler,
|
||||
::IrConstCheckerHandler
|
||||
)
|
||||
}
|
||||
|
||||
useAfterAnalysisCheckers(
|
||||
|
||||
Reference in New Issue
Block a user