Do not report "redundant arrow" with parameters without expected type

#KT-29049 Fixed
Part of KT-29005
This commit is contained in:
Mikhail Glukhikh
2018-12-27 14:16:36 +03:00
parent ebd6caaa71
commit cdef811c55
3 changed files with 17 additions and 0 deletions
@@ -14,10 +14,12 @@ import com.intellij.openapi.project.Project
import com.intellij.openapi.util.TextRange
import com.intellij.psi.PsiElementVisitor
import org.jetbrains.kotlin.KtNodeTypes
import org.jetbrains.kotlin.idea.caches.resolve.analyze
import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.endOffset
import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
import org.jetbrains.kotlin.psi.psiUtil.startOffset
import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.calls.util.isSingleUnderscore
class RedundantLambdaArrowInspection : AbstractKotlinInspection() {
@@ -42,6 +44,11 @@ class RedundantLambdaArrowInspection : AbstractKotlinInspection() {
if (callee != null && callee.getReferencedName() == "forEach" && singleParameter?.name != "it") return
}
if (parameters.isNotEmpty()) {
val context = lambdaExpression.analyze()
if (context[BindingContext.EXPECTED_EXPRESSION_TYPE, lambdaExpression] == null) return
}
val startOffset = functionLiteral.startOffset
holder.registerProblem(
holder.manager.createProblemDescriptor(
@@ -0,0 +1,5 @@
// PROBLEM: none
fun foo(x: Int) = x
val x = { it: Int <caret>-> foo(it) }
@@ -4938,6 +4938,11 @@ public class LocalInspectionTestGenerated extends AbstractLocalInspectionTest {
runTest("idea/testData/inspectionsLocal/redundantLambdaArrow/it.kt");
}
@TestMetadata("noExpectedType.kt")
public void testNoExpectedType() throws Exception {
runTest("idea/testData/inspectionsLocal/redundantLambdaArrow/noExpectedType.kt");
}
@TestMetadata("simple.kt")
public void testSimple() throws Exception {
runTest("idea/testData/inspectionsLocal/redundantLambdaArrow/simple.kt");