Change Signature: Do not insert new-lines between parameters (to be fixed later at the formatter level)

This commit is contained in:
Alexey Sedunov
2014-11-24 19:40:53 +03:00
parent 57cb125ab8
commit c6541ccc6f
30 changed files with 48 additions and 102 deletions
@@ -125,7 +125,6 @@ public class JetChangeInfo implements ChangeInfo {
JetParameterInfo parameterInfo = newParameters.get(i);
if (i > 0) {
buffer.append(",");
buffer.append("\n");
buffer.append(indent);
}
@@ -1,8 +1,7 @@
// "Add parameter to constructor 'Base'" "true"
// DISABLE-ERRORS
open class Base(var x: Int,
d: Double) {
open class Base(var x: Int, d: Double) {
val y = Base(1, 2.5);
fun f() {
@@ -1,8 +1,7 @@
// "Add parameter to function 'foo'" "true"
// DISABLE-ERRORS
fun foo(x: Int,
i: Int) {
fun foo(x: Int, i: Int) {
foo(, 4);
foo(1, 4);
foo(1, 4);
@@ -1,10 +1,7 @@
// "Change the signature of function 'foo'" "true"
// DISABLE-ERRORS
fun foo(x: Double,
i: Int,
i1: Int,
i2: Int) {
fun foo(x: Double, i: Int, i1: Int, i2: Int) {
foo(,, 5, 6);
foo(1,, 5, 6);
foo(1, 2.5, 5, 6);
@@ -3,8 +3,7 @@
import kotlin.modules.ModuleBuilder
fun foo(x: Int,
moduleBuilder: ModuleBuilder) {
fun foo(x: Int, moduleBuilder: ModuleBuilder) {
foo(, ModuleBuilder("", ""));
foo(1, ModuleBuilder("", ""));
foo(2, ModuleBuilder("", ""));
@@ -2,5 +2,5 @@
// DISABLE-ERRORS
fun f(x: Int, y: Int, z : () -> Int) {
f(1, 2, {() -> x});
f(1, 2, { x});
}
@@ -2,7 +2,5 @@
// DISABLE-ERRORS
fun f(x: Int, y: Int, z : (Int, Int?, Any) -> Int) {
f(1, 2, {(i: Int,
i1: Int?,
any: Any) -> x});
f(1, 2, {(i: Int, i1: Int?, any: Any) -> x});
}
@@ -1,39 +1,32 @@
// "Add parameter to function 'f'" "true"
trait OA {
fun f(a: Int,
i: Int)
fun f(a: Int, i: Int)
}
trait OB {
fun f(a: Int,
i: Int)
fun f(a: Int, i: Int)
}
trait O : OA, OB {
override fun f(a: Int,
i: Int)
override fun f(a: Int, i: Int)
}
trait OO : O {
override fun f(a: Int,
i: Int) {
override fun f(a: Int, i: Int) {
}
}
trait OOO : OO {
override fun f(a: Int,
i: Int) {}
override fun f(a: Int, i: Int) {}
}
trait OOOA : OOO {
override fun f(a: Int,
i: Int) {
override fun f(a: Int, i: Int) {
}
}
trait OOOB : OOO {
override fun f(a: Int,
i: Int) {
override fun f(a: Int, i: Int) {
}
}
@@ -1,39 +1,32 @@
// "Add parameter to function 'f'" "true"
trait OA {
fun f(a: Int,
s: String)
fun f(a: Int, s: String)
}
trait OB {
fun f(a: Int,
s: String)
fun f(a: Int, s: String)
}
trait O : OA, OB {
override fun f(a: Int,
s: String)
override fun f(a: Int, s: String)
}
trait OO : O {
override fun f(a: Int,
s: String) {
override fun f(a: Int, s: String) {
}
}
trait OOO : OO {
override fun f(a: Int,
s: String) {}
override fun f(a: Int, s: String) {}
}
trait OOOA : OOO {
override fun f(a: Int,
s: String) {
override fun f(a: Int, s: String) {
}
}
trait OOOB : OOO {
override fun f(a: Int,
s: String) {
override fun f(a: Int, s: String) {
}
}
@@ -1,18 +1,15 @@
// "Add parameter to function 'f'" "true"
trait O {
fun f(a: Int,
i: Int)
fun f(a: Int, i: Int)
}
trait OO : O {
override fun f(a: Int,
i: Int) {
override fun f(a: Int, i: Int) {
}
}
trait OOO : OO {
override fun f(a: Int,
i: Int) {}
override fun f(a: Int, i: Int) {}
}
fun usage(o: O) {
@@ -1,6 +1,5 @@
// "Create parameter 'foo'" "true"
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val t: Int = foo
}
@@ -1,8 +1,7 @@
// "Create parameter 'foo'" "true"
class A {
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val t: Int = foo
}
}
@@ -1,8 +1,7 @@
// "Create parameter 'foo'" "true"
class A<T> {
fun test(n: Int,
foo: T) {
fun test(n: Int, foo: T) {
val t: T = foo
}
}
@@ -1,8 +1,7 @@
// "Create parameter 'foo'" "true"
class A {
fun test<T>(n: Int,
foo: T) {
fun test<T>(n: Int, foo: T) {
val t: T = foo
}
}
@@ -1,8 +1,7 @@
// "Create parameter 'foo'" "true"
class A<T> {
fun test<T>(n: Int,
foo: T) {
fun test<T>(n: Int, foo: T) {
val t: T = foo
}
}
@@ -1,7 +1,6 @@
// "Create parameter 'foo'" "true"
// ACTION: Create local variable 'foo'
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val f: () -> Int = { foo }
}
@@ -1,7 +1,6 @@
// "Create parameter 'foo'" "true"
// ACTION: Create local variable 'foo'
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val f: (Int) -> Int = { foo }
}
@@ -1,7 +1,6 @@
// "Create parameter 'foo'" "true"
// ACTION: Create local variable 'foo'
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val f: (Int, Int) -> Int = { (a, b) -> foo }
}
@@ -1,7 +1,6 @@
// "Create parameter 'foo'" "true"
// ACTION: Create local variable 'foo'
fun test(n: Int,
foo: Any) {
fun test(n: Int, foo: Any) {
val f = { (a: Int, b: Int) -> foo }
}
@@ -1,8 +1,7 @@
// "Create parameter 'foo'" "true"
// ACTION: Create local variable 'foo'
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val f: () -> Int = {
foo
}
@@ -1,6 +1,5 @@
// "Create parameter 'foo'" "true"
fun test(n: Int,
foo: Int?) {
fun test(n: Int, foo: Int?) {
val t: Int? = foo
}
@@ -2,7 +2,6 @@
package foo
fun test(n: Int,
foo: Int) {
fun test(n: Int, foo: Int) {
val t: Int = foo
}
@@ -1,4 +1,3 @@
open class A(n: Int,
s: String)
open class A(n: Int, s: String)
class B: A(1, "abc")
@@ -1,6 +1,4 @@
open class C1 protected (x3: ((Int) -> Int)?,
var _x2: Float,
val _x1: Int = 1) {
open class C1 protected (x3: ((Int) -> Int)?, var _x2: Float, val _x1: Int = 1) {
fun bar() {
val y1 = _x1;
val y2 = _x2;
@@ -1,2 +1 @@
fun fun1(x1: Int,
y1: Int): Int = x1 * 2 + fun1(x1, )
fun fun1(x1: Int, y1: Int): Int = x1 * 2 + fun1(x1, )
@@ -1,9 +1,7 @@
open class A {
open fun foo(n: Int,
s: String): String = ""
open fun foo(n: Int, s: String): String = ""
}
class B: A() {
override fun foo(n: Int,
s: String): String = ""
override fun foo(n: Int, s: String): String = ""
}
@@ -1,5 +1,3 @@
fun foo() {
val v1 = {(z: Int,
y1: String,
x: Any): Int -> println(z); println(y1) }
val v1 = {(z: Int, y1: String, x: Any): Int -> println(z); println(y1) }
}
@@ -1,6 +1,4 @@
fun foo(x0: Any?,
x1: Int = 1,
x2: Float) {
fun foo(x0: Any?, x1: Int = 1, x2: Float) {
foo(null, 2, 3.5);
val y1 = x1;
val y2 = x2;
@@ -1,18 +1,15 @@
trait T {
fun foo(a: Int = 1,
b: String = "2")
fun foo(a: Int = 1, b: String = "2")
}
open class A: T {
override fun foo(a: Int,
b: String) {
override fun foo(a: Int, b: String) {
throw UnsupportedOperationException()
}
}
class B: A() {
override fun foo(a: Int,
b: String) {
override fun foo(a: Int, b: String) {
throw UnsupportedOperationException()
}
}
@@ -1,16 +1,13 @@
enum class E {
open fun foo(n: Int,
s: String): Int = n
open fun foo(n: Int, s: String): Int = n
O
A {
override fun foo(n: Int,
s: String): Int = n + 1
override fun foo(n: Int, s: String): Int = n + 1
}
B {
override fun foo(n: Int,
s: String): Int = n + 2
override fun foo(n: Int, s: String): Int = n + 2
}
}