Rename AdditionalCompilerArguments->CompilationOptions

This commit is contained in:
Alexey Tsvetkov
2017-01-10 19:45:10 +03:00
parent bf50a23221
commit c5a5463f50
9 changed files with 22 additions and 22 deletions
@@ -19,13 +19,13 @@ package org.jetbrains.kotlin.daemon.common
import java.io.File
import java.io.Serializable
open class AdditionalCompilerArguments(val reportingFilters: List<ReportingFilter>) : Serializable {
open class CompilationOptions(val reportingFilters: List<ReportingFilter>) : Serializable {
companion object {
const val serialVersionUID: Long = 0
}
}
class IncrementalCompilerArguments(
class IncrementalCompilationOptions(
val areFileChangesKnown: Boolean,
val modifiedFiles: List<File>?,
val deletedFiles: List<File>?,
@@ -33,7 +33,7 @@ class IncrementalCompilerArguments(
val customCacheVersionFileName: String,
val customCacheVersion: Int,
reportingFilters: List<ReportingFilter>
) : AdditionalCompilerArguments(reportingFilters) {
) : CompilationOptions(reportingFilters) {
companion object {
const val serialVersionUID: Long = 0
}
@@ -139,7 +139,7 @@ interface CompileService : Remote {
compilerMode: CompilerMode,
targetPlatform: TargetPlatform,
compilerArguments: CommonCompilerArguments,
additionalCompilerArguments: AdditionalCompilerArguments,
compilationOptions: CompilationOptions,
servicesFacade: CompilerServicesFacadeBase
): CallResult<Int>
@@ -326,11 +326,11 @@ class CompileServiceImpl(
compilerMode: CompileService.CompilerMode,
targetPlatform: CompileService.TargetPlatform,
compilerArguments: CommonCompilerArguments,
additionalCompilerArguments: AdditionalCompilerArguments,
compilationOptions: CompilationOptions,
servicesFacade: CompilerServicesFacadeBase
): CompileService.CallResult<Int> {
val messageCollector = CompileServicesFacadeMessageCollector(servicesFacade, additionalCompilerArguments)
val serviceReporter = CompileServiceReporterImpl(servicesFacade, additionalCompilerArguments)
val messageCollector = CompileServicesFacadeMessageCollector(servicesFacade, compilationOptions)
val serviceReporter = CompileServiceReporterImpl(servicesFacade, compilationOptions)
return when (compilerMode) {
CompileService.CompilerMode.JPS_COMPILER -> {
@@ -352,7 +352,7 @@ class CompileServiceImpl(
}
val k2jvmArgs = compilerArguments as K2JVMCompilerArguments
val gradleIncrementalArgs = additionalCompilerArguments as IncrementalCompilerArguments
val gradleIncrementalArgs = compilationOptions as IncrementalCompilationOptions
val gradleIncrementalServicesFacade = servicesFacade as IncrementalCompilerServicesFacade
withIC {
@@ -386,7 +386,7 @@ class CompileServiceImpl(
private fun execIncrementalCompiler(
k2jvmArgs: K2JVMCompilerArguments,
incrementalCompilerArgs: IncrementalCompilerArguments,
incrementalCompilerArgs: IncrementalCompilationOptions,
servicesFacade: IncrementalCompilerServicesFacade,
messageCollector: CompileServicesFacadeMessageCollector
): ExitCode {
@@ -19,7 +19,7 @@ package org.jetbrains.kotlin.daemon.incremental
import org.jetbrains.kotlin.cli.common.ExitCode
import org.jetbrains.kotlin.daemon.report.FilteringReporterBase
import org.jetbrains.kotlin.daemon.common.CompilerServicesFacadeBase
import org.jetbrains.kotlin.daemon.common.AdditionalCompilerArguments
import org.jetbrains.kotlin.daemon.common.CompilationOptions
import org.jetbrains.kotlin.daemon.common.IncrementalCompilationServicesFacade
import org.jetbrains.kotlin.daemon.common.ReportCategory
import org.jetbrains.kotlin.daemon.incremental.IncrementalCompilationSeverity.COMPILED_FILES
@@ -30,7 +30,7 @@ import java.io.Serializable
internal class RemoteICReporter(
servicesFacade: CompilerServicesFacadeBase,
additionalCompilerArgs: AdditionalCompilerArguments
additionalCompilerArgs: CompilationOptions
) : FilteringReporterBase(servicesFacade, additionalCompilerArgs, ReportCategory.INCREMENTAL_COMPILATION), ICReporter {
override fun report(message: () -> String) {
if (shouldReport(LOGGING.value)) {
@@ -17,7 +17,7 @@
package org.jetbrains.kotlin.daemon.report
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
import org.jetbrains.kotlin.daemon.common.AdditionalCompilerArguments
import org.jetbrains.kotlin.daemon.common.CompilationOptions
import org.jetbrains.kotlin.daemon.common.CompilerServicesFacadeBase
import org.jetbrains.kotlin.daemon.common.ReportCategory
import org.jetbrains.kotlin.daemon.report.FilteringReporterBase
@@ -40,8 +40,8 @@ internal class CompileServiceReporterStreamAdapter(private val out: PrintStream)
internal class CompileServiceReporterImpl(
servicesFacade: CompilerServicesFacadeBase,
additionalCompilerArguments: AdditionalCompilerArguments
) : FilteringReporterBase(servicesFacade, additionalCompilerArguments, ReportCategory.DAEMON_MESSAGE), CompileServiceReporter {
compilationOptions: CompilationOptions
) : FilteringReporterBase(servicesFacade, compilationOptions, ReportCategory.DAEMON_MESSAGE), CompileServiceReporter {
override fun report(severity: CompilerMessageSeverity, message: String) {
report(severity.value, message)
@@ -19,16 +19,16 @@ package org.jetbrains.kotlin.daemon.report
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
import org.jetbrains.kotlin.cli.common.messages.MessageCollector
import org.jetbrains.kotlin.daemon.common.AdditionalCompilerArguments
import org.jetbrains.kotlin.daemon.common.CompilationOptions
import org.jetbrains.kotlin.daemon.common.CompilerServicesFacadeBase
import org.jetbrains.kotlin.daemon.common.ReportCategory
internal class CompileServicesFacadeMessageCollector(
private val servicesFacade: CompilerServicesFacadeBase,
additionalCompilerArguments: AdditionalCompilerArguments
compilationOptions: CompilationOptions
) : MessageCollector {
private var hasErrors = false
private val reportingFilter = additionalCompilerArguments.reportingFilters.firstOrNull { it.category == ReportCategory.DAEMON_MESSAGE }
private val reportingFilter = compilationOptions.reportingFilters.firstOrNull { it.category == ReportCategory.DAEMON_MESSAGE }
override fun clear() {
hasErrors = false
@@ -16,14 +16,14 @@
package org.jetbrains.kotlin.daemon.report
import org.jetbrains.kotlin.daemon.common.AdditionalCompilerArguments
import org.jetbrains.kotlin.daemon.common.CompilationOptions
import org.jetbrains.kotlin.daemon.common.CompilerServicesFacadeBase
import org.jetbrains.kotlin.daemon.common.ReportCategory
import java.io.Serializable
internal open class FilteringReporterBase(
private val servicesFacade: CompilerServicesFacadeBase,
additionalCompilerArgs: AdditionalCompilerArguments,
additionalCompilerArgs: CompilationOptions,
private val reportCategory: ReportCategory
) {
private val reportingFilter = additionalCompilerArgs.reportingFilters.firstOrNull { it.category == reportCategory }
@@ -104,7 +104,7 @@ class JpsKotlinCompilerRunner : KotlinCompilerRunner<JpsCompilerEnvironment>() {
CompileService.CompilerMode.JPS_COMPILER,
targetPlatform,
compilerArgs,
AdditionalCompilerArguments(reportingFilters = getReportingFilters(compilerArgs.verbose)),
CompilationOptions(reportingFilters = getReportingFilters(compilerArgs.verbose)),
JpsCompilerServicesFacadeImpl(environment))
}
@@ -169,7 +169,7 @@ internal class GradleCompilerRunner(private val project: Project) : KotlinCompil
CompileService.CompilerMode.NON_INCREMENTAL_COMPILER,
targetPlatform,
environment.compilerArgs,
AdditionalCompilerArguments(reportingFilters = getNonIncrementalReportingFilters(environment.compilerArgs.verbose)),
CompilationOptions(reportingFilters = getNonIncrementalReportingFilters(environment.compilerArgs.verbose)),
GradleCompilerServicesFacadeImpl(project, environment.messageCollector))
}
@@ -184,7 +184,7 @@ internal class GradleCompilerRunner(private val project: Project) : KotlinCompil
private fun incrementalCompilationWithDaemon(environment: GradleIncrementalCompilerEnvironment): ExitCode? {
val knownChangedFiles = environment.changedFiles as? ChangedFiles.Known
val additionalCompilerArguments = IncrementalCompilerArguments(
val additionalCompilerArguments = IncrementalCompilationOptions(
areFileChangesKnown = knownChangedFiles != null,
modifiedFiles = knownChangedFiles?.modified,
deletedFiles = knownChangedFiles?.removed,