NI: Report incompatible receiver of callable reference

^KT-35535 Fixed

compiler/fir/resolve/tests/org/jetbrains/kotlin/fir/FirOldFrontendDiagnosticsTestGenerated.java

@@ -1789,6 +1789,11 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirOldFronte
             runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirection.kt");
         }
 
+        @TestMetadata("constraintFromLHSWithCorrectDirectionError.kt")
+        public void testConstraintFromLHSWithCorrectDirectionError() throws Exception {
+            runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirectionError.kt");
+        }
+
         @TestMetadata("correctInfoAfterArrayLikeCall.kt")
         public void testCorrectInfoAfterArrayLikeCall() throws Exception {
             runTest("compiler/testData/diagnostics/tests/callableReference/correctInfoAfterArrayLikeCall.kt");

compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/DiagnosticReporterByTrackingStrategy.kt

@@ -265,8 +265,13 @@ class DiagnosticReporterByTrackingStrategy(
             NewConstraintError::class.java -> {
                 val constraintError = diagnostic as NewConstraintError
                 val position = constraintError.position.from
-                val argument = (position as? ArgumentConstraintPosition)?.argument
-                    ?: (position as? ReceiverConstraintPosition)?.argument
+                val argument =
+                    when (position) {
+                        is ArgumentConstraintPosition -> position.argument
+                        is ReceiverConstraintPosition -> position.argument
+                        is LHSArgumentConstraintPosition -> position.argument
+                        else -> null
+                    }
                 argument?.let {
                     it.safeAs<LambdaKotlinCallArgument>()?.let lambda@{ lambda ->
                         val parameterTypes = lambda.parametersTypes?.toList() ?: return@lambda

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/components/PostponeArgumentsChecks.kt

@@ -162,7 +162,7 @@ private fun preprocessCallableReference(
 
     val lhsResult = argument.lhsResult
     if (lhsResult is LHSResult.Type) {
-        csBuilder.addConstraintFromLHS(lhsResult, expectedType)
+        csBuilder.addConstraintFromLHS(argument, lhsResult, expectedType)
     }
 
     val notCallableTypeConstructor =
@@ -181,13 +181,17 @@ private fun preprocessCallableReference(
     return result
 }
 
-private fun ConstraintSystemBuilder.addConstraintFromLHS(lhsResult: LHSResult.Type, expectedType: UnwrappedType) {
+private fun ConstraintSystemBuilder.addConstraintFromLHS(
+    argument: CallableReferenceKotlinCallArgument,
+    lhsResult: LHSResult.Type,
+    expectedType: UnwrappedType
+) {
     if (!ReflectionTypes.isNumberedTypeWithOneOrMoreNumber(expectedType)) return
 
     val lhsType = lhsResult.unboundDetailedReceiver.stableType
     val expectedTypeProjectionForLHS = expectedType.arguments.first()
     val expectedTypeForLHS = expectedTypeProjectionForLHS.type
-    val constraintPosition = LHSArgumentConstraintPosition(lhsResult.qualifier ?: lhsResult.unboundDetailedReceiver)
+    val constraintPosition = LHSArgumentConstraintPosition(argument, lhsResult.qualifier ?: lhsResult.unboundDetailedReceiver)
 
     when (expectedTypeProjectionForLHS.projectionKind) {
         Variance.INVARIANT -> addEqualityConstraint(lhsType, expectedTypeForLHS, constraintPosition)

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/inference/model/ConstraintPositionAndErrors.kt

@@ -63,7 +63,10 @@ class KnownTypeParameterConstraintPosition(val typeArgument: KotlinType) : Const
     override fun toString() = "TypeArgument $typeArgument"
 }
 
-class LHSArgumentConstraintPosition(val receiver: DetailedReceiver) : ConstraintPosition() {
+class LHSArgumentConstraintPosition(
+    val argument: CallableReferenceKotlinCallArgument,
+    val receiver: DetailedReceiver
+) : ConstraintPosition() {
     override fun toString(): String {
         return "LHS receiver $receiver"
     }
@@ -121,4 +124,4 @@ class ConstrainingTypeIsError(
     val typeVariable: TypeVariableMarker,
     val constraintType: KotlinTypeMarker,
     val position: IncorporationConstraintPosition
-) : ConstraintSystemCallDiagnostic(INAPPLICABLE)
+) : ConstraintSystemCallDiagnostic(INAPPLICABLE)

compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirectionError.fir.kt

@@ -0,0 +1,19 @@
+// SKIP_TXT
+// !LANGUAGE: +NewInference
+// !DIAGNOSTICS: -UNUSED_PARAMETER
+
+package test
+import kotlin.reflect.KProperty1
+
+interface A {
+    val bla: CharSequence get() = ""
+}
+
+class B<T>(val x: T)
+fun <K, V> B<K>.foo(p: KProperty1<K, V>) {}
+
+class C : A
+
+fun <R : A> B<R>.test(){
+    <!INAPPLICABLE_CANDIDATE!>foo<!>(C::bla)
+}

compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirectionError.kt

@@ -0,0 +1,19 @@
+// SKIP_TXT
+// !LANGUAGE: +NewInference
+// !DIAGNOSTICS: -UNUSED_PARAMETER
+
+package test
+import kotlin.reflect.KProperty1
+
+interface A {
+    val bla: CharSequence get() = ""
+}
+
+class B<T>(val x: T)
+fun <K, V> B<K>.foo(p: KProperty1<K, V>) {}
+
+class C : A
+
+fun <R : A> B<R>.test(){
+    foo(<!TYPE_MISMATCH, TYPE_MISMATCH, TYPE_MISMATCH!>C::bla<!>)
+}

compiler/tests/org/jetbrains/kotlin/checkers/DiagnosticsTestGenerated.java

@@ -1796,6 +1796,11 @@ public class DiagnosticsTestGenerated extends AbstractDiagnosticsTest {
                 runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirection.kt");
             }
 
+            @TestMetadata("constraintFromLHSWithCorrectDirectionError.kt")
+            public void testConstraintFromLHSWithCorrectDirectionError() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirectionError.kt");
+            }
+
             @TestMetadata("correctInfoAfterArrayLikeCall.kt")
             public void testCorrectInfoAfterArrayLikeCall() throws Exception {
                 runTest("compiler/testData/diagnostics/tests/callableReference/correctInfoAfterArrayLikeCall.kt");

compiler/tests/org/jetbrains/kotlin/checkers/javac/DiagnosticsUsingJavacTestGenerated.java

@@ -1791,6 +1791,11 @@ public class DiagnosticsUsingJavacTestGenerated extends AbstractDiagnosticsUsing
                 runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirection.kt");
             }
 
+            @TestMetadata("constraintFromLHSWithCorrectDirectionError.kt")
+            public void testConstraintFromLHSWithCorrectDirectionError() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/callableReference/constraintFromLHSWithCorrectDirectionError.kt");
+            }
+
             @TestMetadata("correctInfoAfterArrayLikeCall.kt")
             public void testCorrectInfoAfterArrayLikeCall() throws Exception {
                 runTest("compiler/testData/diagnostics/tests/callableReference/correctInfoAfterArrayLikeCall.kt");