azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Create special copy function in FunctionInlining

Browse Source 
Semantically this is the same code, but it is easier to read
This commit is contained in:
Ivan Kylchik
2022-01-24 23:22:31 +03:00
committed by Space Team
parent ba2e46758d
commit c2fc745d66
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/inline/FunctionInlining.kt
+8 -10
View File
@@ -164,18 +164,16 @@ class FunctionInlining(
fun inline() = inlineFunction(callSite, callee, true)
private fun IrElement.copy(): IrElement {
return copyIrElement.copy(this)
}
private fun inlineFunction(
callSite: IrFunctionAccessExpression,
callee: IrFunction,
performRecursiveInline: Boolean
): IrReturnableBlock {
val copiedCallee = (copyIrElement.copy(callee) as IrFunction).apply {
// It's a hack to overtake another hack in PIR. Due to PersistentIrFactory registers every created declaration
// there also get temporary declaration like this which leads to some unclear behaviour. Since I am not aware
// enough about PIR internals the simplest way seemed to me is to unregister temporary function. Hope it is going
// to be removed ASAP along with registering every PIR declaration.
val copiedCallee = (callee.copy() as IrFunction).apply {
parent = callee.parent
if (performRecursiveInline) {
body?.transformChildrenVoid()
@@ -247,7 +245,7 @@ class FunctionInlining(
if (argument is IrGetValueWithoutLocation)
argument.withLocation(newExpression.startOffset, newExpression.endOffset)
else
(copyIrElement.copy(argument) as IrExpression)
(argument.copy() as IrExpression)
if (insertAdditionalImplicitCasts)
ret = ret.implicitCastIfNeededTo(newExpression.type)
@@ -356,10 +354,10 @@ class FunctionInlining(
val arg = boundFunctionParametersMap[parameter]!!
if (arg is IrGetValueWithoutLocation)
arg.withLocation(irCall.startOffset, irCall.endOffset)
else copyIrElement.copy(arg) as IrExpression
else arg.copy() as IrExpression
} else {
if (unboundIndex == valueParameters.size && parameter.defaultValue != null)
copyIrElement.copy(parameter.defaultValue!!.expression) as IrExpression
parameter.defaultValue!!.expression.copy() as IrExpression
else if (!parameter.isVararg) {
assert(unboundIndex < valueParameters.size) {
"Attempt to use unbound parameter outside of the callee's value parameters"