azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace explicit parameter isn't shown on destructuring declaration

Browse Source 
So #KT-17026 Fixed
This commit is contained in:
Toshiaki Kameyama
2017-06-08 13:04:51 +03:00
committed by Mikhail Glukhikh
parent e5717d3e96
commit c149e956cc
3 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/intentions/ReplaceExplicitFunctionLiteralParamWithItIntention.kt
+2 -1
View File
@@ -43,8 +43,9 @@ class ReplaceExplicitFunctionLiteralParamWithItIntention : PsiElementBaseIntenti
val parameter = functionLiteral.valueParameters.singleOrNull() ?: return false
if (parameter.typeReference != null) return false
if (parameter.destructuringDeclaration != null) return false
if (functionLiteral.anyDescendantOfType<KtFunctionLiteral>() { literal ->
if (functionLiteral.anyDescendantOfType<KtFunctionLiteral> { literal ->
literal.usesName(element.text) &&
(!literal.hasParameterSpecification() || literal.usesName("it"))
} ) return false
idea/testData/intentions/replaceExplicitFunctionLiteralParamWithIt/notApplicable_hasDestructuringDeclaration.kt
Vendored
+4
View File
@@ -0,0 +1,4 @@
// WITH_RUNTIME
// IS_APPLICABLE: false
val list = listOf(Pair(1, 2), Pair(3, 4)).map { (<caret>f, s) -> f + s }
idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTestGenerated.java
+6
View File
@@ -13388,6 +13388,12 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
doTest(fileName);
}
@TestMetadata("notApplicable_hasDestructuringDeclaration.kt")
public void testNotApplicable_hasDestructuringDeclaration() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/replaceExplicitFunctionLiteralParamWithIt/notApplicable_hasDestructuringDeclaration.kt");
doTest(fileName);
}
@TestMetadata("notApplicable_hasMultipleParameters.kt")
public void testNotApplicable_hasMultipleParameters() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/replaceExplicitFunctionLiteralParamWithIt/notApplicable_hasMultipleParameters.kt");