Remove some workarounds for extra properties and signing,

use new syntax for maven repo definition.
This commit is contained in:
Ilya Gorbunov
2017-10-18 18:13:08 +03:00
parent 4d4285824b
commit be63f09f8f
3 changed files with 12 additions and 17 deletions
+2 -2
View File
@@ -23,7 +23,7 @@ buildscript {
repositories {
for (repo in repos) {
maven { setUrl(repo) }
maven(url = repo)
}
}
@@ -69,7 +69,7 @@ val scriptRuntimeCfg = configurations.create("scriptRuntime").extendsFrom(script
repositories {
for (repo in (rootProject.extra["repos"] as List<String>)) {
maven { setUrl(repo) }
maven(url = repo)
}
}
+4 -4
View File
@@ -1,12 +1,12 @@
buildscript {
val buildSrcKotlinVersion: String by extra(findProperty("buildSrc.kotlin.version")?.toString() ?: embeddedKotlinVersion)
extra["buildSrcKotlinRepo"] = findProperty("buildSrc.kotlin.repo")
val buildSrcKotlinRepo: String? by extra(findProperty("buildSrc.kotlin.repo") as String?)
extra["versions.shadow"] = "2.0.1"
repositories {
extra["buildSrcKotlinRepo"]?.let {
maven { setUrl(it) }
buildSrcKotlinRepo?.let {
maven(url = it)
}
}
@@ -31,7 +31,7 @@ plugins {
repositories {
extra["buildSrcKotlinRepo"]?.let {
maven { setUrl(it) }
maven(url = it)
}
maven(url = "https://dl.bintray.com/kotlin/kotlin-dev") // for dex-method-list
// maven { setUrl("https://repo.gradle.org/gradle/libs-releases-local") }
@@ -4,7 +4,7 @@ import org.codehaus.groovy.runtime.InvokerHelper
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.artifacts.Dependency
import org.gradle.api.artifacts.maven.MavenDeployer
import org.gradle.api.artifacts.maven.MavenDeployment
import org.gradle.api.artifacts.maven.MavenResolver
import org.gradle.api.plugins.MavenRepositoryHandlerConvention
@@ -100,21 +100,16 @@ open class PublishedKotlinModule : Plugin<Project> {
var repository: MavenRemoteRepository by Delegates.notNull()
val signPom = rootProject.extra["signPom"] as groovy.lang.Closure<*>
repositories {
withConvention(MavenRepositoryHandlerConvention::class) {
mavenDeployer {
signPom.call(project, this as MavenDeployer)
withGroovyBuilder {
// TODO: Use with kotlin-dsl 0.12+ instead of signPom
// "beforeDeployment" {
// val signing = project.the<SigningExtension>()
// if (signing.isRequired)
// signing.signPom(this as MavenDeployment)
// }
"beforeDeployment" {
val signing = project.the<SigningExtension>()
if (signing.isRequired)
signing.signPom(delegate as MavenDeployment)
}
"repository"("url" to repoUrl)!!.also { repository = it as MavenRemoteRepository }.withGroovyBuilder {
if (username != null && password != null) {