[K/JS] Optimize logical operators generating

compiler/ir/backend.js/src/org/jetbrains/kotlin/ir/backend/js/transformers/irToJs/IrElementToJsExpressionTransformer.kt

@@ -239,6 +239,20 @@ class IrElementToJsExpressionTransformer : BaseIrElementToJsNodeTransformer<JsEx
     }
 
     override fun visitWhen(expression: IrWhen, context: JsGenerationContext): JsExpression {
+        if (expression.origin == IrStatementOrigin.ANDAND) {
+            return JsBinaryOperation(
+                JsBinaryOperator.AND,
+                expression.branches[0].condition.accept(this, context),
+                expression.branches[0].result.accept(this, context)
+            )
+        }
+        if (expression.origin == IrStatementOrigin.OROR) {
+            return JsBinaryOperation(
+                JsBinaryOperator.OR,
+                expression.branches[0].condition.accept(this, context),
+                expression.branches[1].result.accept(this, context)
+            )
+        }
         val lastBranch = expression.branches.lastOrNull()
         val implicitElse =
             if (lastBranch == null || !isElseBranch(lastBranch))

compiler/testData/debug/stepping/constantConditions.kt

@@ -25,6 +25,7 @@ fun test(): Long {
 
 // EXPECTATIONS JS_IR
 // test.kt:6 box
+// test.kt:10 test
 // test.kt:12 test
 // test.kt:7 box
 

js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/fir/FirJsES6BoxTestGenerated.java

@@ -7270,6 +7270,12 @@ public class FirJsES6BoxTestGenerated extends AbstractFirJsES6BoxTest {
       runTest("js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunction.kt");
     }
 
+    @Test
+    @TestMetadata("logicalOperators.kt")
+    public void testLogicalOperators() {
+      runTest("js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt");
+    }
+
     @Test
     @TestMetadata("tempVarDeclOnAssignment.kt")
     public void testTempVarDeclOnAssignment() {

js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/fir/FirLightTreeJsBoxTestGenerated.java

@@ -7164,6 +7164,12 @@ public class FirLightTreeJsBoxTestGenerated extends AbstractFirLightTreeJsBoxTes
       runTest("js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunction.kt");
     }
 
+    @Test
+    @TestMetadata("logicalOperators.kt")
+    public void testLogicalOperators() {
+      runTest("js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt");
+    }
+
     @Test
     @TestMetadata("tempVarDeclOnAssignment.kt")
     public void testTempVarDeclOnAssignment() {

js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/fir/FirPsiJsBoxTestGenerated.java

@@ -7164,6 +7164,12 @@ public class FirPsiJsBoxTestGenerated extends AbstractFirPsiJsBoxTest {
       runTest("js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunction.kt");
     }
 
+    @Test
+    @TestMetadata("logicalOperators.kt")
+    public void testLogicalOperators() {
+      runTest("js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt");
+    }
+
     @Test
     @TestMetadata("tempVarDeclOnAssignment.kt")
     public void testTempVarDeclOnAssignment() {

js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsES6TestGenerated.java

@@ -7270,6 +7270,12 @@ public class IrBoxJsES6TestGenerated extends AbstractIrBoxJsES6Test {
       runTest("js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunction.kt");
     }
 
+    @Test
+    @TestMetadata("logicalOperators.kt")
+    public void testLogicalOperators() {
+      runTest("js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt");
+    }
+
     @Test
     @TestMetadata("tempVarDeclOnAssignment.kt")
     public void testTempVarDeclOnAssignment() {

js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsTestGenerated.java

@@ -7164,6 +7164,12 @@ public class IrBoxJsTestGenerated extends AbstractIrBoxJsTest {
       runTest("js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunction.kt");
     }
 
+    @Test
+    @TestMetadata("logicalOperators.kt")
+    public void testLogicalOperators() {
+      runTest("js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt");
+    }
+
     @Test
     @TestMetadata("tempVarDeclOnAssignment.kt")
     public void testTempVarDeclOnAssignment() {

js/js.translator/testData/box/jsAstOptimizations/inlineEmptyFunctionTest.js

@@ -7,7 +7,7 @@ function box() {
   if (!(flag1 === 0)) {
     var tmp;
     var tmp_0;
-    if (equals(OK, 'OK') ? flag1 === 1 : false) {
+    if (equals(OK, 'OK') && flag1 === 1) {
       var tmp_1 = flag2;
       tmp_0 = typeof tmp_1 === 'number';
     } else {
@@ -26,7 +26,7 @@ function box() {
   if (!(flag1 === 0)) {
     var tmp_2;
     var tmp_3;
-    if (equals(OK, 'OK') ? flag1 === 1 : false) {
+    if (equals(OK, 'OK') && flag1 === 1) {
       var tmp_4 = flag2;
       tmp_3 = typeof tmp_4 === 'number';
     } else {

js/js.translator/testData/box/jsAstOptimizations/logicalOperators.js

@@ -0,0 +1,3 @@
+function test() {
+  return (!a || (b && c)) && foo() || bar();
+}

js/js.translator/testData/box/jsAstOptimizations/logicalOperators.kt

@@ -0,0 +1,13 @@
+val a = true
+val b = true
+val c = true
+
+fun foo() = true
+fun bar() = true
+
+// EXPECT_GENERATED_JS: function=test expect=logicalOperators.js
+fun test(): Boolean = (!a || (b && c)) && foo() || bar()
+
+fun box(): String {
+    return if (test()) "OK" else "FAILED"
+}