CreateExpect: fix case with parameters in constructor without var/val

idea/src/org/jetbrains/kotlin/idea/quickfix/expectactual/CreateExpectedFix.kt

@@ -130,7 +130,10 @@ class CreateExpectedClassFix(
 
     if (!showUnknownTypesDialog(project, declarationsWithNonExistentClasses)) return@block null
 
-    val membersForSelection = members.filterNot(KtNamedDeclaration::isAlwaysActual)
+    val membersForSelection = members.filter {
+        !it.isAlwaysActual() && if (it is KtParameter) it.hasValOrVar() else true
+    }
+
     val selectedElements = when {
         membersForSelection.all(KtDeclaration::hasActualModifier) -> membersForSelection
         ApplicationManager.getApplication().isUnitTestMode -> membersForSelection.filter(KtDeclaration::hasActualModifier)
@@ -138,9 +141,9 @@ class CreateExpectedClassFix(
             val prefix = klass.fqName?.asString()?.plus(".") ?: ""
             chooseMembers(project, membersForSelection, prefix) ?: return@block null
         }
-    }.asSequence().plus(members.filter(KtNamedDeclaration::isAlwaysActual)).flatMap(KtNamedDeclaration::selected).toSet()
+    }.asSequence().plus(klass).plus(members.filter(KtNamedDeclaration::isAlwaysActual)).flatMap(KtNamedDeclaration::selected).toSet()
 
-    val selectedClasses = findClasses(selectedElements + klass, commonModule)
+    val selectedClasses = findClasses(selectedElements, commonModule)
     val resultDeclarations = if (selectedClasses != existingClasses) {
         if (!element.checkTypeAccessibilityInModule(commonModule, selectedClasses)) {
             showUnknownTypesError(element)
@@ -258,7 +261,7 @@ private fun repairActualModifiers(
     originalElements: Collection<KtNamedDeclaration>,
     selectedElements: Collection<KtNamedDeclaration>
 ) {
-    if (originalElements.size == selectedElements.size)
+    if (originalElements == selectedElements)
         for (original in originalElements) {
             original.makeActualWithParents()
         }

idea/testData/multiModuleQuickFix/expectFunWithInaccessibleParameter/jvm/Utils.kt

@@ -1,5 +1,5 @@
 // "Create expected function in common module testModule_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type Some is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun foo(some: Some){...}
 // DISABLE-ERRORS
 
 class Some

idea/testData/multiModuleQuickFix/expectFunWithInaccessibleParameter/jvm/Utils.kt.after

@@ -1,5 +1,5 @@
 // "Create expected function in common module testModule_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type Some is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun foo(some: Some){...}
 // DISABLE-ERRORS
 
 class Some

idea/testData/multiModuleQuickFix/expectFunWithInaccessibleTypeParameter/jvm/Utils.kt

@@ -1,5 +1,5 @@
 // "Create expected function in common module testModule_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type Some is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun foo(some: List<Some>){...}
 // DISABLE-ERRORS
 
 class Some

idea/testData/multiModuleQuickFix/expectFunWithInaccessibleTypeParameter/jvm/Utils.kt.after

@@ -1,5 +1,5 @@
 // "Create expected function in common module testModule_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type Some is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun foo(some: List<Some>){...}
 // DISABLE-ERRORS
 
 class Some

idea/testData/multiModuleQuickFix/expectFunWithJdk/proj_jvm_dep(fulljdk)/Utils.kt

@@ -1,5 +1,5 @@
 // "Create expected function in common module proj_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type java.util.ArrayList<kotlin.Any> is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun createList() = ArrayList()
 // DISABLE-ERRORS
 
 import java.util.ArrayList

idea/testData/multiModuleQuickFix/expectFunWithJdk/proj_jvm_dep(fulljdk)/Utils.kt.after

@@ -1,5 +1,5 @@
 // "Create expected function in common module proj_Common" "true"
-// SHOULD_FAIL_WITH: Cannot generate expected function: Type java.util.ArrayList<kotlin.Any> is not accessible from common code
+// SHOULD_FAIL_WITH: You cannot create the expect declaration from:,fun createList() = ArrayList()
 // DISABLE-ERRORS
 
 import java.util.ArrayList

idea/testData/multiModuleQuickFix/expectWithAnnotations/header/My.kt.after

@@ -5,6 +5,7 @@ annotation class CommonAnnotation
 expect class My {
     tailrec fun foo(arg: Int): Int
     var some: Boolean
+    @CommonAnnotation
     fun initialize()
 
 }