tests changed:

added check for unused/uninitialized variables inside local and anonymous functions

compiler/testData/diagnostics/tests/FunctionReturnTypes.jet

@@ -175,12 +175,12 @@ class B() {
 
 fun testFunctionLiterals() {
     val <!UNUSED_VARIABLE!>endsWithVarDeclaration<!> : () -> Boolean = {
-        <!EXPECTED_TYPE_MISMATCH!>val x = 2<!>
+        <!EXPECTED_TYPE_MISMATCH!>val <!UNUSED_VARIABLE!>x<!> = 2<!>
     }
 
     val <!UNUSED_VARIABLE!>endsWithAssignment<!> = { () : Int ->
-        var x = 1
-        <!EXPECTED_TYPE_MISMATCH!>x = 333<!>
+        var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>x<!> = 1
+        <!EXPECTED_TYPE_MISMATCH!>x = <!UNUSED_VALUE!>333<!><!>
     }
 
     val <!UNUSED_VARIABLE!>endsWithReAssignment<!> = { () : Int ->
@@ -189,19 +189,19 @@ fun testFunctionLiterals() {
     }
 
     val <!UNUSED_VARIABLE!>endsWithFunDeclaration<!> : () -> String = {
-        var x = 1
-        x = 333
+        var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>x<!> = 1
+        x = <!UNUSED_VALUE!>333<!>
         <!EXPECTED_TYPE_MISMATCH!>fun meow() : Unit {}<!>
     }
 
     val <!UNUSED_VARIABLE!>endsWithObjectDeclaration<!> : () -> Int = {
-        var x = 1
-        x = 333
+        var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>x<!> = 1
+        x = <!UNUSED_VALUE!>333<!>
         <!EXPECTED_TYPE_MISMATCH!>object A {}<!>
     }
 
     val <!UNUSED_VARIABLE!>expectedUnitReturnType1<!> = { () : Unit ->
-        val x = 1
+        val <!UNUSED_VARIABLE!>x<!> = 1
     }
 
     val <!UNUSED_VARIABLE!>expectedUnitReturnType2<!> = { () : Unit ->

compiler/testData/diagnostics/tests/StringTemplates.jet

@@ -3,8 +3,8 @@ fun demo() {
   val a = ""
   val asd = 1
   val bar = 5
-  fun map(f :  () -> Any?) : Int  = 1
-  fun buzz(f :  () -> Any?) : Int  = 1
+  fun map(<!UNUSED_PARAMETER!>f<!> :  () -> Any?) : Int  = 1
+  fun buzz(<!UNUSED_PARAMETER!>f<!> :  () -> Any?) : Int  = 1
   val sdf = 1
   val foo = 3;
     <!UNUSED_EXPRESSION!>"$abc"<!>
@@ -19,4 +19,4 @@ fun demo() {
     <!UNUSED_EXPRESSION!>"foo${bar + map {
       "foo$sdf${ buzz{}}" }}sdfsdf"<!>
     <!UNUSED_EXPRESSION!>"a<!ILLEGAL_ESCAPE_SEQUENCE!>\u<!> <!ILLEGAL_ESCAPE_SEQUENCE!>\u<!>0 <!ILLEGAL_ESCAPE_SEQUENCE!>\u<!>00 <!ILLEGAL_ESCAPE_SEQUENCE!>\u<!>000 \u0000 \u0AaA <!ILLEGAL_ESCAPE_SEQUENCE!>\u<!>0AAz.length( ) + \u0022b"<!>
-}
+}

compiler/testData/diagnostics/tests/UninitializedOrReassignedVariables.jet

@@ -101,7 +101,7 @@ fun t5() {
     for (i in 0..2) {
         <!VAL_REASSIGNMENT!>i<!> += 1
         fun t5() {
-            <!VAL_REASSIGNMENT!>i<!> += 3
+            i += 3
         }
     }
 }
@@ -297,8 +297,8 @@ class TestObjectExpression() {
                 <!VAL_REASSIGNMENT!>a<!> = 231
             }
             fun inner2() {
-                <!VAL_REASSIGNMENT!>y<!> = 101
-                <!VAL_REASSIGNMENT!>a<!> = 231
+                y = 101
+                a = 231
             }
         }
     }

compiler/testData/diagnostics/tests/regressions/kt235.jet

@@ -12,8 +12,8 @@ fun main(args: Array<String>) {
        <!EXPECTED_TYPE_MISMATCH!>x += 2<!>  //no error, but it should be here
     }
     val <!UNUSED_VARIABLE!>h<!> = {(): String ->
-       var x = 1
-       <!EXPECTED_TYPE_MISMATCH!>x = 2<!>  //the same
+       var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>x<!> = 1
+       <!EXPECTED_TYPE_MISMATCH!>x = <!UNUSED_VALUE!>2<!><!>  //the same
     }
     val array1 = MyArray1()
     val <!UNUSED_VARIABLE!>i<!> = { (): String ->
@@ -46,4 +46,4 @@ class MyArray1() {
 
 class MyNumber() {
     fun inc(): MyNumber = MyNumber()
-}
+}

compiler/testData/diagnostics/tests/shadowing/ShadowParameterInNestedBlockInFor.jet

@@ -1,7 +1,7 @@
 fun f(<!UNUSED_PARAMETER!>i<!>: Int) {
     for (j in 1..100) {
         <!UNUSED_FUNCTION_LITERAL!>{
-            var <!NAME_SHADOWING!>i<!> = 12
+            var <!NAME_SHADOWING, UNUSED_VARIABLE!>i<!> = 12
         }<!>
     }
-}
+}

compiler/testData/diagnostics/tests/shadowing/ShadowVariableInNestedBlock.jet

@@ -1,7 +1,7 @@
 fun ff(): Int {
     var i = 1
     <!UNUSED_FUNCTION_LITERAL!>{
-        val <!NAME_SHADOWING!>i<!> = 2
+        val <!NAME_SHADOWING, UNUSED_VARIABLE!>i<!> = 2
     }<!>
     return i
-}
+}

compiler/testData/diagnostics/tests/shadowing/ShadowVariableInNestedClosure.jet

@@ -1,5 +1,5 @@
 fun f(): Int {
     var i = 17
-    <!UNUSED_FUNCTION_LITERAL!>{ (): Unit -> var <!NAME_SHADOWING!>i<!> = 18 }<!>
+    <!UNUSED_FUNCTION_LITERAL!>{ (): Unit -> var <!NAME_SHADOWING, UNUSED_VARIABLE!>i<!> = 18 }<!>
     return i
-}
+}

idea/testData/checker/StringTemplates.jet

@@ -3,8 +3,8 @@ fun demo() {
   val a = ""
   val asd = 1
   val bar = 5
-  fun map(f : () -> Any?) : Int  = 1
-  fun buzz(f : () -> Any?) : Int  = 1
+  fun map(<warning>f</warning> : () -> Any?) : Int  = 1
+  fun buzz(<warning>f</warning> : () -> Any?) : Int  = 1
   val sdf = 1
   val foo = 3;
     use("$abc")