Parcelize: Fix diagnostics for parcelable value classes

This commit is contained in:
Steven Schäfer
2021-08-30 21:02:32 +02:00
committed by Alexander Udalov
parent 153ca8675f
commit b2e6e075ab
4 changed files with 50 additions and 2 deletions
@@ -16,6 +16,7 @@ import org.jetbrains.kotlin.descriptors.SimpleFunctionDescriptor
import org.jetbrains.kotlin.descriptors.annotations.Annotations
import org.jetbrains.kotlin.diagnostics.DiagnosticSink
import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.load.kotlin.TypeMappingMode
import org.jetbrains.kotlin.name.FqName
import org.jetbrains.kotlin.parcelize.diagnostic.ErrorsParcelize
import org.jetbrains.kotlin.parcelize.serializers.ParcelSerializer
@@ -234,13 +235,13 @@ open class ParcelizeDeclarationChecker : DeclarationChecker {
val type = descriptor.type
if (!type.isError && !containerClass.hasCustomParceler()) {
val asmType = typeMapper.mapType(type)
val asmType = typeMapper.mapType(type, mode = TypeMappingMode.CLASS_DECLARATION)
try {
val parcelers = getTypeParcelers(descriptor.annotations) + getTypeParcelers(containerClass.annotations)
val context = ParcelSerializer.ParcelSerializerContext(
typeMapper,
typeMapper.mapType(containerClass.defaultType),
typeMapper.mapClass(containerClass),
parcelers,
FrameMap()
)
@@ -0,0 +1,37 @@
// WITH_RUNTIME
// See: https://issuetracker.google.com/197890119
// IGNORE_BACKEND: JVM
@file:JvmName("TestKt")
package test
import kotlinx.parcelize.*
import android.os.Parcel
import android.os.Parcelable
@Parcelize
@JvmInline
value class ListWrapper(val list: List<String>) : Parcelable
@Parcelize
data class Wrapper(val listWrapper: ListWrapper) : Parcelable
@Parcelize
data class NullableWrapper(val listWrapper: ListWrapper?) : Parcelable
fun box() = parcelTest { parcel ->
val data = Wrapper(ListWrapper(listOf("O", "K")))
val none = NullableWrapper(null)
data.writeToParcel(parcel, 0)
none.writeToParcel(parcel, 0)
val bytes = parcel.marshall()
parcel.unmarshall(bytes, 0, bytes.size)
parcel.setDataPosition(0)
val data2 = readFromParcel<Wrapper>(parcel)
assert(data2 == data)
val none2 = readFromParcel<NullableWrapper>(parcel)
assert(none2 == none)
}
@@ -370,6 +370,11 @@ public class ParcelizeBoxTestGenerated extends AbstractParcelizeBoxTest {
runTest("plugins/parcelize/parcelize-compiler/testData/box/typeParameters.kt");
}
@TestMetadata("valueClassWrapper.kt")
public void testValueClassWrapper() throws Exception {
runTest("plugins/parcelize/parcelize-compiler/testData/box/valueClassWrapper.kt");
}
@TestMetadata("valueClasses.kt")
public void testValueClasses() throws Exception {
runTest("plugins/parcelize/parcelize-compiler/testData/box/valueClasses.kt");
@@ -370,6 +370,11 @@ public class ParcelizeIrBoxTestGenerated extends AbstractParcelizeIrBoxTest {
runTest("plugins/parcelize/parcelize-compiler/testData/box/typeParameters.kt");
}
@TestMetadata("valueClassWrapper.kt")
public void testValueClassWrapper() throws Exception {
runTest("plugins/parcelize/parcelize-compiler/testData/box/valueClassWrapper.kt");
}
@TestMetadata("valueClasses.kt")
public void testValueClasses() throws Exception {
runTest("plugins/parcelize/parcelize-compiler/testData/box/valueClasses.kt");