Do not ever run JVM test handlers after previous errors
If there's a frontend error in a test, or bytecode generation crashed with an exception, it makes no sense to run JVM test handlers such as lambda inlining checker or D8 checker.
This commit is contained in:
+1
-2
@@ -13,12 +13,11 @@ import org.jetbrains.kotlin.test.services.TestServices
|
||||
abstract class JvmBinaryArtifactHandler(
|
||||
testServices: TestServices,
|
||||
failureDisablesNextSteps: Boolean = false,
|
||||
doNotRunIfThereWerePreviousFailures: Boolean = false
|
||||
) : BinaryArtifactHandler<BinaryArtifacts.Jvm>(
|
||||
testServices,
|
||||
ArtifactKinds.Jvm,
|
||||
failureDisablesNextSteps,
|
||||
doNotRunIfThereWerePreviousFailures
|
||||
doNotRunIfThereWerePreviousFailures = true,
|
||||
)
|
||||
|
||||
abstract class JsBinaryArtifactHandler(
|
||||
|
||||
+1
-1
@@ -14,7 +14,7 @@ import org.jetbrains.kotlin.test.model.BinaryArtifacts
|
||||
import org.jetbrains.kotlin.test.model.TestModule
|
||||
import org.jetbrains.kotlin.test.services.TestServices
|
||||
|
||||
class DxCheckerHandler(testServices: TestServices) : JvmBinaryArtifactHandler(testServices, doNotRunIfThereWerePreviousFailures = true) {
|
||||
class DxCheckerHandler(testServices: TestServices) : JvmBinaryArtifactHandler(testServices) {
|
||||
override val directivesContainers: List<DirectivesContainer>
|
||||
get() = listOf(CodegenTestDirectives)
|
||||
|
||||
|
||||
+1
-1
@@ -28,7 +28,7 @@ import java.lang.reflect.Method
|
||||
import java.net.URL
|
||||
import java.net.URLClassLoader
|
||||
|
||||
class JvmBoxRunner(testServices: TestServices) : JvmBinaryArtifactHandler(testServices, doNotRunIfThereWerePreviousFailures = true) {
|
||||
class JvmBoxRunner(testServices: TestServices) : JvmBinaryArtifactHandler(testServices) {
|
||||
companion object {
|
||||
private val BOX_IN_SEPARATE_PROCESS_PORT = System.getProperty("kotlin.test.box.in.separate.process.port")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user