adapt move refactoring to new behavior of KtFile.getClasses()

This commit is contained in:
Dmitry Jemerov
2016-01-13 20:25:32 +01:00
parent 1bc4420734
commit af66af07a0
3 changed files with 54 additions and 2 deletions
+3
View File
@@ -336,6 +336,9 @@
<refactoring.moveDirectoryWithClassesHelper
implementation="org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.KotlinMoveDirectoryWithClassesHelper"
order="first" />
<refactoring.moveClassHandler
implementation="org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinClassHandler"
order="first"/>
<refactoring.moveInnerClassUsagesHandler
implementationClass="org.jetbrains.kotlin.idea.refactoring.move.MoveJavaInnerClassKotlinUsagesHandler"
language="kotlin" />
@@ -0,0 +1,46 @@
/*
* Copyright 2010-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories
import com.intellij.psi.PsiClass
import com.intellij.psi.PsiDirectory
import com.intellij.refactoring.move.moveClassesOrPackages.MoveClassHandler
import com.intellij.refactoring.util.MoveRenameUsageInfo
import com.intellij.usageView.UsageInfo
import org.jetbrains.kotlin.asJava.KtLightClass
class MoveKotlinClassHandler : MoveClassHandler {
override fun doMoveClass(aClass: PsiClass, moveDestination: PsiDirectory): PsiClass? = null
override fun getName(clazz: PsiClass?): String? = null
/**
* Ensure that Kotlin classes are not processed twice when moving Kotlin files
* (once through the Java move handler calling KtFile.getClasses() and another time through the Kotlin move handler)
*/
override fun preprocessUsages(results: MutableCollection<UsageInfo>) {
results.removeAll { usageInfo ->
usageInfo is MoveRenameUsageInfo && usageInfo.referencedElement is KtLightClass
}
}
override fun prepareMove(aClass: PsiClass) {
}
override fun finishMoveClass(aClass: PsiClass) {
}
}
@@ -47,10 +47,11 @@ import org.jetbrains.kotlin.idea.codeInsight.KotlinFileReferencesResolver
import org.jetbrains.kotlin.idea.codeInsight.shorten.addToShorteningWaitSet
import org.jetbrains.kotlin.idea.core.deleteSingle
import org.jetbrains.kotlin.idea.core.getPackage
import org.jetbrains.kotlin.idea.refactoring.getUsageContext
import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringBundle
import org.jetbrains.kotlin.idea.refactoring.fqName.getKotlinFqName
import org.jetbrains.kotlin.idea.refactoring.getUsageContext
import org.jetbrains.kotlin.idea.refactoring.move.*
import org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinClassHandler
import org.jetbrains.kotlin.idea.references.KtSimpleNameReference.ShorteningMode
import org.jetbrains.kotlin.idea.search.projectScope
import org.jetbrains.kotlin.psi.KtFile
@@ -139,7 +140,9 @@ class MoveKotlinTopLevelDeclarationsProcessor(
)
}
MoveClassHandler.EP_NAME.extensions.forEach { handler -> handler.preprocessUsages(results) }
MoveClassHandler.EP_NAME.extensions.forEach { handler ->
if (handler !is MoveKotlinClassHandler) handler.preprocessUsages(results)
}
results
}