KT-14341 for to stdlib to forEach: if the loop variable is not used in the last/innerest statement the conversion is not proposed

#KT-14341 Fixed

idea/src/org/jetbrains/kotlin/idea/intentions/loopToCallChain/result/ForEachTransformation.kt

@@ -49,6 +49,9 @@ class ForEachTransformation(
         override val indexVariableAllowed: Boolean
             get() = true
 
+        override val shouldUseInputVariables: Boolean
+            get() = false
+
         override fun match(state: MatchingState): TransformationMatch.Result? {
             if (state.previousTransformations.isEmpty()) return null // do not suggest conversion to just ".forEach{}" or ".forEachIndexed{}"
 

idea/testData/intentions/loopToCallChain/count/long.kt

@@ -1,6 +1,6 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
-// IS_APPLICABLE_2: false
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
 fun foo(list: List<String>): Long {
     var count = 0L
     <caret>for (s in list) {

idea/testData/intentions/loopToCallChain/count/long.kt.after

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>): Long {
+    var count = 0L
+    list
+            .filter { it.length > 10 }
+            .forEach { count++ }
+    return count
+}

idea/testData/intentions/loopToCallChain/count/long.kt.after2

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>): Long {
+    var count = 0L
+    list
+            .asSequence()
+            .filter { it.length > 10 }
+            .forEach { count++ }
+    return count
+}

idea/testData/intentions/loopToCallChain/count/variableUsedBefore.kt

@@ -1,6 +1,6 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
-// IS_APPLICABLE_2: false
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
 fun foo(list: List<String>): Int {
     var count = 0
     <caret>for (s in list) {

idea/testData/intentions/loopToCallChain/count/variableUsedBefore.kt.after

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>): Int {
+    var count = 0
+    list
+            .filter { it.length > count }
+            .forEach { count++ }
+    return count
+}

idea/testData/intentions/loopToCallChain/count/variableUsedBefore.kt.after2

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>): Int {
+    var count = 0
+    list
+            .asSequence()
+            .filter { it.length > count }
+            .forEach { count++ }
+    return count
+}

idea/testData/intentions/loopToCallChain/forEach/KT14341.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<Int>){
+    <caret>for (any in list) {
+        if (any > 0)
+            println("positive number")
+    }
+}

idea/testData/intentions/loopToCallChain/forEach/KT14341.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<Int>){
+    list
+            .filter { it > 0 }
+            .forEach { println("positive number") }
+}

idea/testData/intentions/loopToCallChain/forEach/KT14341.kt.after2

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<Int>){
+    list
+            .asSequence()
+            .filter { it > 0 }
+            .forEach { println("positive number") }
+}

idea/testData/intentions/loopToCallChain/map/mapTo_inputVarNotUsed.kt

@@ -1,6 +1,6 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
-// IS_APPLICABLE_2: false
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
 fun foo(list: List<String>, target: MutableList<Int>) {
     <caret>for (s in list) {
         if (s.length > 0)

idea/testData/intentions/loopToCallChain/map/mapTo_inputVarNotUsed.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>, target: MutableList<Int>) {
+    list
+            .filter { it.length > 0 }
+            .forEach { target.add(0) }
+}

idea/testData/intentions/loopToCallChain/map/mapTo_inputVarNotUsed.kt.after2

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// INTENTION_TEXT: "Replace with 'filter{}.forEach{}'"
+// INTENTION_TEXT_2: "Replace with 'asSequence().filter{}.forEach{}'"
+fun foo(list: List<String>, target: MutableList<Int>) {
+    list
+            .asSequence()
+            .filter { it.length > 0 }
+            .forEach { target.add(0) }
+}

idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTest2Generated.java

@@ -781,6 +781,12 @@ public class IntentionTest2Generated extends AbstractIntentionTest2 {
             doTest(fileName);
         }
 
+        @TestMetadata("KT14341.kt")
+        public void testKT14341() throws Exception {
+            String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/loopToCallChain/forEach/KT14341.kt");
+            doTest(fileName);
+        }
+
         @TestMetadata("notAvailable.kt")
         public void testNotAvailable() throws Exception {
             String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/loopToCallChain/forEach/notAvailable.kt");

idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTestGenerated.java

@@ -8689,6 +8689,12 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
                 doTest(fileName);
             }
 
+            @TestMetadata("KT14341.kt")
+            public void testKT14341() throws Exception {
+                String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/loopToCallChain/forEach/KT14341.kt");
+                doTest(fileName);
+            }
+
             @TestMetadata("notAvailable.kt")
             public void testNotAvailable() throws Exception {
                 String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/loopToCallChain/forEach/notAvailable.kt");