azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[minor][FIR][checkers][Wasm] Refactor FirWasmJsInteropTypesChecker for readability

Browse Source
This commit is contained in:
Stanislav Ruban
2024-03-11 00:01:16 +02:00
committed by Space Team
parent 4dd0a25eca
commit a7332a4cad
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/checkers/checkers.wasm/src/org/jetbrains/kotlin/fir/analysis/wasm/checkers/declaration/FirWasmJsInteropTypesChecker.kt
+14 -11
View File
@@ -26,22 +26,25 @@ object FirWasmJsInteropTypesChecker : FirBasicDeclarationChecker(MppCheckerKind.
override fun check(declaration: FirDeclaration, context: CheckerContext, reporter: DiagnosticReporter) {
val session = context.session
fun isExternalJsInteropDeclaration() =
declaration.symbol.isEffectivelyExternal(session) &&
!declaration.annotations.hasAnnotation(WasmStandardClassIds.Annotations.WasmImport, session)
fun isExternalJsInteropDeclaration(): Boolean {
val isEffectivelyExternal = declaration.symbol.isEffectivelyExternal(session)
val hasWasmImportAnnotation = declaration.annotations.hasAnnotation(WasmStandardClassIds.Annotations.WasmImport, session)
return isEffectivelyExternal && !hasWasmImportAnnotation
}
fun isJsCodeDeclaration() =
(declaration is FirSimpleFunction && declaration.hasValidJsCodeBody()) ||
(declaration is FirProperty && declaration.hasValidJsCodeBody())
fun isJsCodeDeclaration(): Boolean {
return when (declaration) {
is FirSimpleFunction -> declaration.hasValidJsCodeBody()
is FirProperty -> declaration.hasValidJsCodeBody()
else -> false
}
}
fun isJsExportDeclaration() =
declaration is FirSimpleFunction && isJsExportedDeclaration(declaration, session)
// Interop type restriction rules apply uniformly to external, js("code"), and @JsExport declarations
// Interop type restriction rules apply uniformly to external, js("code"), and @JsExport declarations.
if (
!isExternalJsInteropDeclaration() &&
!isJsCodeDeclaration() &&
!isJsExportDeclaration()
!isJsExportedDeclaration(declaration, session)
) {
return
}