"field": deprecated warnings introduced, compiler tests migrated to the new syntax

compiler/testData/codegen/box/classes/propertyDelegation.kt

@@ -4,9 +4,9 @@ open class Base() {
       get() = 239
 
     public var readwrite : Int = 0
-      get() = $readwrite + 1
+      get() = field + 1
       set(n : Int) {
-        $readwrite = n
+        field = n
       }
 }
 

compiler/testData/codegen/box/intrinsics/prefixIncDec.kt

@@ -1,19 +1,19 @@
 public var inc: Int = 0;
 
 public var propInc: Int = 0
-    get() {++inc; return $propInc}
+    get() {++inc; return field}
     set(a: Int) {
         ++inc
-        $propInc = a
+        field = a
     }
 
 public var dec: Int = 0;
 
 public var propDec: Int = 0;
-    get() { --dec; return $propDec}
+    get() { --dec; return field}
     set(a: Int) {
         --dec
-        $propDec = a
+        field = a
     }
 
 fun box(): String {

compiler/testData/codegen/box/operatorConventions/incDecOnObject.kt

@@ -16,11 +16,11 @@ class Z {
 
     public var prop: X = X(0)
         get()  {
-            counter++; return $prop
+            counter++; return field
         }
         set(a: X) {
             counter++
-            $prop = a;
+            field = a;
         }
 }
 

compiler/testData/codegen/box/operatorConventions/kt4152.kt

@@ -1,19 +1,19 @@
 public var inc: Int = 0;
 
 public var propInc: Int = 0
-    get() {inc++; return $propInc}
+    get() {inc++; return field}
     set(a: Int) {
         inc++
-        $propInc = a
+        field = a
     }
 
 public var dec: Int = 0;
 
 public var propDec: Int = 0;
-    get() { dec--; return $propDec}
+    get() { dec--; return field}
     set(a: Int) {
         dec--
-        $propDec = a
+        field = a
     }
 
 fun box(): String {

compiler/testData/codegen/box/properties/accessToPrivateProperty.kt

@@ -33,7 +33,7 @@ class C {
 class D {
     private var foo = 1
         set(i: Int) {
-            $foo = i + 1
+            field = i + 1
         }
 
     fun foo() {

compiler/testData/codegen/box/properties/classObjectProperties.kt

@@ -9,7 +9,7 @@ class Test {
 
         public val prop3: Int = 12
             get() {
-                return  $prop3
+                return field
             }
 
         var prop4 : Int = 13
@@ -23,7 +23,7 @@ class Test {
 
         public var prop7 : Int = 20
             set(i: Int) {
-                $prop7++
+                field++
             }
     }
 

compiler/testData/codegen/box/properties/generalAccess.kt

@@ -24,8 +24,8 @@ open class A(val init: String) {
     }
 
     public var backingField : Int = 0
-        get() = $backingField.myInc
-        set(s) { $backingField = s }
+        get() = field.myInc
+        set(s) { field = s }
 
 }
 

compiler/testData/codegen/box/properties/kt4140.kt

@@ -2,7 +2,7 @@ class TestObject()
 {
     companion object {
         var prop: Int = 1
-            get() = $prop++
+            get() = field++
     }
 }
 

compiler/testData/codegen/box/staticFields/incInClassObject.kt

@@ -14,7 +14,7 @@ class A {
         var r2: Int = 1;
             get() {
                 holder += "getR2"
-                return $r2
+                return field
             }
 
         fun test2() : Int {
@@ -26,7 +26,7 @@ class A {
         var r3: Int = 1;
             set(p: Int) {
                 holder += "setR3"
-                $r3 = p
+                field = p
             }
 
         fun test3() : Int {
@@ -38,11 +38,11 @@ class A {
         var r4: Int = 1;
             get() {
                 holder += "getR4"
-                return $r4
+                return field
             }
             set(p: Int) {
                 holder += "setR4"
-                $r4 = p
+                field = p
             }
 
         fun test4() : Int {

compiler/testData/codegen/box/staticFields/incInObject.kt

@@ -12,7 +12,7 @@ object A {
     var r2: Int = 1;
         get() {
             holder += "getR2"
-            return $r2
+            return field
         }
 
     fun test2() : Int {
@@ -24,7 +24,7 @@ object A {
     var r3: Int = 1;
         set(p: Int) {
             holder += "setR3"
-            $r3 = p
+            field = p
         }
 
     fun test3() : Int {
@@ -36,11 +36,11 @@ object A {
     var r4: Int = 1;
         get() {
             holder += "getR4"
-            return $r4
+            return field
         }
         set(p: Int) {
             holder += "setR4"
-            $r4 = p
+            field = p
         }
 
     fun test4() : Int {

compiler/testData/codegen/boxWithStdlib/lazyCodegen/increment.kt

@@ -2,7 +2,7 @@ var holder = ""
 var globalA: A = A(-1)
     get(): A {
         holder += "getA"
-        return $globalA
+        return field
     }
 
 

compiler/testData/codegen/bytecodeText/kt2202.kt

@@ -10,7 +10,7 @@ class A {
 
 class B {
     var foo = 1
-        private set(value) { $foo = value }
+        private set(value) { field = value }
 
     fun foo() {
        foo = 2

compiler/testData/codegen/properties/fieldSetter.kt

@@ -1,5 +1,5 @@
 var collector: String = ""
-  set(it) { $collector = $collector + it }
+  set(it) { field = field + it }
 
 fun append(s: String): String {
   collector = s;

compiler/testData/codegen/properties/fieldSetterPlusEq.kt

@@ -1,5 +1,5 @@
 var collector: String = ""
-  set(it) { $collector += it }
+  set(it) { field += it }
 
 fun append(s: String): String {
   collector = s;

compiler/testData/codegen/topLevelMemberInvocation/propertyWithGetter/1.kt

@@ -2,7 +2,7 @@ package a
 
 val prop: Int = 0
     get() {
-        return $prop + 1
+        return field + 1
     }
 
 // 2 INVOKESTATIC a/_1Kt.getProp \(\)I