diff --git a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java index daf76bf6df6..0ee4cda1e5b 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java @@ -318,6 +318,9 @@ public interface Errors { DiagnosticFactory0 INAPPLICABLE_LATEINIT_MODIFIER = DiagnosticFactory0.create(ERROR); DiagnosticFactory0 BACKING_FIELD_IN_TRAIT = DiagnosticFactory0.create(ERROR, DECLARATION_SIGNATURE); + DiagnosticFactory0 BACKING_FIELD_SYNTAX_DEPRECATED = DiagnosticFactory0.create(WARNING); + DiagnosticFactory0 BACKING_FIELD_USAGE_DEPRECATED = DiagnosticFactory0.create(WARNING); + DiagnosticFactory2 ABSTRACT_PROPERTY_IN_NON_ABSTRACT_CLASS = DiagnosticFactory2.create(ERROR, ABSTRACT_MODIFIER); DiagnosticFactory0 VAL_WITH_SETTER = DiagnosticFactory0.create(ERROR); diff --git a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/DefaultErrorMessages.java b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/DefaultErrorMessages.java index 76c18ac410d..8fb471170d7 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/DefaultErrorMessages.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/DefaultErrorMessages.java @@ -157,6 +157,9 @@ public class DefaultErrorMessages { MAP.put(INACCESSIBLE_BACKING_FIELD, "The backing field is not accessible here"); MAP.put(NOT_PROPERTY_BACKING_FIELD, "The referenced variable is not a property and doesn't have backing field"); + MAP.put(BACKING_FIELD_SYNTAX_DEPRECATED, "This backing field syntax is deprecated, use 'field' instead"); + MAP.put(BACKING_FIELD_USAGE_DEPRECATED, "Backing field usage is deprecated here, soon it will be possible only in property accessors"); + MAP.put(MIXING_NAMED_AND_POSITIONED_ARGUMENTS, "Mixing named and positioned arguments is not allowed"); MAP.put(ARGUMENT_PASSED_TWICE, "An argument is already passed for this parameter"); MAP.put(NAMED_PARAMETER_NOT_FOUND, "Cannot find a parameter with this name: {0}", ELEMENT_TEXT); diff --git a/compiler/frontend/src/org/jetbrains/kotlin/resolve/BodyResolver.java b/compiler/frontend/src/org/jetbrains/kotlin/resolve/BodyResolver.java index d45ade2f5ea..24ae1159e22 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/resolve/BodyResolver.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/resolve/BodyResolver.java @@ -25,11 +25,9 @@ import kotlin.jvm.functions.Function1; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import org.jetbrains.kotlin.descriptors.*; -import org.jetbrains.kotlin.descriptors.annotations.Annotations; -import org.jetbrains.kotlin.descriptors.impl.LocalVariableDescriptor; import org.jetbrains.kotlin.descriptors.impl.SyntheticFieldDescriptor; +import org.jetbrains.kotlin.diagnostics.Errors; import org.jetbrains.kotlin.lexer.JetTokens; -import org.jetbrains.kotlin.name.Name; import org.jetbrains.kotlin.psi.*; import org.jetbrains.kotlin.psi.psiUtil.PsiUtilPackage; import org.jetbrains.kotlin.resolve.calls.CallResolver; @@ -41,7 +39,6 @@ import org.jetbrains.kotlin.resolve.calls.util.CallMaker; import org.jetbrains.kotlin.resolve.lazy.ForceResolveUtil; import org.jetbrains.kotlin.resolve.scopes.*; import org.jetbrains.kotlin.resolve.scopes.receivers.ReceiverValue; -import org.jetbrains.kotlin.resolve.source.KotlinSourceElementKt; import org.jetbrains.kotlin.types.*; import org.jetbrains.kotlin.types.expressions.ExpressionTypingContext; import org.jetbrains.kotlin.types.expressions.ExpressionTypingServices; @@ -55,7 +52,6 @@ import java.util.*; import static org.jetbrains.kotlin.diagnostics.Errors.*; import static org.jetbrains.kotlin.resolve.BindingContext.*; -import static org.jetbrains.kotlin.resolve.scopes.utils.UtilsPackage.asJetScope; import static org.jetbrains.kotlin.types.TypeUtils.NO_EXPECTED_TYPE; public class BodyResolver { @@ -652,6 +648,7 @@ public class BodyResolver { // This check may be considered redundant as long as $x is only accessible from accessors to $x if (descriptor == propertyDescriptor) { // TODO : original? trace.record(BindingContext.BACKING_FIELD_REQUIRED, propertyDescriptor); // TODO: this trace? + trace.report(Errors.BACKING_FIELD_SYNTAX_DEPRECATED.on(simpleNameExpression)); } } if (descriptor instanceof SyntheticFieldDescriptor) { diff --git a/compiler/testData/codegen/box/classes/propertyDelegation.kt b/compiler/testData/codegen/box/classes/propertyDelegation.kt index 5af5516c859..59720282936 100644 --- a/compiler/testData/codegen/box/classes/propertyDelegation.kt +++ b/compiler/testData/codegen/box/classes/propertyDelegation.kt @@ -4,9 +4,9 @@ open class Base() { get() = 239 public var readwrite : Int = 0 - get() = $readwrite + 1 + get() = field + 1 set(n : Int) { - $readwrite = n + field = n } } diff --git a/compiler/testData/codegen/box/intrinsics/prefixIncDec.kt b/compiler/testData/codegen/box/intrinsics/prefixIncDec.kt index 7ee85ce1319..612c91f3fa7 100644 --- a/compiler/testData/codegen/box/intrinsics/prefixIncDec.kt +++ b/compiler/testData/codegen/box/intrinsics/prefixIncDec.kt @@ -1,19 +1,19 @@ public var inc: Int = 0; public var propInc: Int = 0 - get() {++inc; return $propInc} + get() {++inc; return field} set(a: Int) { ++inc - $propInc = a + field = a } public var dec: Int = 0; public var propDec: Int = 0; - get() { --dec; return $propDec} + get() { --dec; return field} set(a: Int) { --dec - $propDec = a + field = a } fun box(): String { diff --git a/compiler/testData/codegen/box/operatorConventions/incDecOnObject.kt b/compiler/testData/codegen/box/operatorConventions/incDecOnObject.kt index db16fa3f081..edf45722301 100644 --- a/compiler/testData/codegen/box/operatorConventions/incDecOnObject.kt +++ b/compiler/testData/codegen/box/operatorConventions/incDecOnObject.kt @@ -16,11 +16,11 @@ class Z { public var prop: X = X(0) get() { - counter++; return $prop + counter++; return field } set(a: X) { counter++ - $prop = a; + field = a; } } diff --git a/compiler/testData/codegen/box/operatorConventions/kt4152.kt b/compiler/testData/codegen/box/operatorConventions/kt4152.kt index 4fcb8df0470..bc3ad4eada0 100644 --- a/compiler/testData/codegen/box/operatorConventions/kt4152.kt +++ b/compiler/testData/codegen/box/operatorConventions/kt4152.kt @@ -1,19 +1,19 @@ public var inc: Int = 0; public var propInc: Int = 0 - get() {inc++; return $propInc} + get() {inc++; return field} set(a: Int) { inc++ - $propInc = a + field = a } public var dec: Int = 0; public var propDec: Int = 0; - get() { dec--; return $propDec} + get() { dec--; return field} set(a: Int) { dec-- - $propDec = a + field = a } fun box(): String { diff --git a/compiler/testData/codegen/box/properties/accessToPrivateProperty.kt b/compiler/testData/codegen/box/properties/accessToPrivateProperty.kt index 7418ab956a4..b898fa5689e 100644 --- a/compiler/testData/codegen/box/properties/accessToPrivateProperty.kt +++ b/compiler/testData/codegen/box/properties/accessToPrivateProperty.kt @@ -33,7 +33,7 @@ class C { class D { private var foo = 1 set(i: Int) { - $foo = i + 1 + field = i + 1 } fun foo() { diff --git a/compiler/testData/codegen/box/properties/classObjectProperties.kt b/compiler/testData/codegen/box/properties/classObjectProperties.kt index 1f0c5ec7592..7c21029e7a2 100644 --- a/compiler/testData/codegen/box/properties/classObjectProperties.kt +++ b/compiler/testData/codegen/box/properties/classObjectProperties.kt @@ -9,7 +9,7 @@ class Test { public val prop3: Int = 12 get() { - return $prop3 + return field } var prop4 : Int = 13 @@ -23,7 +23,7 @@ class Test { public var prop7 : Int = 20 set(i: Int) { - $prop7++ + field++ } } diff --git a/compiler/testData/codegen/box/properties/generalAccess.kt b/compiler/testData/codegen/box/properties/generalAccess.kt index a69d3f1a358..cc35760d0eb 100644 --- a/compiler/testData/codegen/box/properties/generalAccess.kt +++ b/compiler/testData/codegen/box/properties/generalAccess.kt @@ -24,8 +24,8 @@ open class A(val init: String) { } public var backingField : Int = 0 - get() = $backingField.myInc - set(s) { $backingField = s } + get() = field.myInc + set(s) { field = s } } diff --git a/compiler/testData/codegen/box/properties/kt4140.kt b/compiler/testData/codegen/box/properties/kt4140.kt index 7345dd26c5a..55c964df5b8 100644 --- a/compiler/testData/codegen/box/properties/kt4140.kt +++ b/compiler/testData/codegen/box/properties/kt4140.kt @@ -2,7 +2,7 @@ class TestObject() { companion object { var prop: Int = 1 - get() = $prop++ + get() = field++ } } diff --git a/compiler/testData/codegen/box/staticFields/incInClassObject.kt b/compiler/testData/codegen/box/staticFields/incInClassObject.kt index 4053e9a631d..3c3935c72c4 100644 --- a/compiler/testData/codegen/box/staticFields/incInClassObject.kt +++ b/compiler/testData/codegen/box/staticFields/incInClassObject.kt @@ -14,7 +14,7 @@ class A { var r2: Int = 1; get() { holder += "getR2" - return $r2 + return field } fun test2() : Int { @@ -26,7 +26,7 @@ class A { var r3: Int = 1; set(p: Int) { holder += "setR3" - $r3 = p + field = p } fun test3() : Int { @@ -38,11 +38,11 @@ class A { var r4: Int = 1; get() { holder += "getR4" - return $r4 + return field } set(p: Int) { holder += "setR4" - $r4 = p + field = p } fun test4() : Int { diff --git a/compiler/testData/codegen/box/staticFields/incInObject.kt b/compiler/testData/codegen/box/staticFields/incInObject.kt index 126c377d05d..072f003e380 100644 --- a/compiler/testData/codegen/box/staticFields/incInObject.kt +++ b/compiler/testData/codegen/box/staticFields/incInObject.kt @@ -12,7 +12,7 @@ object A { var r2: Int = 1; get() { holder += "getR2" - return $r2 + return field } fun test2() : Int { @@ -24,7 +24,7 @@ object A { var r3: Int = 1; set(p: Int) { holder += "setR3" - $r3 = p + field = p } fun test3() : Int { @@ -36,11 +36,11 @@ object A { var r4: Int = 1; get() { holder += "getR4" - return $r4 + return field } set(p: Int) { holder += "setR4" - $r4 = p + field = p } fun test4() : Int { diff --git a/compiler/testData/codegen/boxWithStdlib/lazyCodegen/increment.kt b/compiler/testData/codegen/boxWithStdlib/lazyCodegen/increment.kt index cb92ba0a306..1d9a8d9cebb 100644 --- a/compiler/testData/codegen/boxWithStdlib/lazyCodegen/increment.kt +++ b/compiler/testData/codegen/boxWithStdlib/lazyCodegen/increment.kt @@ -2,7 +2,7 @@ var holder = "" var globalA: A = A(-1) get(): A { holder += "getA" - return $globalA + return field } diff --git a/compiler/testData/codegen/bytecodeText/kt2202.kt b/compiler/testData/codegen/bytecodeText/kt2202.kt index ca4a5d92cd7..c2eab1f2f56 100644 --- a/compiler/testData/codegen/bytecodeText/kt2202.kt +++ b/compiler/testData/codegen/bytecodeText/kt2202.kt @@ -10,7 +10,7 @@ class A { class B { var foo = 1 - private set(value) { $foo = value } + private set(value) { field = value } fun foo() { foo = 2 diff --git a/compiler/testData/codegen/properties/fieldSetter.kt b/compiler/testData/codegen/properties/fieldSetter.kt index 84ee1fc0290..2a6ec1d088a 100644 --- a/compiler/testData/codegen/properties/fieldSetter.kt +++ b/compiler/testData/codegen/properties/fieldSetter.kt @@ -1,5 +1,5 @@ var collector: String = "" - set(it) { $collector = $collector + it } + set(it) { field = field + it } fun append(s: String): String { collector = s; diff --git a/compiler/testData/codegen/properties/fieldSetterPlusEq.kt b/compiler/testData/codegen/properties/fieldSetterPlusEq.kt index 407adaf7f5e..6d717ce1919 100644 --- a/compiler/testData/codegen/properties/fieldSetterPlusEq.kt +++ b/compiler/testData/codegen/properties/fieldSetterPlusEq.kt @@ -1,5 +1,5 @@ var collector: String = "" - set(it) { $collector += it } + set(it) { field += it } fun append(s: String): String { collector = s; diff --git a/compiler/testData/codegen/topLevelMemberInvocation/propertyWithGetter/1.kt b/compiler/testData/codegen/topLevelMemberInvocation/propertyWithGetter/1.kt index 63b1a0b1bb9..ed87542953e 100644 --- a/compiler/testData/codegen/topLevelMemberInvocation/propertyWithGetter/1.kt +++ b/compiler/testData/codegen/topLevelMemberInvocation/propertyWithGetter/1.kt @@ -2,7 +2,7 @@ package a val prop: Int = 0 get() { - return $prop + 1 + return field + 1 } // 2 INVOKESTATIC a/_1Kt.getProp \(\)I diff --git a/compiler/testData/diagnostics/tests/Abstract.kt b/compiler/testData/diagnostics/tests/Abstract.kt index e62f77a36bc..0f4f167250b 100644 --- a/compiler/testData/diagnostics/tests/Abstract.kt +++ b/compiler/testData/diagnostics/tests/Abstract.kt @@ -11,10 +11,10 @@ package MyPackage abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/compiler/testData/diagnostics/tests/AbstractInAbstractClass.kt b/compiler/testData/diagnostics/tests/AbstractInAbstractClass.kt index 5c2b1e9135b..abd15fcb96f 100644 --- a/compiler/testData/diagnostics/tests/AbstractInAbstractClass.kt +++ b/compiler/testData/diagnostics/tests/AbstractInAbstractClass.kt @@ -12,10 +12,10 @@ abstract class MyAbstractClass() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/compiler/testData/diagnostics/tests/AbstractInClass.kt b/compiler/testData/diagnostics/tests/AbstractInClass.kt index 0084a0192d8..0399873e4c1 100644 --- a/compiler/testData/diagnostics/tests/AbstractInClass.kt +++ b/compiler/testData/diagnostics/tests/AbstractInClass.kt @@ -12,10 +12,10 @@ class MyClass() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/compiler/testData/diagnostics/tests/AbstractInTrait.kt b/compiler/testData/diagnostics/tests/AbstractInTrait.kt index 35e05fe559b..209dd1d71ff 100644 --- a/compiler/testData/diagnostics/tests/AbstractInTrait.kt +++ b/compiler/testData/diagnostics/tests/AbstractInTrait.kt @@ -12,10 +12,10 @@ interface MyTrait { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/compiler/testData/diagnostics/tests/LateInit.kt b/compiler/testData/diagnostics/tests/LateInit.kt index 158af3e8a0c..e90f468cfc5 100644 --- a/compiler/testData/diagnostics/tests/LateInit.kt +++ b/compiler/testData/diagnostics/tests/LateInit.kt @@ -32,7 +32,7 @@ public abstract class A(la get() = "A" lateinit var e9: String - set(v) { $e9 = v } + set(v) { field = v } abstract lateinit val e10: String diff --git a/compiler/testData/diagnostics/tests/Properties.kt b/compiler/testData/diagnostics/tests/Properties.kt index 4ad834fc20b..df78cbced28 100644 --- a/compiler/testData/diagnostics/tests/Properties.kt +++ b/compiler/testData/diagnostics/tests/Properties.kt @@ -1,8 +1,8 @@ var x : Int = 1 + x get() : Int = 1 set(value : Long) { - $x = value.toInt() - $x = 1.toLong() + field = value.toInt() + field = 1.toLong() } val xx : Int = 1 + x diff --git a/compiler/testData/diagnostics/tests/UnusedVariables.kt b/compiler/testData/diagnostics/tests/UnusedVariables.kt index 41d55c37268..1f13b8fafca 100644 --- a/compiler/testData/diagnostics/tests/UnusedVariables.kt +++ b/compiler/testData/diagnostics/tests/UnusedVariables.kt @@ -35,7 +35,7 @@ class MyTest() { var i: Int = 23 doSmth(i) i = 34 - $a = v + field = v } init { diff --git a/compiler/testData/diagnostics/tests/backingField/CustomGetSet.kt b/compiler/testData/diagnostics/tests/backingField/CustomGetSet.kt index 7536aa3339e..bf401362974 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomGetSet.kt +++ b/compiler/testData/diagnostics/tests/backingField/CustomGetSet.kt @@ -1,7 +1,11 @@ class Flower() { var minusOne: Int = 1 - get() = $minusOne + 1 - set(n: Int) { $minusOne = n - 1 } + get() = field + 1 + set(n: Int) { field = n - 1 } + + var oldSyntax: Int = 1 + get() = $oldSyntax - 1 + set(arg) { $oldSyntax = arg + 1 } } diff --git a/compiler/testData/diagnostics/tests/backingField/CustomGetSet.txt b/compiler/testData/diagnostics/tests/backingField/CustomGetSet.txt index f94d0152153..86a6c64010d 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomGetSet.txt +++ b/compiler/testData/diagnostics/tests/backingField/CustomGetSet.txt @@ -3,6 +3,7 @@ package public final class Flower { public constructor Flower() public final var minusOne: kotlin.Int + public final var oldSyntax: kotlin.Int public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String diff --git a/compiler/testData/diagnostics/tests/backingField/CustomGetVal.kt b/compiler/testData/diagnostics/tests/backingField/CustomGetVal.kt index f598fc264a0..383f29764d2 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomGetVal.kt +++ b/compiler/testData/diagnostics/tests/backingField/CustomGetVal.kt @@ -1,4 +1,4 @@ class CustomGetVal() { val zz = 1 - get() = $zz * 2 + get() = field * 2 } diff --git a/compiler/testData/diagnostics/tests/backingField/CustomGetValGlobal.kt b/compiler/testData/diagnostics/tests/backingField/CustomGetValGlobal.kt index aeda77c2dae..c76eab0e2c4 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomGetValGlobal.kt +++ b/compiler/testData/diagnostics/tests/backingField/CustomGetValGlobal.kt @@ -1,3 +1,3 @@ package customGetValGlobal val zz = 1 - get() = $zz * 2 + get() = field * 2 diff --git a/compiler/testData/diagnostics/tests/backingField/CustomGetVar.kt b/compiler/testData/diagnostics/tests/backingField/CustomGetVar.kt index 89eb1702848..62aebd10741 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomGetVar.kt +++ b/compiler/testData/diagnostics/tests/backingField/CustomGetVar.kt @@ -1,4 +1,4 @@ class Raise() { var zz = 1 - get() = $zz * 2 + get() = field * 2 } diff --git a/compiler/testData/diagnostics/tests/backingField/CustomSet.kt b/compiler/testData/diagnostics/tests/backingField/CustomSet.kt index 54e60a8d95d..e2319e7505a 100644 --- a/compiler/testData/diagnostics/tests/backingField/CustomSet.kt +++ b/compiler/testData/diagnostics/tests/backingField/CustomSet.kt @@ -1,4 +1,4 @@ class Raise() { var zz = 1 - set(it) { $zz = it / 2 } + set(it) { field = it / 2 } } diff --git a/compiler/testData/diagnostics/tests/backingField/kt462BackingFieldsResolve.kt b/compiler/testData/diagnostics/tests/backingField/kt462BackingFieldsResolve.kt index 817abdec5e1..6e1d68168d2 100644 --- a/compiler/testData/diagnostics/tests/backingField/kt462BackingFieldsResolve.kt +++ b/compiler/testData/diagnostics/tests/backingField/kt462BackingFieldsResolve.kt @@ -27,7 +27,7 @@ abstract class TestInitializationWithoutBackingField() { var varWithCustomSetter : Int set(v: Int) { - $varWithCustomSetter = v + field = v } init { varWithCustomSetter = 3 @@ -70,7 +70,7 @@ abstract class TestInitializationThroughBackingField() { var varWithCustomSetter : Int set(v: Int) { - $varWithCustomSetter = v + field = v } init { $varWithCustomSetter = 3 @@ -114,7 +114,7 @@ class TestBackingFieldsVisibility() { } abstract val w = 11 - get() = $w //test there is no second error here + get() = field //test there is no second error here } val topLevelVar = 11 @@ -141,10 +141,10 @@ class T() { get() { val o = object { init { - $x = 34 + field = 34 } fun foo() { - $x = 23 + field = 23 } } return 1 @@ -153,10 +153,10 @@ class T() { var r: Int = $x set(v: Int) { if (true) { - $r = 33 + field = 33 } else { - $r = 35 + field = 35 } } diff --git a/compiler/testData/diagnostics/tests/backingField/kt782packageLevel.kt b/compiler/testData/diagnostics/tests/backingField/kt782packageLevel.kt index 793897b9527..4bb2c9d40c7 100644 --- a/compiler/testData/diagnostics/tests/backingField/kt782packageLevel.kt +++ b/compiler/testData/diagnostics/tests/backingField/kt782packageLevel.kt @@ -6,7 +6,7 @@ val z : Int = 34 val y : Int = 11 get() { - return $y + return field } val x : Int diff --git a/compiler/testData/diagnostics/tests/controlFlowAnalysis/backingFieldInsideGetter.kt b/compiler/testData/diagnostics/tests/controlFlowAnalysis/backingFieldInsideGetter.kt index 201af14a34f..e37236bc0be 100644 --- a/compiler/testData/diagnostics/tests/controlFlowAnalysis/backingFieldInsideGetter.kt +++ b/compiler/testData/diagnostics/tests/controlFlowAnalysis/backingFieldInsideGetter.kt @@ -5,7 +5,7 @@ import java.util.HashSet val a: MutableSet? = null get() { if (a == null) { - $a = HashSet() + field = HashSet() } return a } @@ -14,7 +14,7 @@ class R { val b: String? = null get() { if (b == null) { - $b = "b" + field = "b" } return b } diff --git a/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt1571.kt b/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt1571.kt index 98702fa1591..3f76c0a8f0c 100644 --- a/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt1571.kt +++ b/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt1571.kt @@ -19,7 +19,7 @@ class A() { val a : A = A() get() { c0++ - return $a + return field } fun box() : String { diff --git a/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt2960.kt b/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt2960.kt index 11d89f6ac4c..f09f34d3411 100644 --- a/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt2960.kt +++ b/compiler/testData/diagnostics/tests/controlFlowAnalysis/kt2960.kt @@ -29,7 +29,7 @@ class A { get() { val x : Int doSmth(x) - return $a + return field } } diff --git a/compiler/testData/diagnostics/tests/enum/AbstractInEnum.kt b/compiler/testData/diagnostics/tests/enum/AbstractInEnum.kt index cc563364505..9e6df95b0db 100644 --- a/compiler/testData/diagnostics/tests/enum/AbstractInEnum.kt +++ b/compiler/testData/diagnostics/tests/enum/AbstractInEnum.kt @@ -14,10 +14,10 @@ enum class MyEnum() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/compiler/testData/diagnostics/tests/infos/PropertiesWithBackingFields.kt b/compiler/testData/diagnostics/tests/infos/PropertiesWithBackingFields.kt index 7a089a45588..c7d0fc5c0aa 100644 --- a/compiler/testData/diagnostics/tests/infos/PropertiesWithBackingFields.kt +++ b/compiler/testData/diagnostics/tests/infos/PropertiesWithBackingFields.kt @@ -16,7 +16,7 @@ abstract class Test() { val c4 : Int get() = 1 val c5 : Int - get() = $c5 + 1 + get() = field + 1 abstract var y : Int abstract var y1 : Int get @@ -32,8 +32,8 @@ abstract class Test() { var v3 : Int get() = 1; set var v4 : Int get() = 1; set(x){} - var v5 : Int get() = 1; set(x){$v5 = x} - var v6 : Int get() = $v6 + 1; set(x){} + var v5 : Int get() = 1; set(x){field = x} + var v6 : Int get() = field + 1; set(x){} abstract val v7 : Int get abstract var v8 : Int get set diff --git a/compiler/testData/diagnostics/tests/modifiers/IllegalModifiers.kt b/compiler/testData/diagnostics/tests/modifiers/IllegalModifiers.kt index 1cde36927a2..5f9b15c82c2 100644 --- a/compiler/testData/diagnostics/tests/modifiers/IllegalModifiers.kt +++ b/compiler/testData/diagnostics/tests/modifiers/IllegalModifiers.kt @@ -15,7 +15,7 @@ abstract class A() { class FinalClass() { open fun foo() {} val i: Int = 1 - open get(): Int = $i + open get(): Int = field var j: Int = 1 open set(v: Int) {} } diff --git a/compiler/testData/diagnostics/tests/regressions/kt251.kt b/compiler/testData/diagnostics/tests/regressions/kt251.kt index b5c930fc138..0f3ef696687 100644 --- a/compiler/testData/diagnostics/tests/regressions/kt251.kt +++ b/compiler/testData/diagnostics/tests/regressions/kt251.kt @@ -2,7 +2,7 @@ class A() { var x: Int = 0 get() = "s" set(value: String) { - $x = value + field = value } val y: Int get(): String = "s" @@ -13,7 +13,7 @@ class A() { var a: Any = 1 set(v: String) { - $a = v + field = v } val b: Int get(): Any = "s" @@ -23,11 +23,11 @@ class A() { } val d = 1 get() { - return $d + return field } val e = 1 get(): String { - return $e + return field } } diff --git a/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInClassStaticFields.kt b/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInClassStaticFields.kt index 848a8a5be19..a1c2907c90a 100644 --- a/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInClassStaticFields.kt +++ b/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInClassStaticFields.kt @@ -12,7 +12,7 @@ class Test { public val prop3: Int = 12 get() { - return $prop3 + return field } var prop4 : Int = 13 @@ -25,7 +25,7 @@ class Test { public var prop7 : Int = 20 set(i: Int) { - $prop7++ + field++ } } } \ No newline at end of file diff --git a/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInTraitStaticFields.kt b/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInTraitStaticFields.kt index 72e1cef42a9..862447b5961 100644 --- a/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInTraitStaticFields.kt +++ b/compiler/testData/loadJava/compiledKotlin/classObject/classObjectInTraitStaticFields.kt @@ -12,7 +12,7 @@ interface Test { public val prop3: Int = 12 get() { - return $prop3 + return field } var prop4 : Int = 13 @@ -25,7 +25,7 @@ interface Test { public var prop7 : Int = 20 set(i: Int) { - $prop7++ + field++ } } } \ No newline at end of file diff --git a/compiler/testData/writeFlags/property/classObject/class/publicValNonDefault.kt b/compiler/testData/writeFlags/property/classObject/class/publicValNonDefault.kt index 4d4326198d7..a80356683c0 100644 --- a/compiler/testData/writeFlags/property/classObject/class/publicValNonDefault.kt +++ b/compiler/testData/writeFlags/property/classObject/class/publicValNonDefault.kt @@ -2,7 +2,7 @@ class Test { companion object { public val prop: Int = 0 get() { - return $prop + return field } } } diff --git a/compiler/testData/writeFlags/property/classObject/class/publicVarNonDefault.kt b/compiler/testData/writeFlags/property/classObject/class/publicVarNonDefault.kt index 8b805854a9c..d24eea7a620 100644 --- a/compiler/testData/writeFlags/property/classObject/class/publicVarNonDefault.kt +++ b/compiler/testData/writeFlags/property/classObject/class/publicVarNonDefault.kt @@ -2,7 +2,7 @@ class Test { companion object { public var prop: Int = 0 set(i : Int) { - $prop = i + field = i } } } diff --git a/compiler/testData/writeFlags/property/classObject/trait/publicValNonDefault.kt b/compiler/testData/writeFlags/property/classObject/trait/publicValNonDefault.kt index bc69fec307b..8144a0c7864 100644 --- a/compiler/testData/writeFlags/property/classObject/trait/publicValNonDefault.kt +++ b/compiler/testData/writeFlags/property/classObject/trait/publicValNonDefault.kt @@ -2,7 +2,7 @@ interface Test { companion object { public val prop: Int = 0 get() { - return $prop + return field } } } diff --git a/compiler/testData/writeFlags/property/classObject/trait/publicVarNonDefault.kt b/compiler/testData/writeFlags/property/classObject/trait/publicVarNonDefault.kt index 64a46513fec..9d82c57e73b 100644 --- a/compiler/testData/writeFlags/property/classObject/trait/publicVarNonDefault.kt +++ b/compiler/testData/writeFlags/property/classObject/trait/publicVarNonDefault.kt @@ -2,7 +2,7 @@ interface Test { companion object { public var prop: Int = 0 set(i : Int) { - $prop = i + field = i } } } diff --git a/idea/testData/checker/Abstract.kt b/idea/testData/checker/Abstract.kt index 4c912bd703e..c6f05487255 100644 --- a/idea/testData/checker/Abstract.kt +++ b/idea/testData/checker/Abstract.kt @@ -13,10 +13,10 @@ class MyClass() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a @@ -44,10 +44,10 @@ abstract class MyAbstractClass() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a @@ -75,10 +75,10 @@ interface MyTrait { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a @@ -107,10 +107,10 @@ enum class MyEnum() { abstract var b2: Int private set abstract var b3: Int = 0; private set - var c: Int set(v: Int) { $c = v } - var c1: Int = 0; set(v: Int) { $c1 = v } - abstract var c2: Int set(v: Int) { $c2 = v } - abstract var c3: Int = 0; set(v: Int) { $c3 = v } + var c: Int set(v: Int) { field = v } + var c1: Int = 0; set(v: Int) { field = v } + abstract var c2: Int set(v: Int) { field = v } + abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a @@ -139,10 +139,10 @@ var b1: Int = 0; private set abstract var b2: Int private set abstract var b3: Int = 0; private set -var c: Int set(v: Int) { $c = v } -var c1: Int = 0; set(v: Int) { $c1 = v } -abstract var c2: Int set(v: Int) { $c2 = v } -abstract var c3: Int = 0; set(v: Int) { $c3 = v } +var c: Int set(v: Int) { field = v } +var c1: Int = 0; set(v: Int) { field = v } +abstract var c2: Int set(v: Int) { field = v } +abstract var c3: Int = 0; set(v: Int) { field = v } val e: Int get() = a val e1: Int = 0; get() = a diff --git a/idea/testData/checker/Properties.kt b/idea/testData/checker/Properties.kt index 684d62ada95..4ebc172be32 100644 --- a/idea/testData/checker/Properties.kt +++ b/idea/testData/checker/Properties.kt @@ -1,8 +1,8 @@ var x : Int = 1 + x get() : Int = 1 set(value : Long) { - $x = value.toInt() - $x = 1.toLong() + field = value.toInt() + field = 1.toLong() } val xx : Int = 1 + x @@ -14,15 +14,12 @@ class Test() { var a : Int = 111 - var b : Int get() = $a; set(x) {a = x; $a = x} + var b : Int get() = a; set(x) { a = x } init { - $b = $a - $a = $b - a = $b + } fun f() { - $b = $a - a = $b + } } diff --git a/idea/testData/checker/infos/PropertiesWithBackingFields.kt b/idea/testData/checker/infos/PropertiesWithBackingFields.kt index ea997261f10..1ad9eeeb530 100644 --- a/idea/testData/checker/infos/PropertiesWithBackingFields.kt +++ b/idea/testData/checker/infos/PropertiesWithBackingFields.kt @@ -16,7 +16,7 @@ val c4 : Int get() = 1 val c5 : Int - get() = $c5 + 1 + get() = field + 1 abstract var y : Int abstract var y1 : Int get @@ -32,8 +32,8 @@ var v3 : Int get() = 1; set var v4 : Int get() = 1; set(x){} - var v5 : Int get() = 1; set(x){$v5 = x} - var v6 : Int get() = $v6 + 1; set(x){} + var v5 : Int get() = 1; set(x){field = x} + var v6 : Int get() = field + 1; set(x){} var v9 : Int set var v10 : Int get diff --git a/idea/testData/checker/regression/kt251.kt b/idea/testData/checker/regression/kt251.kt index 5a7e562057c..bfe98b4099c 100644 --- a/idea/testData/checker/regression/kt251.kt +++ b/idea/testData/checker/regression/kt251.kt @@ -2,7 +2,7 @@ class A() { var x: Int = 0 get() = "s" set(value: String) { - $x = value + field = value } val y: Int get(): String = "s" @@ -13,7 +13,7 @@ class A() { var a: Any = 1 set(v: String) { - $a = v + field = v } val b: Int get(): Any = "s" @@ -23,11 +23,11 @@ class A() { } val d = 1 get() { - return $d + return field } val e = 1 get(): String { - return $e + return field } } \ No newline at end of file diff --git a/js/js.translator/testData/delegation/cases/delegationByInh.kt b/js/js.translator/testData/delegation/cases/delegationByInh.kt index 2a05374ba42..a1a2fd48703 100644 --- a/js/js.translator/testData/delegation/cases/delegationByInh.kt +++ b/js/js.translator/testData/delegation/cases/delegationByInh.kt @@ -15,7 +15,7 @@ trait Base2 : Base1 { class Base2Impl() : Base2 { override var prop: String = "" set(value) { - $prop = "prop:${value}" + field = "prop:${value}" } } diff --git a/js/js.translator/testData/delegation/cases/delegationChain.kt b/js/js.translator/testData/delegation/cases/delegationChain.kt index 7f53218117b..3122c18fcb4 100644 --- a/js/js.translator/testData/delegation/cases/delegationChain.kt +++ b/js/js.translator/testData/delegation/cases/delegationChain.kt @@ -9,7 +9,7 @@ class BaseImpl(val s: String) : Base { override fun foo(x: String) = "BaseImpl.foo: ${s}:${x}" override var prop: String = "init" set(value) { - $prop = "prop:${value}" + field = "prop:${value}" } } diff --git a/js/js.translator/testData/examples/cases/propertyDelegation.kt b/js/js.translator/testData/examples/cases/propertyDelegation.kt index f6486d64f30..8e3f239a957 100644 --- a/js/js.translator/testData/examples/cases/propertyDelegation.kt +++ b/js/js.translator/testData/examples/cases/propertyDelegation.kt @@ -4,9 +4,9 @@ open class Base() { get() = 239 public var readwrite: Int = 0 - get() = $readwrite + 1 + get() = field + 1 set(n: Int) { - $readwrite = n + field = n } } diff --git a/js/js.translator/testData/expression/misc/cases/KT-740-2.kt b/js/js.translator/testData/expression/misc/cases/KT-740-2.kt index ec5aa56dbab..555f4bef262 100644 --- a/js/js.translator/testData/expression/misc/cases/KT-740-2.kt +++ b/js/js.translator/testData/expression/misc/cases/KT-740-2.kt @@ -29,7 +29,7 @@ class A() { val a: A = A() get() { c0++ - return $a + return field } fun box(): String { diff --git a/js/js.translator/testData/expression/misc/cases/KT-740-3.kt b/js/js.translator/testData/expression/misc/cases/KT-740-3.kt index dc75251f6c7..ece0dec44bc 100644 --- a/js/js.translator/testData/expression/misc/cases/KT-740-3.kt +++ b/js/js.translator/testData/expression/misc/cases/KT-740-3.kt @@ -18,7 +18,7 @@ class A() { var a: A = A() get() { c0++ - return $a + return field } fun box(): String { diff --git a/js/js.translator/testData/operatorOverloading/cases/operatorOverloadOnPropertyCallGetterAndSetterOnlyOnce.kt b/js/js.translator/testData/operatorOverloading/cases/operatorOverloadOnPropertyCallGetterAndSetterOnlyOnce.kt index 21c816f3baa..e2472b45cf1 100644 --- a/js/js.translator/testData/operatorOverloading/cases/operatorOverloadOnPropertyCallGetterAndSetterOnlyOnce.kt +++ b/js/js.translator/testData/operatorOverloading/cases/operatorOverloadOnPropertyCallGetterAndSetterOnlyOnce.kt @@ -17,7 +17,7 @@ class A() { var b = MyInt(0) get() { gc = gc + 1; - return $b; + return field; } set(a: MyInt) { sc = sc + 1; diff --git a/js/js.translator/testData/propertyAccess/cases/backendField.kt b/js/js.translator/testData/propertyAccess/cases/backendField.kt index b8fe881b687..02140744966 100644 --- a/js/js.translator/testData/propertyAccess/cases/backendField.kt +++ b/js/js.translator/testData/propertyAccess/cases/backendField.kt @@ -2,7 +2,7 @@ package foo class A { val a: Int = 1 - get() = $a + 1 + get() = field + 1 fun getA(): Int { return $a diff --git a/js/js.translator/testData/propertyAccess/cases/customSetter.kt b/js/js.translator/testData/propertyAccess/cases/customSetter.kt index 4d7e5007522..2b8b5dbe710 100644 --- a/js/js.translator/testData/propertyAccess/cases/customSetter.kt +++ b/js/js.translator/testData/propertyAccess/cases/customSetter.kt @@ -3,7 +3,7 @@ package foo class Test() { var a: Int = 5 set(b: Int) { - $a = 3 + field = 3 } } diff --git a/js/js.translator/testData/propertyAccess/cases/initValInConstructor.kt b/js/js.translator/testData/propertyAccess/cases/initValInConstructor.kt index e6643d790ad..c1efc2b3f40 100644 --- a/js/js.translator/testData/propertyAccess/cases/initValInConstructor.kt +++ b/js/js.translator/testData/propertyAccess/cases/initValInConstructor.kt @@ -4,7 +4,7 @@ class A { val a: Int val aa: Int get() { - return $aa + return field } var aR = 0 @@ -22,7 +22,7 @@ class B { private val a: Int private val aa: Int get() { - return $aa + return field } var aR = 0 diff --git a/js/js.translator/testData/propertyOverride/cases/initOverrideInConstructorComplex.kt b/js/js.translator/testData/propertyOverride/cases/initOverrideInConstructorComplex.kt index 3a2a37ccbf0..b47bc9dcb98 100644 --- a/js/js.translator/testData/propertyOverride/cases/initOverrideInConstructorComplex.kt +++ b/js/js.translator/testData/propertyOverride/cases/initOverrideInConstructorComplex.kt @@ -8,7 +8,7 @@ trait Holder { open class BasicHolder : Holder { override val element: String - get() = $element + $element + get() = field + field init { element = "1" diff --git a/js/js.translator/testData/propertyOverride/cases/overloadPrivateVal.kt b/js/js.translator/testData/propertyOverride/cases/overloadPrivateVal.kt index 52179767ca2..0fcf11ddfa0 100644 --- a/js/js.translator/testData/propertyOverride/cases/overloadPrivateVal.kt +++ b/js/js.translator/testData/propertyOverride/cases/overloadPrivateVal.kt @@ -5,7 +5,7 @@ open class A { private val b = 2 get() { - return $b + 10 + 100 * a + return field + 10 + 100 * a } fun getBInA(): Int { return b diff --git a/js/js.translator/testData/propertyOverride/cases/overrideValFromTraits.kt b/js/js.translator/testData/propertyOverride/cases/overrideValFromTraits.kt index 6edcf2080f7..fb52c9e05d5 100644 --- a/js/js.translator/testData/propertyOverride/cases/overrideValFromTraits.kt +++ b/js/js.translator/testData/propertyOverride/cases/overrideValFromTraits.kt @@ -37,10 +37,10 @@ class C : A, B { override val bal: Int = 1 override var bar: Int = 2 get() { - return $bar + 20 + return field + 20 } set(value: Int) { - $bar = value + 20 + field = value + 20 } override var realBar: Int = 3 diff --git a/js/js.translator/testData/propertyOverride/cases/overrideValWithBackendFiled.kt b/js/js.translator/testData/propertyOverride/cases/overrideValWithBackendFiled.kt index 24d012f3438..e3a04c645dd 100644 --- a/js/js.translator/testData/propertyOverride/cases/overrideValWithBackendFiled.kt +++ b/js/js.translator/testData/propertyOverride/cases/overrideValWithBackendFiled.kt @@ -3,14 +3,14 @@ package foo open class A { open val a = 2 get() { - return $a + 1 + return field + 1 } } class B : A() { override val a: Int = 5 get() { - return super.a + 10 * $a + 100 + return super.a + 10 * field + 100 } } diff --git a/js/js.translator/testData/webDemoCanvasExamples/cases/Creatures.kt b/js/js.translator/testData/webDemoCanvasExamples/cases/Creatures.kt index ffaa13d89a5..a064befcb9e 100644 --- a/js/js.translator/testData/webDemoCanvasExamples/cases/Creatures.kt +++ b/js/js.translator/testData/webDemoCanvasExamples/cases/Creatures.kt @@ -100,10 +100,10 @@ class Logo(override var pos: Vector) : Shape() { val gradientGenerator: RadialGradientGenerator? = null get() { - if ($gradientGenerator == null) { - $gradientGenerator = RadialGradientGenerator(context) + if (field == null) { + field = RadialGradientGenerator(context) } - return $gradientGenerator + return field } class Creature(override var pos: Vector, val state: CanvasState) : Shape() {