Minor changes after code review
This commit is contained in:
+4
-1
@@ -175,7 +175,10 @@ class BasicLookupElementFactory(
|
|||||||
element = element.withPresentableText(DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderClassifierName(descriptor))
|
element = element.withPresentableText(DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderClassifierName(descriptor))
|
||||||
|
|
||||||
while (container is ClassDescriptor) {
|
while (container is ClassDescriptor) {
|
||||||
element = element.withLookupString(container.name.asString())
|
val containerName = container.name
|
||||||
|
if (!containerName.isSpecial) {
|
||||||
|
element = element.withLookupString(containerName.asString())
|
||||||
|
}
|
||||||
container = container.getContainingDeclaration()
|
container = container.getContainingDeclaration()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+6
-6
@@ -132,7 +132,7 @@ class LookupElementFactory(
|
|||||||
var parametersRenderer = DescriptorRenderer.SHORT_NAMES_IN_TYPES
|
var parametersRenderer = DescriptorRenderer.SHORT_NAMES_IN_TYPES
|
||||||
if (descriptor.valueParameters.size() > 1) {
|
if (descriptor.valueParameters.size() > 1) {
|
||||||
parametersRenderer = parametersRenderer.withOptions {
|
parametersRenderer = parametersRenderer.withOptions {
|
||||||
valueParametersHandler = object: DescriptorRenderer.ValueParametersHandler by DescriptorRenderer.ValueParametersHandler.DEFAULT {
|
valueParametersHandler = object: DescriptorRenderer.ValueParametersHandler by this.valueParametersHandler {
|
||||||
override fun appendBeforeValueParameter(parameter: ValueParameterDescriptor, parameterIndex: Int, parameterCount: Int, builder: StringBuilder) {
|
override fun appendBeforeValueParameter(parameter: ValueParameterDescriptor, parameterIndex: Int, parameterCount: Int, builder: StringBuilder) {
|
||||||
builder.append("..., ")
|
builder.append("..., ")
|
||||||
}
|
}
|
||||||
@@ -236,12 +236,12 @@ class LookupElementFactory(
|
|||||||
): LookupElement {
|
): LookupElement {
|
||||||
var element = basicFactory.createLookupElement(descriptor, qualifyNestedClasses, includeClassTypeArguments)
|
var element = basicFactory.createLookupElement(descriptor, qualifyNestedClasses, includeClassTypeArguments)
|
||||||
|
|
||||||
val weight = callableWeight(descriptor)
|
|
||||||
if (weight != null) {
|
|
||||||
element.putUserData(CALLABLE_WEIGHT_KEY, weight) // store for use in lookup elements sorting
|
|
||||||
}
|
|
||||||
|
|
||||||
if (useReceiverTypes) {
|
if (useReceiverTypes) {
|
||||||
|
val weight = callableWeight(descriptor)
|
||||||
|
if (weight != null) {
|
||||||
|
element.putUserData(CALLABLE_WEIGHT_KEY, weight) // store for use in lookup elements sorting
|
||||||
|
}
|
||||||
|
|
||||||
element = element.boldIfImmediate(weight)
|
element = element.boldIfImmediate(weight)
|
||||||
}
|
}
|
||||||
return element
|
return element
|
||||||
|
|||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
class JavaClass {
|
||||||
|
public class Nested{}
|
||||||
|
}
|
||||||
+13
@@ -0,0 +1,13 @@
|
|||||||
|
class KotlinClass {
|
||||||
|
class Nested
|
||||||
|
}
|
||||||
|
|
||||||
|
fun foo(o: Any) {
|
||||||
|
f(o as <caret>)
|
||||||
|
}
|
||||||
|
|
||||||
|
fun f(p: JavaClass.Nested){}
|
||||||
|
fun f(p: KotlinClass.Nested){}
|
||||||
|
|
||||||
|
// EXIST: { lookupString: "Nested", allLookupStrings: "JavaClass, Nested", itemText: "JavaClass.Nested", tailText: " (<root>)" }
|
||||||
|
// EXIST: { lookupString: "Nested", allLookupStrings: "KotlinClass, Nested", itemText: "KotlinClass.Nested", tailText: " (<root>)" }
|
||||||
+6
@@ -113,6 +113,12 @@ public class MultiFileSmartCompletionTestGenerated extends AbstractMultiFileSmar
|
|||||||
doTest(fileName);
|
doTest(fileName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@TestMetadata("NestedClassAfterAs")
|
||||||
|
public void testNestedClassAfterAs() throws Exception {
|
||||||
|
String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/smartMultiFile/NestedClassAfterAs/");
|
||||||
|
doTest(fileName);
|
||||||
|
}
|
||||||
|
|
||||||
@TestMetadata("NoObjectDuplication")
|
@TestMetadata("NoObjectDuplication")
|
||||||
public void testNoObjectDuplication() throws Exception {
|
public void testNoObjectDuplication() throws Exception {
|
||||||
String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/smartMultiFile/NoObjectDuplication/");
|
String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/smartMultiFile/NoObjectDuplication/");
|
||||||
|
|||||||
Reference in New Issue
Block a user