Minor changes after code review

This commit is contained in:
Valentin Kipyatkov
2015-08-28 15:47:20 +03:00
parent 02922f3f93
commit a012fd0c7d
5 changed files with 32 additions and 7 deletions
@@ -175,7 +175,10 @@ class BasicLookupElementFactory(
element = element.withPresentableText(DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderClassifierName(descriptor))
while (container is ClassDescriptor) {
element = element.withLookupString(container.name.asString())
val containerName = container.name
if (!containerName.isSpecial) {
element = element.withLookupString(containerName.asString())
}
container = container.getContainingDeclaration()
}
}
@@ -132,7 +132,7 @@ class LookupElementFactory(
var parametersRenderer = DescriptorRenderer.SHORT_NAMES_IN_TYPES
if (descriptor.valueParameters.size() > 1) {
parametersRenderer = parametersRenderer.withOptions {
valueParametersHandler = object: DescriptorRenderer.ValueParametersHandler by DescriptorRenderer.ValueParametersHandler.DEFAULT {
valueParametersHandler = object: DescriptorRenderer.ValueParametersHandler by this.valueParametersHandler {
override fun appendBeforeValueParameter(parameter: ValueParameterDescriptor, parameterIndex: Int, parameterCount: Int, builder: StringBuilder) {
builder.append("..., ")
}
@@ -236,12 +236,12 @@ class LookupElementFactory(
): LookupElement {
var element = basicFactory.createLookupElement(descriptor, qualifyNestedClasses, includeClassTypeArguments)
val weight = callableWeight(descriptor)
if (weight != null) {
element.putUserData(CALLABLE_WEIGHT_KEY, weight) // store for use in lookup elements sorting
}
if (useReceiverTypes) {
val weight = callableWeight(descriptor)
if (weight != null) {
element.putUserData(CALLABLE_WEIGHT_KEY, weight) // store for use in lookup elements sorting
}
element = element.boldIfImmediate(weight)
}
return element
@@ -0,0 +1,3 @@
class JavaClass {
public class Nested{}
}
@@ -0,0 +1,13 @@
class KotlinClass {
class Nested
}
fun foo(o: Any) {
f(o as <caret>)
}
fun f(p: JavaClass.Nested){}
fun f(p: KotlinClass.Nested){}
// EXIST: { lookupString: "Nested", allLookupStrings: "JavaClass, Nested", itemText: "JavaClass.Nested", tailText: " (<root>)" }
// EXIST: { lookupString: "Nested", allLookupStrings: "KotlinClass, Nested", itemText: "KotlinClass.Nested", tailText: " (<root>)" }
@@ -113,6 +113,12 @@ public class MultiFileSmartCompletionTestGenerated extends AbstractMultiFileSmar
doTest(fileName);
}
@TestMetadata("NestedClassAfterAs")
public void testNestedClassAfterAs() throws Exception {
String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/smartMultiFile/NestedClassAfterAs/");
doTest(fileName);
}
@TestMetadata("NoObjectDuplication")
public void testNoObjectDuplication() throws Exception {
String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/smartMultiFile/NoObjectDuplication/");