FirElementSerializer cleanup

Review: https://jetbrains.team/p/kt/reviews/13495/timeline
This commit is contained in:
Nikita Bobko
2023-12-12 18:11:43 +01:00
committed by teamcity
parent ea8f7af1f2
commit 9da29d46aa
@@ -411,27 +411,19 @@ class FirElementSerializer private constructor(
): List<T> {
val foundInScope = buildList {
val memberScope = unsubstitutedScope(session, scopeSession, withForcedTypeCalculator = false, memberRequiredPhase = null)
processScope(memberScope) l@{
processScope(memberScope) {
val declaration = it.fir as T
val dispatchReceiverLookupTag = declaration.dispatchReceiverClassLookupTagOrNull()
// Special case for data/value class equals/hashCode/toString, see KT-57510
val isOverrideOfAnyFunctionInDataOrValueClass = this@collectDeclarations is FirRegularClass &&
val isFakeOverrideOfAnyFunctionInDataOrValueClass = this@collectDeclarations is FirRegularClass &&
(this@collectDeclarations.isData || this@collectDeclarations.isInline) &&
dispatchReceiverLookupTag?.classId == StandardClassIds.Any && !declaration.isFinal
if (declaration.isSubstitutionOrIntersectionOverride) {
if (!isOverrideOfAnyFunctionInDataOrValueClass) {
return@l
}
} else if (!(declaration.isStatic || declaration is FirConstructor)) {
// non-intersection or substitution fake override
if (dispatchReceiverLookupTag != this@collectDeclarations.symbol.toLookupTag()) {
if (!isOverrideOfAnyFunctionInDataOrValueClass) {
return@l
}
}
if (isFakeOverrideOfAnyFunctionInDataOrValueClass ||
!declaration.isSubstitutionOrIntersectionOverride &&
(declaration.isStatic || declaration is FirConstructor || dispatchReceiverLookupTag == this@collectDeclarations.symbol.toLookupTag())
) {
add(declaration)
}
add(declaration)
}
for (declaration in declarations) {