Minor in JS frontend: join isTopLevel and hasLocalVisibility into isMember and simplify condition.

This commit is contained in:
Zalim Bashorov
2014-12-01 15:57:06 +03:00
parent 4ed635b4a7
commit 990415b69f
@@ -48,13 +48,11 @@ private abstract class AbstractNativeAnnotationsChecker(private val requiredAnno
return
}
val isTopLevel = DescriptorUtils.isTopLevelDeclaration(descriptor)
val hasLocalVisibility = descriptor.getVisibility() == Visibilities.LOCAL
val isMember = !DescriptorUtils.isTopLevelDeclaration(descriptor) && descriptor.getVisibility() != Visibilities.LOCAL
val isExtension = DescriptorUtils.isExtension(descriptor)
if (!isTopLevel && !hasLocalVisibility && isExtension ||
(isTopLevel || hasLocalVisibility) && !isExtension ||
!((isTopLevel || hasLocalVisibility) && isExtension) && !AnnotationsUtils.isNativeObject(descriptor)
if (isMember && (isExtension || !AnnotationsUtils.isNativeObject(descriptor)) ||
!isMember && !isExtension
) {
diagnosticHolder.report(ErrorsJs.NATIVE_ANNOTATIONS_ALLOWED_ONLY_ON_MEMBER_OR_EXTENSION_FUN.on(declaration, annotationDescriptor.getType()))
}