azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR JS] Fix false positive NON_ABSTRACT_FUNCTION_WITH_NO_BODY

Browse Source
This commit is contained in:
Nikolay Lunyak
2022-01-21 12:06:20 +03:00
committed by teamcity
parent eaa77b5af6
commit 91fa7dec88
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirMemberFunctionsChecker.kt
+2 -1
View File
@@ -56,6 +56,7 @@ object FirMemberFunctionsChecker : FirSimpleFunctionChecker() {
}
}
val isInsideExpectClass = isInsideExpectClass(containingDeclaration, context)
val isInsideExternal = isInsideExternalClass(containingDeclaration, context)
val hasOpenModifier = KtTokens.OPEN_KEYWORD in modifierList
if (!function.hasBody) {
if (containingDeclaration.isInterface) {
@@ -65,7 +66,7 @@ object FirMemberFunctionsChecker : FirSimpleFunctionChecker() {
if (!isInsideExpectClass && !hasAbstractModifier && hasOpenModifier) {
reporter.reportOn(source, FirErrors.REDUNDANT_OPEN_IN_INTERFACE, context)
}
} else if (!isInsideExpectClass && !hasAbstractModifier && !function.isExternal) {
} else if (!isInsideExpectClass && !hasAbstractModifier && !function.isExternal && !isInsideExternal) {
reporter.reportOn(source, FirErrors.NON_ABSTRACT_FUNCTION_WITH_NO_BODY, functionSymbol, context)
}
}