[FIR] Report illegal in/out modifier on star projection

#KT-55668 Fixed

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/CommonTypeCheckers.kt

@@ -17,5 +17,6 @@ object CommonTypeCheckers : TypeCheckers() {
         FirDefinitelyNotNullableChecker,
         FirUnsupportedDefaultValueInFunctionTypeParameterChecker,
         FirUnsupportedModifiersInFunctionTypeParameterChecker,
+        FirStarProjectionModifierChecker,
     )
 }

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/type/FirStarProjectionModifierChecker.kt

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.fir.analysis.checkers.type
+
+import org.jetbrains.kotlin.KtRealSourceElementKind
+import org.jetbrains.kotlin.descriptors.annotations.KotlinTarget
+import org.jetbrains.kotlin.diagnostics.DiagnosticReporter
+import org.jetbrains.kotlin.diagnostics.reportOn
+import org.jetbrains.kotlin.fir.analysis.checkers.context.CheckerContext
+import org.jetbrains.kotlin.fir.analysis.checkers.getModifierList
+import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors
+import org.jetbrains.kotlin.fir.types.*
+
+object FirStarProjectionModifierChecker : FirTypeRefChecker() {
+    override fun check(typeRef: FirTypeRef, context: CheckerContext, reporter: DiagnosticReporter) {
+        if (typeRef !is FirResolvedTypeRef) return
+
+        val delegatedTypeRef = typeRef.delegatedTypeRef as? FirUserTypeRef ?: return
+        for (part in delegatedTypeRef.qualifier) {
+            for (typeArgument in part.typeArgumentList.typeArguments) {
+                if (typeArgument !is FirStarProjection) continue
+                val source = typeArgument.source?.takeIf { it.kind is KtRealSourceElementKind } ?: continue
+                val modifierList = source.getModifierList() ?: continue
+
+                for (modifier in modifierList.modifiers) {
+                    reporter.reportOn(
+                        modifier.source,
+                        FirErrors.WRONG_MODIFIER_TARGET,
+                        modifier.token,
+                        KotlinTarget.STAR_PROJECTION.description,
+                        context,
+                    )
+                }
+            }
+        }
+    }
+}

compiler/testData/diagnostics/testsWithStdLib/instar.fir.kt

@@ -1,11 +0,0 @@
-// Reproduces exception in TypeResolver.kt: EA-66870
-
-import java.util.ArrayList
-
-abstract class J {
-    public abstract fun <T : Collection<S>, S : List<in *>> foo(x: T)
-    fun bar() {
-        val s = ArrayList<ArrayList<Int>>()
-        foo(s)
-    }
-}

compiler/testData/diagnostics/testsWithStdLib/instar.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // Reproduces exception in TypeResolver.kt: EA-66870
 
 import java.util.ArrayList

compiler/testData/diagnostics/testsWithStdLib/outstar.fir.kt

@@ -1,11 +0,0 @@
-// Reproduces exception in TypeResolver.kt: EA-66870
-
-import java.util.ArrayList
-
-abstract class J {
-    public abstract fun <T : Collection<S>, S : List<out *>> foo(x: T)
-    fun bar() {
-        val s = ArrayList<ArrayList<Int>>()
-        foo(s)
-    }
-}

compiler/testData/diagnostics/testsWithStdLib/outstar.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // Reproduces exception in TypeResolver.kt: EA-66870
 
 import java.util.ArrayList