Removed MemberScope.getPackage

compiler/frontend/src/org/jetbrains/kotlin/resolve/AllUnderImportsScope.kt

@@ -23,17 +23,18 @@ import org.jetbrains.kotlin.incremental.components.LookupLocation
 import org.jetbrains.kotlin.name.Name
 import org.jetbrains.kotlin.resolve.scopes.BaseImportingScope
 import org.jetbrains.kotlin.resolve.scopes.DescriptorKindFilter
+import org.jetbrains.kotlin.resolve.scopes.ResolutionScope
 import org.jetbrains.kotlin.utils.Printer
 
 class AllUnderImportsScope(descriptor: DeclarationDescriptor) : BaseImportingScope(null) {
-    private val scopes = if (descriptor is ClassDescriptor) {
+    private val scopes: List<ResolutionScope> = if (descriptor is ClassDescriptor) {
         listOf(descriptor.staticScope, descriptor.unsubstitutedInnerClassesScope)
     }
     else {
         assert(descriptor is PackageViewDescriptor) {
             "Must be class or package view descriptor: $descriptor"
         }
-        listOf(NoSubpackagesInPackageScope(descriptor as PackageViewDescriptor))
+        listOf((descriptor as PackageViewDescriptor).memberScope)
     }
 
     override fun getContributedDescriptors(kindFilter: DescriptorKindFilter, nameFilter: (Name) -> Boolean)

compiler/frontend/src/org/jetbrains/kotlin/resolve/NoSubpackagesInPackageScope.kt

@@ -1,37 +0,0 @@
-/*
- * Copyright 2010-2015 JetBrains s.r.o.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.jetbrains.kotlin.resolve
-
-import org.jetbrains.kotlin.descriptors.PackageViewDescriptor
-import org.jetbrains.kotlin.name.Name
-import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
-import org.jetbrains.kotlin.resolve.scopes.DescriptorKindFilter
-import org.jetbrains.kotlin.resolve.scopes.AbstractScopeAdapter
-import org.jetbrains.kotlin.resolve.scopes.MemberScope
-
-class NoSubpackagesInPackageScope(packageDescriptor: PackageViewDescriptor) : AbstractScopeAdapter() {
-    override val workerScope: MemberScope = packageDescriptor.memberScope
-
-    override fun getPackage(name: Name): PackageViewDescriptor? = null
-
-    override fun getContributedDescriptors(kindFilter: DescriptorKindFilter, nameFilter: (Name) -> Boolean): Collection<DeclarationDescriptor> {
-        val modifiedFilter = kindFilter.withoutKinds(DescriptorKindFilter.PACKAGES_MASK)
-        if (modifiedFilter.kindMask == 0) return listOf()
-        return workerScope.getContributedDescriptors(modifiedFilter, nameFilter).filter { it !is PackageViewDescriptor }
-    }
-
-}

compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/FileScopeProviderImpl.kt

@@ -17,18 +17,17 @@
 package org.jetbrains.kotlin.resolve.lazy
 
 import org.jetbrains.kotlin.descriptors.ModuleDescriptor
-import org.jetbrains.kotlin.descriptors.impl.SubpackagesScope
 import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.psi.KtFile
 import org.jetbrains.kotlin.psi.KtImportDirective
 import org.jetbrains.kotlin.psi.KtImportsFactory
 import org.jetbrains.kotlin.resolve.BindingTrace
-import org.jetbrains.kotlin.resolve.NoSubpackagesInPackageScope
 import org.jetbrains.kotlin.resolve.QualifiedExpressionResolver
 import org.jetbrains.kotlin.resolve.TemporaryBindingTrace
 import org.jetbrains.kotlin.resolve.bindingContextUtil.recordScope
 import org.jetbrains.kotlin.resolve.scopes.ImportingScope
 import org.jetbrains.kotlin.resolve.scopes.LexicalScope
+import org.jetbrains.kotlin.resolve.scopes.SubpackagesImportingScope
 import org.jetbrains.kotlin.resolve.scopes.utils.memberScopeAsImportingScope
 import org.jetbrains.kotlin.resolve.scopes.utils.withParent
 import org.jetbrains.kotlin.storage.StorageManager
@@ -97,9 +96,9 @@ public open class FileScopeProviderImpl(
         scope = LazyImportScope(scope, defaultAliasImportResolver, LazyImportScope.FilteringKind.ALL,
                 "Default alias imports in $debugName")
 
-        scope = SubpackagesScope(moduleDescriptor, FqName.ROOT).memberScopeAsImportingScope(scope)
+        scope = SubpackagesImportingScope(scope, moduleDescriptor, FqName.ROOT)
 
-        scope = NoSubpackagesInPackageScope(packageView).memberScopeAsImportingScope(scope) //TODO: problems with visibility too
+        scope = packageView.memberScope.memberScopeAsImportingScope(scope) //TODO: problems with visibility too
 
         scope = LazyImportScope(scope, aliasImportResolver, LazyImportScope.FilteringKind.ALL, "Alias imports in $debugName")
 

compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/descriptors/LazyClassMemberScope.kt

@@ -259,8 +259,6 @@ public open class LazyClassMemberScope(
         result.addAll(getContributedFunctions(Name.identifier("copy"), location))
     }
 
-    override fun getPackage(name: Name): PackageViewDescriptor? = null
-
     private val secondaryConstructors: NotNullLazyValue<Collection<ConstructorDescriptor>>
             = c.storageManager.createLazyValue { resolveSecondaryConstructors() }
 

compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/descriptors/LazyPackageMemberScope.kt

@@ -34,8 +34,6 @@ public class LazyPackageMemberScope(
         return computeDescriptorsFromDeclaredElements(kindFilter, nameFilter, NoLookupLocation.WHEN_GET_ALL_DESCRIPTORS)
     }
 
-    override fun getPackage(name: Name): PackageViewDescriptor? = null
-
     override fun getScopeForMemberDeclarationResolution(declaration: KtDeclaration)
             = resolveSession.getFileScopeProvider().getFileResolutionScope(declaration.getContainingKtFile())
 

compiler/frontend/src/org/jetbrains/kotlin/resolve/scopes/FilteringScope.kt

@@ -28,8 +28,6 @@ public class FilteringScope(private val workerScope: MemberScope, private val pr
     private fun <D : DeclarationDescriptor> filterDescriptor(descriptor: D?): D?
             = if (descriptor != null && predicate(descriptor)) descriptor else null
 
-    override fun getPackage(name: Name) = filterDescriptor(workerScope.getPackage(name))
-
     override fun getContributedClassifier(name: Name, location: LookupLocation) = filterDescriptor(workerScope.getContributedClassifier(name, location))
 
     override fun getContributedVariables(name: Name, location: LookupLocation) = workerScope.getContributedVariables(name, location).filter(predicate)

compiler/frontend/src/org/jetbrains/kotlin/resolve/scopes/SubpackagesImportingScope.kt

@@ -0,0 +1,35 @@
+/*
+ * Copyright 2010-2015 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.jetbrains.kotlin.resolve.scopes
+
+import org.jetbrains.kotlin.descriptors.ModuleDescriptor
+import org.jetbrains.kotlin.descriptors.PackageViewDescriptor
+import org.jetbrains.kotlin.descriptors.impl.SubpackagesScope
+import org.jetbrains.kotlin.name.FqName
+import org.jetbrains.kotlin.name.Name
+import org.jetbrains.kotlin.utils.Printer
+
+class SubpackagesImportingScope(
+        override val parent: ImportingScope?,
+        moduleDescriptor: ModuleDescriptor,
+        fqName: FqName
+) : SubpackagesScope(moduleDescriptor, fqName), ImportingScope by ImportingScope.Empty {
+
+    override fun getContributedPackage(name: Name): PackageViewDescriptor? = getPackage(name)
+
+    override fun printStructure(p: Printer) = printScopeStructure(p)
+}

compiler/frontend/src/org/jetbrains/kotlin/resolve/scopes/utils/ScopeUtils.kt

@@ -116,7 +116,7 @@ public fun HierarchicalScope.takeSnapshot(): HierarchicalScope = if (this is Lex
 public fun MemberScope.memberScopeAsImportingScope(parentScope: ImportingScope? = null): ImportingScope = MemberScopeToImportingScopeAdapter(parentScope, this)
 
 private class MemberScopeToImportingScopeAdapter(override val parent: ImportingScope?, val memberScope: MemberScope) : ImportingScope {
-    override fun getContributedPackage(name: Name): PackageViewDescriptor? = memberScope.getPackage(name)
+    override fun getContributedPackage(name: Name): PackageViewDescriptor? = null
 
     override fun getContributedSyntheticExtensionProperties(receiverTypes: Collection<KotlinType>, name: Name, location: LookupLocation)
             = emptyList<PropertyDescriptor>()

compiler/tests/org/jetbrains/kotlin/test/util/DescriptorValidator.java

@@ -404,7 +404,6 @@ public class DescriptorValidator {
         public Void visitPackageViewDescriptor(
                 PackageViewDescriptor descriptor, MemberScope scope
         ) {
-            assertFound(scope, descriptor, scope.getPackage(descriptor.getName()), false);
             return null;
         }
 

core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/lazy/descriptors/LazyJavaClassMemberScope.kt

@@ -619,8 +619,5 @@ public class LazyJavaClassMemberScope(
         }
     }
 
-    // namespaces should be resolved elsewhere
-    override fun getPackage(name: Name) = null
-
     override fun toString() = "Lazy java member scope for " + jClass.getFqName()
 }

core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/lazy/descriptors/LazyJavaStaticScope.kt

@@ -29,9 +29,6 @@ public abstract class LazyJavaStaticScope(c: LazyJavaResolverContext) : LazyJava
 
     override fun getDispatchReceiverParameter() = null
 
-    // Package fragments are not nested
-    override fun getPackage(name: Name) = null
-
     abstract fun getSubPackages(): Collection<FqName>
 
     override fun resolveMethodSignature(

core/descriptors/src/org/jetbrains/kotlin/descriptors/impl/LazyPackageViewDescriptorImpl.kt

@@ -44,6 +44,7 @@ public class LazyPackageViewDescriptorImpl(
             MemberScope.Empty
         }
         else {
+            // Packages from SubpackagesScope are got via getContributedDescriptors(DescriptorKindFilter.PACKAGES, MemberScope.ALL_NAME_FILTER)
             val scopes = fragments.map { it.getMemberScope() } + SubpackagesScope(module, fqName)
             ChainedScope("package view scope for $fqName in ${module.getName()}", *scopes.toTypedArray())
         }

core/descriptors/src/org/jetbrains/kotlin/descriptors/impl/SubpackagesScope.kt

@@ -28,9 +28,9 @@ import org.jetbrains.kotlin.utils.Printer
 import org.jetbrains.kotlin.utils.addIfNotNull
 import java.util.*
 
-public class SubpackagesScope(private val moduleDescriptor: ModuleDescriptor, private val fqName: FqName) : MemberScopeImpl() {
+public open class SubpackagesScope(private val moduleDescriptor: ModuleDescriptor, private val fqName: FqName) : MemberScopeImpl() {
 
-    override fun getPackage(name: Name): PackageViewDescriptor? {
+    protected fun getPackage(name: Name): PackageViewDescriptor? {
         if (name.isSpecial()) {
             return null
         }

core/descriptors/src/org/jetbrains/kotlin/resolve/scopes/AbstractScopeAdapter.kt

@@ -37,10 +37,6 @@ public abstract class AbstractScopeAdapter : MemberScope {
         return workerScope.getContributedFunctions(name, location)
     }
 
-    override fun getPackage(name: Name): PackageViewDescriptor? {
-        return workerScope.getPackage(name)
-    }
-
     override fun getContributedClassifier(name: Name, location: LookupLocation): ClassifierDescriptor? {
         return workerScope.getContributedClassifier(name, location)
     }

core/descriptors/src/org/jetbrains/kotlin/resolve/scopes/ChainedScope.kt

@@ -32,9 +32,6 @@ public class ChainedScope(
     override fun getContributedClassifier(name: Name, location: LookupLocation): ClassifierDescriptor?
             = getFirstMatch(scopeChain) { it.getContributedClassifier(name, location) }
 
-    override fun getPackage(name: Name): PackageViewDescriptor?
-            = getFirstMatch(scopeChain) { it.getPackage(name) }
-
     override fun getContributedVariables(name: Name, location: LookupLocation): Collection<PropertyDescriptor>
             = getFromAllScopes(scopeChain) { it.getContributedVariables(name, location) }
 

core/descriptors/src/org/jetbrains/kotlin/resolve/scopes/MemberScope.kt

@@ -27,9 +27,6 @@ public interface MemberScope : ResolutionScope {
 
     public override fun getContributedVariables(name: Name, location: LookupLocation): Collection<PropertyDescriptor>
 
-    @Deprecated("Should be removed soon")
-    public fun getPackage(name: Name): PackageViewDescriptor?
-
     /**
      * Is supposed to be used in tests and debug only
      */

core/descriptors/src/org/jetbrains/kotlin/resolve/scopes/MemberScopeImpl.kt

@@ -26,8 +26,6 @@ abstract class MemberScopeImpl : MemberScope {
 
     override fun getContributedVariables(name: Name, location: LookupLocation): Collection<PropertyDescriptor> = emptyList()
 
-    override fun getPackage(name: Name): PackageViewDescriptor? = null
-
     override fun getContributedFunctions(name: Name, location: LookupLocation): Collection<FunctionDescriptor> = emptyList()
 
     override fun getContributedDescriptors(kindFilter: DescriptorKindFilter,

core/descriptors/src/org/jetbrains/kotlin/resolve/scopes/SubstitutingScope.kt

@@ -65,8 +65,6 @@ public class SubstitutingScope(private val workerScope: MemberScope, private val
 
     override fun getContributedFunctions(name: Name, location: LookupLocation) = substitute(workerScope.getContributedFunctions(name, location))
 
-    override fun getPackage(name: Name) = workerScope.getPackage(name)
-
     override fun getContributedDescriptors(kindFilter: DescriptorKindFilter,
                                            nameFilter: (Name) -> Boolean) = _allDescriptors
 

core/descriptors/src/org/jetbrains/kotlin/types/ErrorUtils.java

@@ -180,11 +180,6 @@ public class ErrorUtils {
             return ERROR_PROPERTY_GROUP;
         }
 
-        @Override
-        public PackageViewDescriptor getPackage(@NotNull Name name) {
-            return null;
-        }
-
         @NotNull
         @Override
         public Set<FunctionDescriptor> getContributedFunctions(@NotNull Name name, @NotNull LookupLocation location) {
@@ -223,12 +218,6 @@ public class ErrorUtils {
             throw new IllegalStateException();
         }
 
-        @Nullable
-        @Override
-        public PackageViewDescriptor getPackage(@NotNull Name name) {
-            throw new IllegalStateException();
-        }
-
         @NotNull
         @Override
         @SuppressWarnings({"unchecked"}) // KT-9898 Impossible implement kotlin interface from java

idea/idea-core/src/org/jetbrains/kotlin/idea/core/HeuristicSignatures.kt

@@ -21,7 +21,6 @@ import org.jetbrains.kotlin.descriptors.FunctionDescriptor
 import org.jetbrains.kotlin.descriptors.ModuleDescriptor
 import org.jetbrains.kotlin.descriptors.TypeParameterDescriptor
 import org.jetbrains.kotlin.descriptors.ValueParameterDescriptor
-import org.jetbrains.kotlin.descriptors.impl.SubpackagesScope
 import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.name.Name
 import org.jetbrains.kotlin.psi.KtPsiFactory
@@ -30,7 +29,7 @@ import org.jetbrains.kotlin.resolve.DescriptorUtils
 import org.jetbrains.kotlin.resolve.TypeResolver
 import org.jetbrains.kotlin.resolve.scopes.LexicalScopeImpl
 import org.jetbrains.kotlin.resolve.scopes.LexicalScopeKind
-import org.jetbrains.kotlin.resolve.scopes.utils.memberScopeAsImportingScope
+import org.jetbrains.kotlin.resolve.scopes.SubpackagesImportingScope
 import org.jetbrains.kotlin.types.KotlinType
 import org.jetbrains.kotlin.types.SubstitutionUtils
 import org.jetbrains.kotlin.types.TypeConstructorSubstitution
@@ -77,7 +76,7 @@ internal class HeuristicSignatures(
 
     private fun typeFromText(text: String, typeParameters: Collection<TypeParameterDescriptor>): KotlinType {
         val typeRef = KtPsiFactory(project).createType(text)
-        val rootPackagesScope = SubpackagesScope(moduleDescriptor, FqName.ROOT).memberScopeAsImportingScope()
+        val rootPackagesScope = SubpackagesImportingScope(null, moduleDescriptor, FqName.ROOT)
         val scope = LexicalScopeImpl(rootPackagesScope, moduleDescriptor, false, null, LexicalScopeKind.SYNTHETIC) {
             typeParameters.forEach { addClassifierDescriptor(it) }
         }