Use property access syntax: fix problem text and highlight range

#KT-30910 Fixed

idea/idea-analysis/src/org/jetbrains/kotlin/idea/inspections/IntentionBasedInspection.kt

@@ -83,6 +83,8 @@ abstract class IntentionBasedInspection<TElement : PsiElement> private construct
     open fun additionalFixes(element: TElement): List<LocalQuickFix>? = null
 
     open fun inspectionTarget(element: TElement): PsiElement? = null
+    
+    open fun inspectionProblemText(element: TElement): String? = null
 
     private fun PsiElement.toRange(baseElement: PsiElement): TextRange {
         val start = getStartOffsetIn(baseElement)
@@ -126,7 +128,7 @@ abstract class IntentionBasedInspection<TElement : PsiElement> private construct
                     if (!allFixes.isEmpty()) {
                         holder.registerProblemWithoutOfflineInformation(
                                 targetElement,
-                                problemText ?: allFixes.first().name,
+                                inspectionProblemText(element) ?: problemText ?: allFixes.first().name,
                                 isOnTheFly,
                                 problemHighlightType(targetElement),
                                 range,

idea/src/org/jetbrains/kotlin/idea/intentions/UsePropertyAccessSyntaxIntention.kt

@@ -79,6 +79,19 @@ class UsePropertyAccessSyntaxInspection : IntentionBasedInspection<KtCallExpress
         val list = NotPropertyListPanel(fqNameList)
         return LabeledComponent.create(list, "Excluded methods")
     }
+
+    override fun inspectionTarget(element: KtCallExpression): PsiElement? {
+        return element.calleeExpression
+    }
+
+    override fun inspectionProblemText(element: KtCallExpression): String? {
+        val accessor = when (element.valueArguments.size) {
+            0 -> "getter"
+            1 -> "setter"
+            else -> null
+        }
+        return "Use of $accessor method instead of property access syntax"
+    }
 }
 
 

idea/testData/inspectionsLocal/usePropertyAccessSyntax/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.UsePropertyAccessSyntaxInspection

idea/testData/inspectionsLocal/usePropertyAccessSyntax/caretOnValueArgumentList.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+import java.io.File
+
+fun foo(file: File) {
+    file.getAbsolutePath(<caret>)
+}

idea/testData/inspectionsLocal/usePropertyAccessSyntax/get.kt

@@ -0,0 +1,7 @@
+// PROBLEM: "Use of getter method instead of property access syntax"
+// WITH_RUNTIME
+import java.io.File
+
+fun foo(file: File) {
+    file.getAbsolutePath<caret>()
+}

idea/testData/inspectionsLocal/usePropertyAccessSyntax/get.kt.after

@@ -0,0 +1,7 @@
+// PROBLEM: "Use of getter method instead of property access syntax"
+// WITH_RUNTIME
+import java.io.File
+
+fun foo(file: File) {
+    file.absolutePath
+}

idea/testData/inspectionsLocal/usePropertyAccessSyntax/set.kt

@@ -0,0 +1,5 @@
+// PROBLEM: "Use of setter method instead of property access syntax"
+// WITH_RUNTIME
+fun foo(thread: Thread) {
+    thread.setName<caret>("name")
+}

idea/testData/inspectionsLocal/usePropertyAccessSyntax/set.kt.after

@@ -0,0 +1,5 @@
+// PROBLEM: "Use of setter method instead of property access syntax"
+// WITH_RUNTIME
+fun foo(thread: Thread) {
+    thread.name = "name"
+}

idea/tests/org/jetbrains/kotlin/idea/inspections/LocalInspectionTestGenerated.java

@@ -9816,6 +9816,34 @@ public class LocalInspectionTestGenerated extends AbstractLocalInspectionTest {
         }
     }
 
+    @TestMetadata("idea/testData/inspectionsLocal/usePropertyAccessSyntax")
+    @TestDataPath("$PROJECT_ROOT")
+    @RunWith(JUnit3RunnerWithInners.class)
+    public static class UsePropertyAccessSyntax extends AbstractLocalInspectionTest {
+        private void runTest(String testDataFilePath) throws Exception {
+            KotlinTestUtils.runTest(this::doTest, TargetBackend.ANY, testDataFilePath);
+        }
+
+        public void testAllFilesPresentInUsePropertyAccessSyntax() throws Exception {
+            KotlinTestUtils.assertAllTestsPresentByMetadata(this.getClass(), new File("idea/testData/inspectionsLocal/usePropertyAccessSyntax"), Pattern.compile("^([\\w\\-_]+)\\.(kt|kts)$"), TargetBackend.ANY, true);
+        }
+
+        @TestMetadata("caretOnValueArgumentList.kt")
+        public void testCaretOnValueArgumentList() throws Exception {
+            runTest("idea/testData/inspectionsLocal/usePropertyAccessSyntax/caretOnValueArgumentList.kt");
+        }
+
+        @TestMetadata("get.kt")
+        public void testGet() throws Exception {
+            runTest("idea/testData/inspectionsLocal/usePropertyAccessSyntax/get.kt");
+        }
+
+        @TestMetadata("set.kt")
+        public void testSet() throws Exception {
+            runTest("idea/testData/inspectionsLocal/usePropertyAccessSyntax/set.kt");
+        }
+    }
+
     @TestMetadata("idea/testData/inspectionsLocal/whenWithOnlyElse")
     @TestDataPath("$PROJECT_ROOT")
     @RunWith(JUnit3RunnerWithInners.class)