Rename: Identify elements with the same origin when checking import ambiguity
#KT-13284 Fixed
This commit is contained in:
@@ -27,6 +27,7 @@ import com.intellij.refactoring.rename.RenamePsiElementProcessor
|
||||
import com.intellij.usageView.UsageInfo
|
||||
import org.jetbrains.kotlin.asJava.namedUnwrappedElement
|
||||
import org.jetbrains.kotlin.asJava.toLightMethods
|
||||
import org.jetbrains.kotlin.asJava.unwrapped
|
||||
import org.jetbrains.kotlin.idea.highlighter.markers.actualsForExpected
|
||||
import org.jetbrains.kotlin.idea.highlighter.markers.liftToExpected
|
||||
import org.jetbrains.kotlin.idea.search.ideaExtensions.KotlinReferencesSearchOptions
|
||||
@@ -93,7 +94,7 @@ abstract class RenameKotlinPsiProcessor : RenamePsiElementProcessor() {
|
||||
val ref = reference as? PsiPolyVariantReference ?: return false
|
||||
val refElement = ref.element
|
||||
return refElement.parents.any { (it is KtImportDirective && !it.isAllUnder) || (it is PsiImportStaticStatement && !it.isOnDemand) }
|
||||
&& ref.multiResolve(false).size > 1
|
||||
&& ref.multiResolve(false).mapNotNullTo(HashSet()) { it.element?.unwrapped }.size > 1
|
||||
}
|
||||
|
||||
override fun getPostRenameCallback(element: PsiElement, newName: String?, elementListener: RefactoringElementListener?): Runnable? {
|
||||
|
||||
+12
@@ -0,0 +1,12 @@
|
||||
import foo.OverloadKt;
|
||||
|
||||
import static foo.OverloadKt.overload;
|
||||
|
||||
public class OverloadJava {
|
||||
public void useOverload() {
|
||||
OverloadKt.overloadNew(0, false);
|
||||
OverloadKt.overloadNew(0, true);
|
||||
OverloadKt.overloadNew(0, true, 2.0);
|
||||
overload("123");
|
||||
}
|
||||
}
|
||||
+4
@@ -0,0 +1,4 @@
|
||||
package foo
|
||||
|
||||
@JvmOverloads fun overloadNew(p1: Int, p2: Boolean, p3: Double = 1.0) {}
|
||||
fun overload(s: String) {}
|
||||
+10
@@ -0,0 +1,10 @@
|
||||
import static foo.OverloadKt.overload;
|
||||
|
||||
public class OverloadJava {
|
||||
public void useOverload() {
|
||||
overload(0, false);
|
||||
overload(0, true);
|
||||
overload(0, true, 2.0);
|
||||
overload("123");
|
||||
}
|
||||
}
|
||||
+4
@@ -0,0 +1,4 @@
|
||||
package foo
|
||||
|
||||
@JvmOverloads fun /*rename*/overload(p1: Int, p2: Boolean, p3: Double = 1.0) {}
|
||||
fun overload(s: String) {}
|
||||
Vendored
+7
@@ -0,0 +1,7 @@
|
||||
{
|
||||
"type": "MARKED_ELEMENT",
|
||||
"mainFile": "foo/overload.kt",
|
||||
"newName": "overloadNew",
|
||||
"withRuntime": "true",
|
||||
"overloadRenamer.onlyPrimaryElement": "true"
|
||||
}
|
||||
+9
@@ -0,0 +1,9 @@
|
||||
import static foo.OverloadKt.overloadNew;
|
||||
|
||||
public class OverloadJava {
|
||||
public void useOverload() {
|
||||
overloadNew(0, false);
|
||||
overloadNew(0, true);
|
||||
overloadNew(0, true, 2.0);
|
||||
}
|
||||
}
|
||||
+3
@@ -0,0 +1,3 @@
|
||||
package foo
|
||||
|
||||
@JvmOverloads fun overloadNew(p1: Int, p2: Boolean, p3: Double = 1.0) {}
|
||||
+9
@@ -0,0 +1,9 @@
|
||||
import static foo.OverloadKt.overload;
|
||||
|
||||
public class OverloadJava {
|
||||
public void useOverload() {
|
||||
overload(0, false);
|
||||
overload(0, true);
|
||||
overload(0, true, 2.0);
|
||||
}
|
||||
}
|
||||
+3
@@ -0,0 +1,3 @@
|
||||
package foo
|
||||
|
||||
@JvmOverloads fun /*rename*/overload(p1: Int, p2: Boolean, p3: Double = 1.0) {}
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
{
|
||||
"type": "MARKED_ELEMENT",
|
||||
"mainFile": "foo/overload.kt",
|
||||
"newName": "overloadNew",
|
||||
"withRuntime": "true",
|
||||
"overloadRenamer.onlyPrimaryElement": "true"
|
||||
}
|
||||
+12
@@ -421,6 +421,18 @@ public class RenameTestGenerated extends AbstractRenameTest {
|
||||
doTest(fileName);
|
||||
}
|
||||
|
||||
@TestMetadata("overloadsWithDifferentOrigins/overloadsWithDifferentOrigins.test")
|
||||
public void testOverloadsWithDifferentOrigins_OverloadsWithDifferentOrigins() throws Exception {
|
||||
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/refactoring/rename/overloadsWithDifferentOrigins/overloadsWithDifferentOrigins.test");
|
||||
doTest(fileName);
|
||||
}
|
||||
|
||||
@TestMetadata("overloadsWithSameOrigin/overloadsWithSameOrigin.test")
|
||||
public void testOverloadsWithSameOrigin_OverloadsWithSameOrigin() throws Exception {
|
||||
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/refactoring/rename/overloadsWithSameOrigin/overloadsWithSameOrigin.test");
|
||||
doTest(fileName);
|
||||
}
|
||||
|
||||
@TestMetadata("paramererAsReceiverWithNewNameAsSelector/parameterAsReceiverWithNewNameAsSelector.test")
|
||||
public void testParamererAsReceiverWithNewNameAsSelector_ParameterAsReceiverWithNewNameAsSelector() throws Exception {
|
||||
String fileName = KotlinTestUtils.navigationMetadata("idea/testData/refactoring/rename/paramererAsReceiverWithNewNameAsSelector/parameterAsReceiverWithNewNameAsSelector.test");
|
||||
|
||||
Reference in New Issue
Block a user