Create Function From Usage: Fix availability condition

2014-09-29 20:08:53 +04:00
parent a6ba3a569d
commit 854962a139
3 changed files with 36 additions and 1 deletions
@@ -15,10 +15,25 @@ import org.jetbrains.jet.lang.resolve.calls.callUtil.getCall
 import org.jetbrains.jet.lang.resolve.scopes.receivers.ReceiverValue
 import org.jetbrains.jet.lang.resolve.scopes.receivers.Qualifier
 import org.jetbrains.jet.plugin.quickfix.createFromUsage.callableBuilder.*
+import org.jetbrains.jet.lang.diagnostics.Errors
+import org.jetbrains.jet.lang.psi.psiUtil.getParentByType
+import org.jetbrains.jet.lang.psi.psiUtil.getParentByTypeAndBranch

 object CreateFunctionFromCallActionFactory : JetSingleIntentionActionFactory() {
    override fun createAction(diagnostic: Diagnostic): IntentionAction? {
-        val callExpr = QuickFixUtil.getParentElementOfType(diagnostic, javaClass<JetCallExpression>()) ?: return null
+        val diagElement = diagnostic.getPsiElement()
+        val callExpr = when (diagnostic.getFactory()) {
+            in Errors.UNRESOLVED_REFERENCE_DIAGNOSTICS -> {
+                val parent = diagElement.getParent()
+                if (parent is JetCallExpression && parent.getCalleeExpression() == diagElement) parent else diagElement
+            }
+
+            Errors.NO_VALUE_FOR_PARAMETER,
+            Errors.TOO_MANY_ARGUMENTS -> diagElement.getParentByType(javaClass<JetCallExpression>())
+
+            else -> throw AssertionError("Unexpected diagnostic: ${diagnostic.getFactory()}")
+        }
+        if (callExpr !is JetCallExpression) return null

        val calleeExpr = callExpr.getCalleeExpression() as? JetSimpleNameExpression ?: return null
        if (calleeExpr.getReferencedNameElementType() != JetTokens.IDENTIFIER) return null
@@ -0,0 +1,14 @@
+// "Create function 'foo' from usage" "false"
+// ACTION: Convert to expression body
+// ACTION: Replace with infix function call
+// ERROR: Unresolved reference: x
+
+class A<T>(val n: T) {
+    fun foo(p: Int) {
+
+    }
+}
+
+fun test() {
+    A(1).<caret>foo(x)
+}
@@ -826,6 +826,12 @@ public class QuickFixTestGenerated extends AbstractQuickFixTest {
                    doTest(fileName);
                }
                
+                @TestMetadata("beforePropertyOnUserType.kt")
+                public void testPropertyOnUserType() throws Exception {
+                    String fileName = JetTestUtils.navigationMetadata("idea/testData/quickfix/createFromUsage/createFunction/call/beforePropertyOnUserType.kt");
+                    doTest(fileName);
+                }
+                
                @TestMetadata("beforeThisInClass.kt")
                public void testThisInClass() throws Exception {
                    String fileName = JetTestUtils.navigationMetadata("idea/testData/quickfix/createFromUsage/createFunction/call/beforeThisInClass.kt");