Inspection for scope functions conversion

#KT-17047 Fixed

idea/testData/inspectionsLocal/scopeFunctions/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.ScopeFunctionConversionInspection

idea/testData/inspectionsLocal/scopeFunctions/alsoToApply/simple.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+val x = "".<caret>also {
+    it.length
+}

idea/testData/inspectionsLocal/scopeFunctions/alsoToApply/simple.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+val x = "".<caret>apply {
+    length
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/doubleNestedLambdas.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").<caret>apply {
+    forEach {
+        forEach {
+            println(this)
+        }
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/doubleNestedLambdas.kt.after

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").also { hashSet ->
+    hashSet.forEach {
+        hashSet.forEach {
+            println(hashSet)
+        }
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/innerLambda.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".also {
+    "".<caret>apply {
+        this.length + it.length
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/innerLambda.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".also {
+    "".also { s ->
+        s.length + it.length
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/itInNestedLambda.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").<caret>apply {
+    forEach {
+        println(this)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/itInNestedLambda.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").also { hashSet ->
+    hashSet.forEach {
+        println(hashSet)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/method.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = hashSetOf<String>().<caret>apply {
+    add("x")
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/method.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = hashSetOf<String>().<caret>also {
+    it.add("x")
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/outerLambda.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".<caret>apply {
+    "".apply {
+        this.length
+        length
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/outerLambda.kt.after

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".<caret>also {
+    "".apply {
+        this.length
+        length
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/simple.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".<caret>apply {
+    this.length
+    length
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/simple.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+val x = "".<caret>also {
+    it.length
+    it.length
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/thisQualifier.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+class C {
+    val x = hashSetOf<C>().<caret>apply {
+        add(this@C)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/applyToAlso/thisQualifier.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// FIX: Convert to 'also'
+
+class C {
+    val x = hashSetOf<C>().<caret>also {
+        it.add(this)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/nestedLambda.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").<caret>let {
+    it.forEach {
+        println(it)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/nestedLambda.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+val x = hashSetOf("abc").<caret>run {
+    forEach {
+        println(it)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/outerThis.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class C {
+    val c = "abc".<caret>let {
+        println(it + this)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/outerThis.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class C {
+    val c = "abc".<caret>run {
+        println(this + this@C)
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThis.kt

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun foo() = "d"
+    val bar = "D"
+
+    val x = C().<caret>let {
+        foo() + it.foo() + bar + it.bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThis.kt.after

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun foo() = "d"
+    val bar = "D"
+
+    val x = C().<caret>run {
+        this@D.foo() + foo() + this@D.bar + bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisNoConflict.kt

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo(s: String, s2: String = ""): String = "c"
+    val bar = "C"
+}
+
+class D {
+    fun baz(s: String): String = "d"
+    val quux = "D"
+
+    val x = C().<caret>let {
+        it.foo(baz(it.foo(quux + it.bar)), baz(it.bar))
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisNoConflict.kt.after

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo(s: String, s2: String = ""): String = "c"
+    val bar = "C"
+}
+
+class D {
+    fun baz(s: String): String = "d"
+    val quux = "D"
+
+    val x = C().<caret>run {
+        foo(baz(foo(quux + bar)), baz(bar))
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisWithLambda.kt

@@ -0,0 +1,19 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun foo() = "d"
+    val bar = "D"
+
+}
+
+val d = D()
+val x = d.apply {
+    C().<caret>let {
+        foo() + it.foo() + bar + it.bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisWithLambda.kt.after

@@ -0,0 +1,19 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun foo() = "d"
+    val bar = "D"
+
+}
+
+val d = D()
+val x = d.apply {
+    C().<caret>run {
+        this@apply.foo() + foo() + this@apply.bar + bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisWithLambdaNoConflict.kt

@@ -0,0 +1,19 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun baz() = "d"
+    val quux = "D"
+
+}
+
+val d = D()
+val x = d.apply {
+    C().<caret>let {
+        baz() + it.foo() + quux + it.bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/qualifyThisWithLambdaNoConflict.kt.after

@@ -0,0 +1,19 @@
+// WITH_RUNTIME
+
+class C {
+    fun foo() = "c"
+    val bar = "C"
+}
+
+class D {
+    fun baz() = "d"
+    val quux = "D"
+
+}
+
+val d = D()
+val x = d.apply {
+    C().<caret>run {
+        baz() + foo() + quux + bar
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/simple.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// FIX: Convert to 'run'
+
+val x = "".<caret>let {
+    it.length
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/simple.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// FIX: Convert to 'run'
+
+val x = "".<caret>run {
+    length
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/thisInStringTemplate.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class C {
+    val c = "abc".<caret>let {
+        println("$it")
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/letToRun/thisInStringTemplate.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class C {
+    val c = "abc".<caret>run {
+        println("$this")
+    }
+}

idea/testData/inspectionsLocal/scopeFunctions/runToLet/simple.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// FIX: Convert to 'let'
+
+val x = "".<caret>run {
+    this.length
+    length
+}

idea/testData/inspectionsLocal/scopeFunctions/runToLet/simple.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// FIX: Convert to 'let'
+
+val x = "".<caret>let {
+    it.length
+    it.length
+}