[FIR] Do not throw exception on unexpected FIR for constants

^KTIJ-23263 fixed

Merge-request: KT-MR-10699
Merged-by: Egor Kulikov <Egor.Kulikov@jetbrains.com>

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/KtSymbolByFirBuilder.kt

@@ -264,8 +264,8 @@ internal class KtSymbolByFirBuilder constructor(
                 is FirFieldSymbol -> buildFieldSymbol(firSymbol)
                 is FirEnumEntrySymbol -> buildEnumEntrySymbol(firSymbol) // TODO enum entry should not be callable
                 is FirBackingFieldSymbol -> buildBackingFieldSymbol(firSymbol)
+                is FirErrorPropertySymbol -> buildErrorVariableSymbol(firSymbol)
 
-                is FirErrorPropertySymbol -> throwUnexpectedElementError(firSymbol)
                 is FirDelegateFieldSymbol -> throwUnexpectedElementError(firSymbol)
             }
         }

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirCompileTimeConstantProvider.kt

@@ -66,10 +66,7 @@ internal class KtFirCompileTimeConstantProvider(
             // ```
             // `false` does not have a corresponding elements on the FIR side and hence the containing `FirWhenBranch` is returned. In this
             // case, we simply report null since FIR does not know about it.
-            fir is FirWhenBranch -> null
-            fir is FirVariableAssignment && fir.source?.kind == KtFakeSourceElementKind.DesugaredIncrementOrDecrement -> null
-            fir is FirTypeRef -> null
-            else -> throwUnexpectedFirElementError(fir, sourcePsi)
+            else -> null
         }
     }
 

analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/ktij23263.kt

@@ -0,0 +1,4 @@
+class InitOrderDemo(name: String) {
+    val (firstProperty = <expr>"First property"</expr>
+
+}

analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/ktij23263.txt

@@ -0,0 +1,18 @@
+KT element: KtStringTemplateExpression
+FIR element: FirErrorPropertyImpl
+FIR source kind: KtRealSourceElementKind
+
+FIR element rendered:
+<ERROR PROPERTY: Destructuring declarations are only allowed for local variables/values>
+
+FIR FILE:
+FILE: [ResolvedTo(IMPORTS)] ktij23263.kt
+    [ResolvedTo(BODY_RESOLVE)] annotations container
+    public? final? [ResolvedTo(RAW_FIR)] class InitOrderDemo : R|kotlin/Any| {
+        public? [ResolvedTo(RAW_FIR)] constructor([ResolvedTo(RAW_FIR)] name: String): R|InitOrderDemo| {
+            LAZY_super<R|kotlin/Any|>
+        }
+
+        <ERROR PROPERTY: Destructuring declarations are only allowed for local variables/values>
+
+    }

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/OutOfContentRootGetOrBuildFirTestGenerated.java

@@ -501,6 +501,12 @@ public class OutOfContentRootGetOrBuildFirTestGenerated extends AbstractOutOfCon
             runTest("analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/destructuringEntry.kt");
         }
 
+        @Test
+        @TestMetadata("ktij23263.kt")
+        public void testKtij23263() throws Exception {
+            runTest("analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/ktij23263.kt");
+        }
+
         @Test
         @TestMetadata("objectLiteral.kt")
         public void testObjectLiteral() throws Exception {

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/SourceGetOrBuildFirTestGenerated.java

@@ -501,6 +501,12 @@ public class SourceGetOrBuildFirTestGenerated extends AbstractSourceGetOrBuildFi
             runTest("analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/destructuringEntry.kt");
         }
 
+        @Test
+        @TestMetadata("ktij23263.kt")
+        public void testKtij23263() throws Exception {
+            runTest("analysis/low-level-api-fir/testdata/getOrBuildFir/declarations/ktij23263.kt");
+        }
+
         @Test
         @TestMetadata("objectLiteral.kt")
         public void testObjectLiteral() throws Exception {