Style: do not highlight single return when as "Use expresison body"

This commit is contained in:
Mikhail Glukhikh
2017-11-17 14:21:13 +03:00
parent c0a3344803
commit 539f8afef3
3 changed files with 5 additions and 1 deletions
@@ -60,7 +60,7 @@ class UseExpressionBodyInspection(private val convertEmptyToUnit: Boolean) : Abs
val toHighlight = valueStatement.toHighlight()
return when {
valueStatement !is KtReturnExpression -> Status(toHighlight, "block body", INFORMATION)
valueStatement.returnedExpression is KtWhenExpression -> Status(toHighlight, "'return when'", GENERIC_ERROR_OR_WARNING)
valueStatement.returnedExpression is KtWhenExpression -> Status(toHighlight, "'return when'", INFORMATION)
valueStatement.isOneLiner() -> Status(toHighlight, "one-line return", GENERIC_ERROR_OR_WARNING)
else -> Status(toHighlight, "return", INFORMATION)
}
@@ -1,3 +1,5 @@
// HIGHLIGHT: INFORMATION
fun sign(x: Int): Int {
<caret>return when {
x < 0 -> -1
@@ -1,3 +1,5 @@
// HIGHLIGHT: INFORMATION
fun sign(x: Int): Int = when {
x < 0 -> -1
x > 0 -> 1