azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better message for CanBeValInspection

Browse Source
This commit is contained in:
Valentin Kipyatkov
2016-04-07 19:32:31 +03:00
parent ecdaaea88d
commit 50e7079efc
3 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/META-INF/plugin.xml
+1 -1
View File
@@ -1414,7 +1414,7 @@
level="WEAK WARNING"/>
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.CanBeValInspection"
displayName="Local 'var' can be declared as 'val'"
displayName="Local 'var' is never modified and can be declared as 'val'"
groupName="Kotlin"
enabledByDefault="true"
level="WARNING"
idea/src/org/jetbrains/kotlin/idea/inspections/CanBeValInspection.kt
+1 -1
View File
@@ -117,7 +117,7 @@ class CanBeValInspection : AbstractKotlinInspection() {
val problemDescriptor = holder.manager.createProblemDescriptor(
declaration,
declaration.valOrVarKeyword!!,
"Can be declared as 'val'",
"Variable is never modified and can be declared immutable using 'val'",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
isOnTheFly,
IntentionWrapper(ChangeVariableMutabilityFix(declaration, false), declaration.containingFile)
idea/testData/inspections/canBeVal/inspectionData/expected.xml
Vendored
+16 -16
View File
@@ -4,8 +4,8 @@
<line>4</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="withInitializer.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -13,8 +13,8 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="alwaysAssigned.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -22,8 +22,8 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="notAssignedWhenNotUsed.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -31,8 +31,8 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="twoVariables.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -40,8 +40,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="twoVariables.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -49,8 +49,8 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="desctructuringDeclaration1.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -58,8 +58,8 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="stackOverflowBug.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
<problem>
@@ -67,7 +67,7 @@
<line>2</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="kt11891.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' can be declared as 'val'</problem_class>
<description>Can be declared as 'val'</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Local 'var' is never modified and can be declared as 'val'</problem_class>
<description>Variable is never modified and can be declared immutable using 'val'</description>
</problem>
</problems>