[FIR] Properly handle declarations from other source sessions in FirPredicateBasedProvider

^KT-57083 Fixed

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/extensions/FirPredicateBasedProviderImpl.kt

@@ -90,6 +90,14 @@ class FirPredicateBasedProviderImpl(private val session: FirSession) : FirPredic
     // ---------------------------------- Matching ----------------------------------
 
     override fun matches(predicate: AbstractPredicate<*>, declaration: FirDeclaration): Boolean {
+        /*
+         * If declaration came from the other source session we should delegate to provider from
+         *   that session, because it stores all caches about its own declarations
+         */
+        val declarationSession = declaration.moduleData.session
+        if (declarationSession.kind == FirSession.Kind.Source && declarationSession !== session) {
+            return declarationSession.predicateBasedProvider.matches(predicate, declaration)
+        }
         return when (predicate) {
             is DeclarationPredicate -> predicate.accept(declarationPredicateMatcher, declaration)
             is LookupPredicate -> predicate.accept(lookupPredicateMatcher, declaration)

plugins/kotlinx-serialization/testData/diagnostics/serializerFromOtherModule.kt

@@ -0,0 +1,21 @@
+// FIR_DISABLE_LAZY_RESOLVE_CHECKS
+// FIR_IDENTICAL
+// WITH_STDLIB
+// ISSUE: KT-57083
+
+// MODULE: lib
+// FILE: libtest.kt
+
+import kotlinx.serialization.*
+
+@Serializable
+class Access(val message: String)
+
+// MODULE: main(lib)
+// FILE: test.kt
+
+import kotlinx.serialization.*
+import kotlinx.serialization.json.*
+
+@Serializable
+class Usage(val access: Access)

plugins/kotlinx-serialization/tests-gen/org/jetbrains/kotlinx/serialization/runners/SerializationFirPsiDiagnosticTestGenerated.java

@@ -134,6 +134,12 @@ public class SerializationFirPsiDiagnosticTestGenerated extends AbstractSerializ
             runTest("plugins/kotlinx-serialization/testData/diagnostics/SerializableIgnored.kt");
         }
 
+        @Test
+        @TestMetadata("serializerFromOtherModule.kt")
+        public void testSerializerFromOtherModule() throws Exception {
+            runTest("plugins/kotlinx-serialization/testData/diagnostics/serializerFromOtherModule.kt");
+        }
+
         @Test
         @TestMetadata("SerializerTypeCompatibleForSpecials.kt")
         public void testSerializerTypeCompatibleForSpecials() throws Exception {

plugins/kotlinx-serialization/tests-gen/org/jetbrains/kotlinx/serialization/runners/SerializationPluginDiagnosticTestGenerated.java

@@ -132,6 +132,12 @@ public class SerializationPluginDiagnosticTestGenerated extends AbstractSerializ
         runTest("plugins/kotlinx-serialization/testData/diagnostics/SerializableIgnored.kt");
     }
 
+    @Test
+    @TestMetadata("serializerFromOtherModule.kt")
+    public void testSerializerFromOtherModule() throws Exception {
+        runTest("plugins/kotlinx-serialization/testData/diagnostics/serializerFromOtherModule.kt");
+    }
+
     @Test
     @TestMetadata("SerializerTypeCompatibleForSpecials.kt")
     public void testSerializerTypeCompatibleForSpecials() throws Exception {