azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[KT-58995] Fix UPUB bug

Browse Source 
Add an explanation comment
This commit is contained in:
Denis Lochmelis
2023-11-08 11:32:30 +01:00
committed by Space Team
parent d8eee222af
commit 4b3dfe6e6e
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kotlin-native/runtime/src/mm/cpp/ObjectOps.cpp
+4
View File
@@ -75,6 +75,8 @@ OBJ_GETTER(mm::AllocateObject, ThreadData* threadData, const TypeInfo* typeInfo)
AssertThreadState(threadData, ThreadState::kRunnable);
// TODO: Make this work with GCs that can stop thread at any point.
auto* object = threadData->allocator().allocateObject(typeInfo);
// Prevents unsafe class publication (see KT-58995).
std::atomic_thread_fence(std::memory_order_release);
threadData->gc().onAllocation(object);
RETURN_OBJ(object);
}
@@ -83,6 +85,8 @@ OBJ_GETTER(mm::AllocateArray, ThreadData* threadData, const TypeInfo* typeInfo,
AssertThreadState(threadData, ThreadState::kRunnable);
// TODO: Make this work with GCs that can stop thread at any point.
auto* array = threadData->allocator().allocateArray(typeInfo, static_cast<uint32_t>(elements));
// Prevents unsafe class publication (see KT-58995).
std::atomic_thread_fence(std::memory_order_release);
threadData->gc().onAllocation(array->obj());
RETURN_OBJ(array->obj());
}