[FIR] Fix duplicate WRONG_NULLABILITY_FOR_JAVA_OVERRIDE

Also, the test shows a missing warning in K1 which is present in K2.

#KT-63600 Fixed
#KT-63599
#KT-63745
#KT-63746

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirPsiOldFrontendForeignAnnotationsCompiledJavaTestGenerated.java

@@ -240,6 +240,12 @@ public class FirPsiOldFrontendForeignAnnotationsCompiledJavaTestGenerated extend
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirPsiOldFrontendForeignAnnotationsCompiledJavaWithPsiClassReadingTestGenerated.java

@@ -298,6 +298,12 @@ public class FirPsiOldFrontendForeignAnnotationsCompiledJavaWithPsiClassReadingT
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirPsiOldFrontendForeignAnnotationsSourceJavaTestGenerated.java

@@ -298,6 +298,12 @@ public class FirPsiOldFrontendForeignAnnotationsSourceJavaTestGenerated extends
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {

compiler/fir/checkers/checkers.jvm/src/org/jetbrains/kotlin/fir/analysis/jvm/checkers/declaration/FirOverrideJavaNullabilityWarningChecker.kt

@@ -35,6 +35,7 @@ object FirOverrideJavaNullabilityWarningChecker : FirAbstractOverrideChecker() {
 
         for (member in declaration.declarations) {
             var anyBaseEnhanced = false
+            var anyReported = false
 
             if (member is FirSimpleFunction) {
                 val enhancedOverrides = scope
@@ -44,7 +45,8 @@ object FirOverrideJavaNullabilityWarningChecker : FirAbstractOverrideChecker() {
                         val substitutedBase = it.fir.substituteOrNull(substitutor, context) ?: return@map it
                         anyBaseEnhanced = true
 
-                        if (!context.session.firOverrideChecker.isOverriddenFunction(member, substitutedBase)) {
+                        if (!anyReported && !context.session.firOverrideChecker.isOverriddenFunction(member, substitutedBase)) {
+                            anyReported = true
                             reporter.reportOn(
                                 member.source,
                                 FirJvmErrors.WRONG_NULLABILITY_FOR_JAVA_OVERRIDE,
@@ -57,7 +59,7 @@ object FirOverrideJavaNullabilityWarningChecker : FirAbstractOverrideChecker() {
                         substitutedBase.symbol
                     }
 
-                if (anyBaseEnhanced) {
+                if (anyBaseEnhanced && !anyReported) {
                     member.symbol.checkReturnType(enhancedOverrides, typeCheckerState, context)?.let {
                         reporter.reportOn(
                             member.source, FirJvmErrors.WRONG_NULLABILITY_FOR_JAVA_OVERRIDE, member.symbol, it, context
@@ -72,7 +74,8 @@ object FirOverrideJavaNullabilityWarningChecker : FirAbstractOverrideChecker() {
                         val substitutedBase = it.fir.substituteOrNull(substitutor, context) ?: return@map it
                         anyBaseEnhanced = true
 
-                        if (!context.session.firOverrideChecker.isOverriddenProperty(member, substitutedBase)) {
+                        if (!anyReported && !context.session.firOverrideChecker.isOverriddenProperty(member, substitutedBase)) {
+                            anyReported = true
                             reporter.reportOn(
                                 member.source,
                                 FirJvmErrors.WRONG_NULLABILITY_FOR_JAVA_OVERRIDE,
@@ -85,7 +88,7 @@ object FirOverrideJavaNullabilityWarningChecker : FirAbstractOverrideChecker() {
                         substitutedBase.symbol
                     }
 
-                if (anyBaseEnhanced) {
+                if (anyBaseEnhanced && !anyReported) {
                     member.symbol.checkReturnType(enhancedOverrides, typeCheckerState, context)?.let {
                         reporter.reportOn(
                             member.source, FirJvmErrors.WRONG_NULLABILITY_FOR_JAVA_OVERRIDE, member.symbol, it, context

compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.fir.kt

@@ -0,0 +1,64 @@
+// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER
+// JSR305_GLOBAL_REPORT: warn
+
+// FILE: test/NonNullApi.java
+package test;
+
+import java.lang.annotation.*;
+import javax.annotation.Nonnull;
+import javax.annotation.meta.TypeQualifierDefault;
+
+@Target(ElementType.PACKAGE)
+@Retention(RetentionPolicy.RUNTIME)
+@Documented
+@Nonnull
+@TypeQualifierDefault({ElementType.METHOD, ElementType.PARAMETER, ElementType.PACKAGE})
+public @interface NonNullApi {
+}
+
+// FILE: test/package-info.java
+@NonNullApi
+package test;
+
+// FILE: test/Provider.java
+package test;
+
+import javax.annotation.*;
+
+public interface Provider<T> {
+    T get();
+    @Nullable T getNullable();
+    void set(T x);
+    void setNullable(@Nullable T x);
+
+    T getSet(T x);
+    @Nullable T getSetNullable(@Nullable T x);
+}
+
+// FILE: test/I.java
+package test;
+
+import javax.annotation.*;
+
+public interface I<T> {
+    T get();
+    void set(T x);
+}
+
+// FILE: main.kt
+package test;
+
+abstract class Multiple<T> : Provider<T>, I<T> {
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun get(): T = null!!
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun set(x: T) {} // Missing warning in K1, K2 get's this right
+}
+
+abstract class A<T> : Provider<T> {
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun get(): T = null!!
+    override fun getNullable(): T = null!!
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun set(x: T) {} // Missing warning in K1, K2 get's this right
+    <!NOTHING_TO_OVERRIDE!>override<!> fun setNullable(x: T) {}
+
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun getSet(x: T): T = x
+    <!NOTHING_TO_OVERRIDE!>override<!> fun getSetNullable(x: T): T = x
+}

compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt

@@ -0,0 +1,64 @@
+// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER
+// JSR305_GLOBAL_REPORT: warn
+
+// FILE: test/NonNullApi.java
+package test;
+
+import java.lang.annotation.*;
+import javax.annotation.Nonnull;
+import javax.annotation.meta.TypeQualifierDefault;
+
+@Target(ElementType.PACKAGE)
+@Retention(RetentionPolicy.RUNTIME)
+@Documented
+@Nonnull
+@TypeQualifierDefault({ElementType.METHOD, ElementType.PARAMETER, ElementType.PACKAGE})
+public @interface NonNullApi {
+}
+
+// FILE: test/package-info.java
+@NonNullApi
+package test;
+
+// FILE: test/Provider.java
+package test;
+
+import javax.annotation.*;
+
+public interface Provider<T> {
+    T get();
+    @Nullable T getNullable();
+    void set(T x);
+    void setNullable(@Nullable T x);
+
+    T getSet(T x);
+    @Nullable T getSetNullable(@Nullable T x);
+}
+
+// FILE: test/I.java
+package test;
+
+import javax.annotation.*;
+
+public interface I<T> {
+    T get();
+    void set(T x);
+}
+
+// FILE: main.kt
+package test;
+
+abstract class Multiple<T> : Provider<T>, I<T> {
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun get(): T = null!!
+    override fun set(x: T) {} // Missing warning in K1, K2 get's this right
+}
+
+abstract class A<T> : Provider<T> {
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun get(): T = null!!
+    override fun getNullable(): T = null!!
+    override fun set(x: T) {} // Missing warning in K1, K2 get's this right
+    <!NOTHING_TO_OVERRIDE!>override<!> fun setNullable(x: T) {}
+
+    <!WRONG_NULLABILITY_FOR_JAVA_OVERRIDE!>override<!> fun getSet(x: T): T = x
+    <!NOTHING_TO_OVERRIDE!>override<!> fun getSetNullable(x: T): T = x
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/ForeignAnnotationsCompiledJavaTestGenerated.java

@@ -240,6 +240,12 @@ public class ForeignAnnotationsCompiledJavaTestGenerated extends AbstractForeign
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/ForeignAnnotationsCompiledJavaWithPsiClassReadingTestGenerated.java

@@ -298,6 +298,12 @@ public class ForeignAnnotationsCompiledJavaWithPsiClassReadingTestGenerated exte
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/ForeignAnnotationsSourceJavaTestGenerated.java

@@ -298,6 +298,12 @@ public class ForeignAnnotationsSourceJavaTestGenerated extends AbstractForeignAn
                     runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/nullabilityNicknames.kt");
                 }
 
+                @Test
+                @TestMetadata("override.kt")
+                public void testOverride() throws Exception {
+                    runTest("compiler/testData/diagnostics/foreignAnnotationsTests/tests/jsr305/nullabilityWarnings/override.kt");
+                }
+
                 @Test
                 @TestMetadata("safeCalls.kt")
                 public void testSafeCalls() throws Exception {