Convert Java lists to MutableLists

Java lists were given jet.List type, which is incorrect, since Java
lists are mutable and jet.List is immutable. Fixed test cases.
This commit is contained in:
Santeri Hiltunen
2013-03-11 18:55:15 +02:00
committed by Pavel V. Talanov
parent c701da8506
commit 475d02a80f
8 changed files with 38 additions and 7 deletions
@@ -79,6 +79,10 @@ public open class TypeVisitor(private val myConverter : Converter) : PsiTypeVisi
if (qualifiedName.equals(CommonClassNames.JAVA_UTIL_ITERATOR)) {
return Identifier(CommonClassNames.JAVA_UTIL_ITERATOR)
}
if (qualifiedName.equals(CommonClassNames.JAVA_UTIL_LIST)) {
return Identifier("MutableList")
}
}
}
+14
View File
@@ -0,0 +1,14 @@
import java.util.*;
public class Lists {
public void test() {
List<Object> xs = new ArrayList<Object>();
List<Object> ys = new LinkedList<Object>();
ArrayList<Object> zs = new ArrayList<Object>();
xs.add(null);
ys.add(null);
xs.clear();
ys.clear();
zs.add(null);
}
}
+13
View File
@@ -0,0 +1,13 @@
import java.util.*
public open class Lists() {
public open fun test() : Unit {
var xs : MutableList<Any?>? = ArrayList<Any?>()
var ys : MutableList<Any?>? = LinkedList<Any?>()
var zs : ArrayList<Any?>? = ArrayList<Any?>()
xs?.add(null)
ys?.add(null)
xs?.clear()
ys?.clear()
zs?.add(null)
}
}
@@ -1,6 +1,6 @@
package test
open class User() {
open fun main() : Unit {
var list : List<*>? = java.util.LinkedList()
var list : MutableList<*>? = java.util.LinkedList()
}
}
@@ -1,6 +1,6 @@
package test
open class User() {
open fun main() : Unit {
var list : java.util.List<*>? = java.util.LinkedList()
var list : MutableList<*>? = java.util.LinkedList()
}
}
@@ -1,6 +1,6 @@
import java.util.LinkedList
open class User() {
open fun main() : Unit {
var list : List<String?>? = LinkedList<String?>()
var list : MutableList<String?>? = LinkedList<String?>()
}
}
@@ -4,7 +4,7 @@ open class Member() {
}
open class User() {
open fun main() : Unit {
var members : List<Member?>? = LinkedList<Member?>()
var members : MutableList<Member?>? = LinkedList<Member?>()
members?.add(Member())
}
}
@@ -2,8 +2,8 @@ package demo
import java.util.LinkedList
open class Test() {
open fun main() : Unit {
var common : List<String?>? = LinkedList<String?>()
var raw : List<*>? = LinkedList<String?>()
var superRaw : List<*>? = LinkedList()
var common : MutableList<String?>? = LinkedList<String?>()
var raw : MutableList<*>? = LinkedList<String?>()
var superRaw : MutableList<*>? = LinkedList()
}
}