azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor "change type to mutable" in suspicious collection reassignment

Browse Source 
Related to KT-20626
This commit is contained in:
Mikhail Glukhikh
2018-12-12 15:41:16 +03:00
parent b17ee60c6f
commit 42fa6ce6f0
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/SuspiciousCollectionReassignmentInspection.kt
+10 -6
View File
@@ -84,12 +84,7 @@ class SuspiciousCollectionReassignmentInspection : AbstractKotlinInspection() {
val initializer = property.initializer ?: return
val fqName = initializer.resolveToCall()?.resultingDescriptor?.fqNameOrNull()?.asString()
val psiFactory = KtPsiFactory(binaryExpression)
val mutableOf = when (fqName) {
"kotlin.collections.listOf" -> "mutableListOf"
"kotlin.collections.setOf" -> "mutableSetOf"
"kotlin.collections.mapOf" -> "mutableMapOf"
else -> null
}
val mutableOf = mutableConversionMap[fqName]
if (mutableOf != null) {
(initializer as? KtCallExpression)?.calleeExpression?.replaced(psiFactory.createExpression(mutableOf)) ?: return
} else {
@@ -113,6 +108,15 @@ class SuspiciousCollectionReassignmentInspection : AbstractKotlinInspection() {
}
companion object {
private const val COLLECTIONS = "kotlin.collections"
private val mutableConversionMap = mapOf(
"$COLLECTIONS.listOf" to "mutableListOf",
"$COLLECTIONS.setOf" to "mutableSetOf",
"$COLLECTIONS.mapOf" to "mutableMapOf"
)
fun isApplicable(property: KtProperty): Boolean {
return property.isLocal && property.initializer != null
}