JS backend: basic support for class literals.

Added:
* the ability to get KClass using class literals (`::class`);
* the ability to get KClass from JsClass and vice versa;
* the ability to get simpleName.

 #KT-13345 Fixed
This commit is contained in:
Zalim Bashorov
2016-10-04 17:39:37 +03:00
parent ace10f46b2
commit 3c520a3ce3
14 changed files with 310 additions and 21 deletions
+1
View File
@@ -3,6 +3,7 @@
<words>
<w>ctor</w>
<w>interner</w>
<w>kclass</w>
<w>lookups</w>
<w>unescape</w>
</words>
@@ -16,13 +16,24 @@
package kotlin.js
import kotlin.reflect.KClass
import kotlin.reflect.js.internal.KClassImpl
@native
interface JsClass<T : Any> {
val name: String
}
@native
@Deprecated("Use class literal and extension property `js` instead.", replaceWith = ReplaceWith("T::class.js"))
fun <T : Any> jsClass(): JsClass<T> = noImpl
@Deprecated("Use class literal and extension property `js` instead.", replaceWith = ReplaceWith("this::class.js"))
val <T : Any> T.jsClass: JsClass<T>
get() = js("Object").getPrototypeOf(this).constructor
val <T : Any> KClass<T>.js: JsClass<T>
get() = (this as KClassImpl<T>).jClass
val <T : Any> JsClass<T>.kotlin: KClass<T>
get() = KClassImpl<T>(this)
+81
View File
@@ -0,0 +1,81 @@
/*
* Copyright 2010-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package kotlin.reflect.js.internal
import kotlin.reflect.*
internal class KClassImpl<T : Any>(
internal val jClass: JsClass<T>
) : KClass<T> {
private val metadata = jClass.asDynamic().`$metadata$`
// TODO: use FQN
private val hashCode = simpleName?.hashCode() ?: 0
override val simpleName: String?
get() = metadata?.simpleName
override val annotations: List<Annotation>
get() = TODO()
override val constructors: Collection<KFunction<T>>
get() = TODO()
override val isAbstract: Boolean
get() = TODO()
override val isCompanion: Boolean
get() = TODO()
override val isData: Boolean
get() = TODO()
override val isFinal: Boolean
get() = TODO()
override val isInner: Boolean
get() = TODO()
override val isOpen: Boolean
get() = TODO()
override val isSealed: Boolean
get() = TODO()
override val members: Collection<KCallable<*>>
get() = TODO()
override val nestedClasses: Collection<KClass<*>>
get() = TODO()
override val objectInstance: T?
get() = TODO()
override val qualifiedName: String?
get() = TODO()
override val supertypes: List<KType>
get() = TODO()
override val typeParameters: List<KTypeParameter>
get() = TODO()
override val visibility: KVisibility?
get() = TODO()
override fun equals(other: Any?): Boolean {
return other is KClassImpl<*> && jClass == other.jClass
}
override fun hashCode(): Int {
return hashCode
}
override fun isInstance(value: Any?): Boolean {
TODO()
}
override fun toString(): String {
// TODO: use FQN
return "class $simpleName"
}
}
+44
View File
@@ -0,0 +1,44 @@
/*
* Copyright 2010-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
// a package is omitted to get declarations directly under the module
import kotlin.reflect.KClass
import kotlin.reflect.js.internal.KClassImpl
@JsName("getKClass")
private fun <T : Any> getKClass(jClass: JsClass<T>): KClass<T> = getOrCreateKClass(jClass)
@JsName("getKClassFromExpression")
private fun <T : Any> getKClassFromExpression(e: T): KClass<T> = getOrCreateKClass(e.jsClass)
private fun <T : Any> getOrCreateKClass(jClass: JsClass<T>): KClass<T> {
val metadata = jClass.asDynamic().`$metadata$`
return if (metadata != null) {
if (metadata.`$kClass$` == null) {
val kClass = KClassImpl(jClass)
metadata.`$kClass$` = kClass
kClass
}
else {
metadata.`$kClass$`
}
}
else {
KClassImpl(jClass)
}
}
@@ -6252,6 +6252,30 @@ public class BoxJsTestGenerated extends AbstractBoxJsTest {
String fileName = KotlinTestUtils.navigationMetadata("js/js.translator/testData/box/reflection/jsClassSimpleName.kt");
doTest(fileName);
}
@TestMetadata("kClass.kt")
public void testKClass() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("js/js.translator/testData/box/reflection/kClass.kt");
doTest(fileName);
}
@TestMetadata("kClassOnReifiedType.kt")
public void testKClassOnReifiedType() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("js/js.translator/testData/box/reflection/kClassOnReifiedType.kt");
doTest(fileName);
}
@TestMetadata("kClassSimpleName.kt")
public void testKClassSimpleName() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("js/js.translator/testData/box/reflection/kClassSimpleName.kt");
doTest(fileName);
}
@TestMetadata("kClassToAndFromJsClass.kt")
public void testKClassToAndFromJsClass() throws Exception {
String fileName = KotlinTestUtils.navigationMetadata("js/js.translator/testData/box/reflection/kClassToAndFromJsClass.kt");
doTest(fileName);
}
}
@TestMetadata("js/js.translator/testData/box/regression")
@@ -67,6 +67,8 @@ public final class Namer {
public static final String IS_CHAR = "isChar";
public static final String IS_NUMBER = "isNumber";
public static final String IS_CHAR_SEQUENCE = "isCharSequence";
public static final String GET_KCLASS = "getKClass";
public static final String GET_KCLASS_FROM_EXPRESSION = "getKClassFromExpression";
public static final String CALLEE_NAME = "$fun";
@@ -29,14 +29,15 @@ import org.jetbrains.kotlin.descriptors.annotations.KotlinRetention;
import org.jetbrains.kotlin.js.translate.context.Namer;
import org.jetbrains.kotlin.js.translate.context.TranslationContext;
import org.jetbrains.kotlin.js.translate.declaration.ClassTranslator;
import org.jetbrains.kotlin.js.translate.general.Translation;
import org.jetbrains.kotlin.js.translate.declaration.PropertyTranslatorKt;
import org.jetbrains.kotlin.js.translate.general.Translation;
import org.jetbrains.kotlin.js.translate.general.TranslatorVisitor;
import org.jetbrains.kotlin.js.translate.operation.BinaryOperationTranslator;
import org.jetbrains.kotlin.js.translate.operation.UnaryOperationTranslator;
import org.jetbrains.kotlin.js.translate.reference.*;
import org.jetbrains.kotlin.js.translate.utils.BindingUtils;
import org.jetbrains.kotlin.js.translate.utils.JsAstUtils;
import org.jetbrains.kotlin.js.translate.utils.UtilsKt;
import org.jetbrains.kotlin.psi.*;
import org.jetbrains.kotlin.psi.psiUtil.PsiUtilsKt;
import org.jetbrains.kotlin.resolve.BindingContext;
@@ -44,17 +45,16 @@ import org.jetbrains.kotlin.resolve.BindingContextUtils;
import org.jetbrains.kotlin.resolve.bindingContextUtil.BindingContextUtilsKt;
import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall;
import org.jetbrains.kotlin.resolve.constants.CompileTimeConstant;
import org.jetbrains.kotlin.resolve.constants.ConstantValue;
import org.jetbrains.kotlin.resolve.constants.NullValue;
import org.jetbrains.kotlin.resolve.constants.evaluate.ConstantExpressionEvaluator;
import org.jetbrains.kotlin.resolve.descriptorUtil.DescriptorUtilsKt;
import org.jetbrains.kotlin.resolve.inline.InlineUtil;
import org.jetbrains.kotlin.types.KotlinType;
import org.jetbrains.kotlin.types.TypeUtils;
import org.jetbrains.kotlin.types.expressions.DoubleColonLHS;
import java.util.ArrayList;
import java.util.List;
import static org.jetbrains.kotlin.js.translate.context.Namer.GET_KCLASS;
import static org.jetbrains.kotlin.js.translate.context.Namer.GET_KCLASS_FROM_EXPRESSION;
import static org.jetbrains.kotlin.js.translate.context.Namer.getCapturedVarAccessor;
import static org.jetbrains.kotlin.js.translate.general.Translation.translateAsExpression;
import static org.jetbrains.kotlin.js.translate.utils.BindingUtils.*;
@@ -63,8 +63,7 @@ import static org.jetbrains.kotlin.js.translate.utils.JsAstUtils.convertToStatem
import static org.jetbrains.kotlin.js.translate.utils.JsAstUtils.newVar;
import static org.jetbrains.kotlin.js.translate.utils.JsDescriptorUtils.getReceiverParameterForDeclaration;
import static org.jetbrains.kotlin.js.translate.utils.TranslationUtils.translateInitializerForProperty;
import static org.jetbrains.kotlin.resolve.BindingContext.DECLARATION_TO_DESCRIPTOR;
import static org.jetbrains.kotlin.resolve.BindingContext.LABEL_TARGET;
import static org.jetbrains.kotlin.resolve.BindingContext.*;
import static org.jetbrains.kotlin.resolve.BindingContextUtils.isVarCapturedInClosure;
import static org.jetbrains.kotlin.resolve.calls.callUtil.CallUtilKt.getResolvedCallWithAssert;
import static org.jetbrains.kotlin.types.expressions.ExpressionTypingUtils.isFunctionExpression;
@@ -226,6 +225,25 @@ public final class ExpressionVisitor extends TranslatorVisitor<JsNode> {
return CallableReferenceTranslator.INSTANCE.translate(expression, context);
}
@Override
public JsNode visitClassLiteralExpression(
@NotNull KtClassLiteralExpression expression, TranslationContext context
) {
KtExpression receiverExpression = expression.getReceiverExpression();
assert receiverExpression != null : "Class literal expression should have a left-hand side";
DoubleColonLHS lhs = context.bindingContext().get(DOUBLE_COLON_LHS, receiverExpression);
assert lhs != null : "Class literal expression should have LHS resolved";
if (lhs instanceof DoubleColonLHS.Expression && !((DoubleColonLHS.Expression) lhs).isObject()) {
JsExpression receiver = translateAsExpression(receiverExpression, context);
return new JsInvocation(context.namer().kotlin(GET_KCLASS_FROM_EXPRESSION), receiver);
}
return new JsInvocation(context.namer().kotlin(GET_KCLASS), UtilsKt.getReferenceToJsClass(lhs.getType(), context));
}
@Override
@NotNull
public JsNode visitCallExpression(
+15
View File
@@ -20,3 +20,18 @@ enum class E {
@JsName("Q")
class R
fun check(x: Any, y: Any, shouldBeEqual: Boolean = true, shouldBeSame: Boolean = true) {
assertNotEquals(null, x)
assertNotEquals(null, y)
if (shouldBeEqual) {
assertEquals(x, y)
if (shouldBeSame && x !== y) {
fail("Expected same instances, got expected = '$x', actual = '$y'")
}
}
else {
assertNotEquals(x, y)
}
}
+1 -10
View File
@@ -1,21 +1,12 @@
package foo
fun check(x: JsClass<*>, y: JsClass<*>, shouldBeEquals: Boolean = true) {
assertNotEquals(null, x)
assertNotEquals(null, y)
if (shouldBeEquals)
assertEquals(x, y)
else
assertNotEquals(x, y)
}
fun box(): String {
check(jsClass<A>(), A().jsClass)
check(jsClass<B>(), B().jsClass)
check(jsClass<O>(), O.jsClass)
assertNotEquals(null, jsClass<I>())
check(jsClass<E>(), E.X.jsClass)
check(jsClass<E>(), E.Y.jsClass, shouldBeEquals = false)
check(jsClass<E>(), E.Y.jsClass, shouldBeEqual = false)
// TODO uncomment after KT-13338 is fixed
// check(jsClass<E>(), E.Z.jsClass)
@@ -6,10 +6,10 @@ inline fun <reified T : Any> foo(): JsClass<T> {
}
fun box(): String {
assertEquals(jsClass<A>(), foo<A>())
assertEquals(jsClass<B>(), foo<B>())
assertEquals(jsClass<O>(), foo<O>())
assertEquals(jsClass<E>(), foo<E>())
check(jsClass<A>(), foo<A>())
check(jsClass<B>(), foo<B>())
check(jsClass<O>(), foo<O>())
check(jsClass<E>(), foo<E>())
return "OK"
}
+14
View File
@@ -0,0 +1,14 @@
package foo
fun box(): String {
check(A::class, A()::class)
check(B::class, B()::class)
check(O::class, (O)::class)
assertNotEquals(null, I::class)
check(E::class, E.X::class)
check(E::class, E.Y::class, shouldBeEqual = false)
// TODO uncomment after KT-13338 is fixed
// check(E::class, E.Z::class)
return "OK"
}
@@ -0,0 +1,19 @@
package foo
import kotlin.reflect.KClass
inline fun <reified T : Any> foo(b: Boolean = false): KClass<T> {
if (b) {
val T = 1
}
return T::class
}
fun box(): String {
check(A::class, foo<A>())
check(B::class, foo<B>())
check(O::class, foo<O>())
check(E::class, foo<E>())
return "OK"
}
@@ -0,0 +1,40 @@
package foo
class undefined
class Outer {
class Nested
inner class Inner
}
fun testWithInstance() {
assertEquals("A", A()::class.simpleName)
assertEquals("B", B()::class.simpleName)
assertEquals("O", (O)::class.simpleName)
assertEquals("E", E.X::class.simpleName)
assertEquals("Y", E.Y::class.simpleName)
// TODO uncomment after KT-13338 is fixed
// assertEquals("E", E.Z::class.simpleName)
assertEquals("undefined", undefined()::class.simpleName)
assertEquals("Nested", Outer.Nested()::class.simpleName)
assertEquals("Inner", Outer().Inner()::class.simpleName)
}
fun testWithClassReference() {
assertEquals("A", A::class.simpleName)
assertEquals("B", B::class.simpleName)
assertEquals("O", O::class.simpleName)
assertEquals("I", I::class.simpleName)
assertEquals("E", E::class.simpleName)
assertEquals("undefined", foo.undefined::class.simpleName)
assertEquals("Nested", Outer.Nested::class.simpleName)
assertEquals("Inner", Outer.Inner::class.simpleName)
}
fun box(): String {
testWithInstance()
testWithClassReference()
return "OK"
}
@@ -0,0 +1,29 @@
package foo
import kotlin.reflect.KClass
fun check(k: KClass<*>, j: JsClass<*>) {
assertNotEquals(null, k)
assertNotEquals(null, j)
assertEquals(k.js, j)
assertEquals(k, j.kotlin)
assertEquals(j, j.kotlin.js)
assertEquals(k, k.js.kotlin)
}
fun jsClassbyName(name: String) = js("JS_TESTS").foo[name]
fun box(): String {
check(A::class, jsClassbyName("A"))
check(B::class, jsClassbyName("B"))
check(O::class, jsClassbyName("O").constructor)
check(I::class, jsClassbyName("I"))
check(E::class, jsClassbyName("E"))
check(E.X::class, jsClassbyName("E").X.constructor)
check(E.Y::class, jsClassbyName("E").Y.constructor)
// TODO uncomment after KT-13338 is fixed
// check(E.Z::class, jsClassbyName("E").Z.constructor)
return "OK"
}